All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: sm750fb: Move misplaced open brace to previous line
@ 2015-03-20 18:20 Marianne Moeller Knudsen
  2015-03-23 21:29 ` [Outreachy kernel] " Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Marianne Moeller Knudsen @ 2015-03-20 18:20 UTC (permalink / raw)
  To: outreachy-kernel

Move open brace { to same line as statement. Issue found by checkpatch.

Signed-off-by: Marianne Moeller Knudsen <marianne@masu.dk>
---
 drivers/staging/sm750fb/ddk750_chip.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 33add64..0392020 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -118,8 +118,7 @@ void setChipClock(unsigned int frequency)
 			return;
 #endif
 
-    if (frequency != 0)
-    {
+    if (frequency != 0) {
         /*
          * Set up PLL, a structure to hold the value to be set in clocks.
          */
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: sm750fb: Move misplaced open brace to previous line
  2015-03-20 18:20 [PATCH] staging: sm750fb: Move misplaced open brace to previous line Marianne Moeller Knudsen
@ 2015-03-23 21:29 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-03-23 21:29 UTC (permalink / raw)
  To: Marianne Moeller Knudsen; +Cc: outreachy-kernel

On Fri, Mar 20, 2015 at 07:20:43PM +0100, Marianne Moeller Knudsen wrote:
> Move open brace { to same line as statement. Issue found by checkpatch.
> 
> Signed-off-by: Marianne Moeller Knudsen <marianne@masu.dk>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 33add64..0392020 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -118,8 +118,7 @@ void setChipClock(unsigned int frequency)
>  			return;
>  #endif
>  
> -    if (frequency != 0)
> -    {
> +    if (frequency != 0) {
>          /*
>           * Set up PLL, a structure to hold the value to be set in clocks.
>           */

This doesn't apply to my tree, and neither did any of the other patches
you sent me for this driver :(

Please sync up on the proper git tree and resend _ALL_ of your patches,
in a patch series, so that I have a chance to be able to apply them.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-23 23:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-20 18:20 [PATCH] staging: sm750fb: Move misplaced open brace to previous line Marianne Moeller Knudsen
2015-03-23 21:29 ` [Outreachy kernel] " Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.