All of lore.kernel.org
 help / color / mirror / Atom feed
From: mgorman@suse.de (Mel Gorman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: print cma-reserved pages from show_mem
Date: Thu, 26 Mar 2015 13:47:47 +0000	[thread overview]
Message-ID: <20150326134747.GN4701@suse.de> (raw)
In-Reply-To: <20150326132258.GH8656@n2100.arm.linux.org.uk>

On Thu, Mar 26, 2015 at 01:22:59PM +0000, Russell King - ARM Linux wrote:
> On Thu, Mar 26, 2015 at 12:30:29PM +0000, Mel Gorman wrote:
> > On Thu, Mar 26, 2015 at 11:46:12AM +0000, Russell King - ARM Linux wrote:
> > > <SNIP>
> > > 
> > > Looking at Mel's commit, I don't see a reason why we couldn't use that
> > > solution - it gets rid of walking the page array, which has been fraught
> > > in the past due to ARM having platforms which have holes in their
> > > physical memory.
> > > 
> > > We could try that solution - I don't see much downside to it.  Most of
> > > that information is as debug information for MM stuff anyway, and IMHO
> > 
> > >From an MM perspective, I can tell you that the information is close to
> > useless for debugging anything. It's why I ditched it in that commit and
> > AFAIK, no one has ever cared.
> 
> In that case, is there much point to show_mem()?  Is it something which
> should be considered for removal?
> 
> If code serves no useful purpose anymore, we really ought to have a way

Sorry I was not clear. show_mem itself is useful, the shared and
non-shared values that commit c78e93630d15b5f5774213aad9bdc9f52473a89b
removed are not.

-- 
Mel Gorman
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Gregory Fong <gregory.0xf0@gmail.com>,
	Laura Abbott <lauraa@codeaurora.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	Nicolas Pitre <nico@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	open list <linux-kernel@vger.kernel.org>,
	Yalin Wang <Yalin.Wang@sonymobile.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	vishnu.ps@samsung.com,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] ARM: print cma-reserved pages from show_mem
Date: Thu, 26 Mar 2015 13:47:47 +0000	[thread overview]
Message-ID: <20150326134747.GN4701@suse.de> (raw)
In-Reply-To: <20150326132258.GH8656@n2100.arm.linux.org.uk>

On Thu, Mar 26, 2015 at 01:22:59PM +0000, Russell King - ARM Linux wrote:
> On Thu, Mar 26, 2015 at 12:30:29PM +0000, Mel Gorman wrote:
> > On Thu, Mar 26, 2015 at 11:46:12AM +0000, Russell King - ARM Linux wrote:
> > > <SNIP>
> > > 
> > > Looking at Mel's commit, I don't see a reason why we couldn't use that
> > > solution - it gets rid of walking the page array, which has been fraught
> > > in the past due to ARM having platforms which have holes in their
> > > physical memory.
> > > 
> > > We could try that solution - I don't see much downside to it.  Most of
> > > that information is as debug information for MM stuff anyway, and IMHO
> > 
> > >From an MM perspective, I can tell you that the information is close to
> > useless for debugging anything. It's why I ditched it in that commit and
> > AFAIK, no one has ever cared.
> 
> In that case, is there much point to show_mem()?  Is it something which
> should be considered for removal?
> 
> If code serves no useful purpose anymore, we really ought to have a way

Sorry I was not clear. show_mem itself is useful, the shared and
non-shared values that commit c78e93630d15b5f5774213aad9bdc9f52473a89b
removed are not.

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2015-03-26 13:47 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 23:22 [PATCH] ARM: print cma-reserved pages from show_mem Gregory Fong
2015-02-04 23:22 ` Gregory Fong
2015-02-06  0:41 ` Laura Abbott
2015-02-06  0:41   ` Laura Abbott
2015-02-06 21:14   ` Gregory Fong
2015-02-06 21:14     ` Gregory Fong
2015-02-06 21:41     ` Laura Abbott
2015-02-06 21:41       ` Laura Abbott
2015-02-09 19:55       ` Gregory Fong
2015-02-09 19:55         ` Gregory Fong
2015-02-10 11:32         ` Russell King - ARM Linux
2015-02-10 11:32           ` Russell King - ARM Linux
2015-03-23  9:08           ` Gregory Fong
2015-03-23  9:08             ` Gregory Fong
2015-03-25 11:49             ` Mel Gorman
2015-03-25 11:49               ` Mel Gorman
2015-03-26 11:46             ` Russell King - ARM Linux
2015-03-26 11:46               ` Russell King - ARM Linux
2015-03-26 12:30               ` Mel Gorman
2015-03-26 12:30                 ` Mel Gorman
2015-03-26 13:22                 ` Russell King - ARM Linux
2015-03-26 13:22                   ` Russell King - ARM Linux
2015-03-26 13:47                   ` Mel Gorman [this message]
2015-03-26 13:47                     ` Mel Gorman
2015-04-10  4:36                 ` Gregory Fong
2015-04-10  4:36                   ` Gregory Fong
2015-04-10  5:18                   ` Wang, Yalin
2015-04-10  5:18                     ` Wang, Yalin
2015-04-10 11:24                     ` Russell King - ARM Linux
2015-04-10 11:24                       ` Russell King - ARM Linux
2015-04-13  1:09                       ` Gregory Fong
2015-04-13  1:09                         ` Gregory Fong
2015-04-13  1:21                         ` Gregory Fong
2015-04-13  1:21                           ` Gregory Fong
2015-04-13  9:56                           ` Russell King - ARM Linux
2015-04-13  9:56                             ` Russell King - ARM Linux
2015-04-13 10:04                             ` Mel Gorman
2015-04-13 10:04                               ` Mel Gorman
2015-04-13 10:05                               ` Russell King - ARM Linux
2015-04-13 10:05                                 ` Russell King - ARM Linux
2015-04-13 12:29                                 ` Gregory Fong
2015-04-13 12:29                                   ` Gregory Fong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150326134747.GN4701@suse.de \
    --to=mgorman@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.