From: mgorman@suse.de (Mel Gorman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: print cma-reserved pages from show_mem
Date: Mon, 13 Apr 2015 11:04:26 +0100 [thread overview]
Message-ID: <20150413100425.GB14842@suse.de> (raw)
In-Reply-To: <20150413095645.GQ12732@n2100.arm.linux.org.uk>
On Mon, Apr 13, 2015 at 10:56:45AM +0100, Russell King - ARM Linux wrote:
> On Sun, Apr 12, 2015 at 06:21:15PM -0700, Gregory Fong wrote:
> > On Sun, Apr 12, 2015 at 06:09:13PM -0700, Gregory Fong wrote:
> > > And now we see 83 slab_reclaimable + 846 slab_unreclaimable adds up
> > > correctly to the total of 929.
> > >
> > > The patch below will end up with the correct count.
> > >
> >
> > Sorry, messed up the patch formatting. Here it is fixed:
>
> So now the question is: do we fix this, or do we use the generic version?
> Given that the total number of slab pages can be easily deduced from the
> generic statistics, do we need to modify the generic version to print an
> additional line with this?
Whatever ARM decides, I do not think the generic version needs to do
a PFN walk to recaluate the SLAB statistics. The slab_reclaimable and
slab_unreclaimable stats based on the vmstat counters is sufficient.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Gregory Fong <gregory.0xf0@gmail.com>,
"Wang, Yalin" <Yalin.Wang@sonymobile.com>,
Laura Abbott <lauraa@codeaurora.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Kees Cook <keescook@chromium.org>,
Nicolas Pitre <nico@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
open list <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"vishnu.ps@samsung.com" <vishnu.ps@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] ARM: print cma-reserved pages from show_mem
Date: Mon, 13 Apr 2015 11:04:26 +0100 [thread overview]
Message-ID: <20150413100425.GB14842@suse.de> (raw)
In-Reply-To: <20150413095645.GQ12732@n2100.arm.linux.org.uk>
On Mon, Apr 13, 2015 at 10:56:45AM +0100, Russell King - ARM Linux wrote:
> On Sun, Apr 12, 2015 at 06:21:15PM -0700, Gregory Fong wrote:
> > On Sun, Apr 12, 2015 at 06:09:13PM -0700, Gregory Fong wrote:
> > > And now we see 83 slab_reclaimable + 846 slab_unreclaimable adds up
> > > correctly to the total of 929.
> > >
> > > The patch below will end up with the correct count.
> > >
> >
> > Sorry, messed up the patch formatting. Here it is fixed:
>
> So now the question is: do we fix this, or do we use the generic version?
> Given that the total number of slab pages can be easily deduced from the
> generic statistics, do we need to modify the generic version to print an
> additional line with this?
Whatever ARM decides, I do not think the generic version needs to do
a PFN walk to recaluate the SLAB statistics. The slab_reclaimable and
slab_unreclaimable stats based on the vmstat counters is sufficient.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2015-04-13 10:04 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 23:22 [PATCH] ARM: print cma-reserved pages from show_mem Gregory Fong
2015-02-04 23:22 ` Gregory Fong
2015-02-06 0:41 ` Laura Abbott
2015-02-06 0:41 ` Laura Abbott
2015-02-06 21:14 ` Gregory Fong
2015-02-06 21:14 ` Gregory Fong
2015-02-06 21:41 ` Laura Abbott
2015-02-06 21:41 ` Laura Abbott
2015-02-09 19:55 ` Gregory Fong
2015-02-09 19:55 ` Gregory Fong
2015-02-10 11:32 ` Russell King - ARM Linux
2015-02-10 11:32 ` Russell King - ARM Linux
2015-03-23 9:08 ` Gregory Fong
2015-03-23 9:08 ` Gregory Fong
2015-03-25 11:49 ` Mel Gorman
2015-03-25 11:49 ` Mel Gorman
2015-03-26 11:46 ` Russell King - ARM Linux
2015-03-26 11:46 ` Russell King - ARM Linux
2015-03-26 12:30 ` Mel Gorman
2015-03-26 12:30 ` Mel Gorman
2015-03-26 13:22 ` Russell King - ARM Linux
2015-03-26 13:22 ` Russell King - ARM Linux
2015-03-26 13:47 ` Mel Gorman
2015-03-26 13:47 ` Mel Gorman
2015-04-10 4:36 ` Gregory Fong
2015-04-10 4:36 ` Gregory Fong
2015-04-10 5:18 ` Wang, Yalin
2015-04-10 5:18 ` Wang, Yalin
2015-04-10 11:24 ` Russell King - ARM Linux
2015-04-10 11:24 ` Russell King - ARM Linux
2015-04-13 1:09 ` Gregory Fong
2015-04-13 1:09 ` Gregory Fong
2015-04-13 1:21 ` Gregory Fong
2015-04-13 1:21 ` Gregory Fong
2015-04-13 9:56 ` Russell King - ARM Linux
2015-04-13 9:56 ` Russell King - ARM Linux
2015-04-13 10:04 ` Mel Gorman [this message]
2015-04-13 10:04 ` Mel Gorman
2015-04-13 10:05 ` Russell King - ARM Linux
2015-04-13 10:05 ` Russell King - ARM Linux
2015-04-13 12:29 ` Gregory Fong
2015-04-13 12:29 ` Gregory Fong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413100425.GB14842@suse.de \
--to=mgorman@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.