From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: rtc-linux@googlegroups.com, Sangbeom Kim <sbkim73@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [rtc-linux] Re: [PATCH v2 2/2] mfd: sec-core: Modify RTC compatible name of S2MPS13
Date: Thu, 26 Mar 2015 14:18:12 +0000 [thread overview]
Message-ID: <20150326141812.GO5951@x1> (raw)
In-Reply-To: <CAJKOXPeh1McgSxJD23G=2QijRAQM2YGHbDFeGiA4bQQ-mRX-FA@mail.gmail.com>
On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote:
> 2015-03-23 13:34 GMT+01:00 Lee Jones <lee.jones@linaro.org>:
> > On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote:
> >
> >> From: Chanwoo Choi <cw00.choi@samsung.com>
> >>
> >> This patch modify the RTC compatible name of S2MPS13 because S2MPS13's=
RTC is
> >> equal to S2MPS14's RTC.
> >>
> >> Cc: Lee Jones <lee.jones@linaro.org>
> >> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >>
> >> ---
> >>
> >> Changes since v1:
> >> 1. New patch.
> >> ---
> >> drivers/mfd/sec-core.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Applied, thanks.
>=20
> Hi,
>=20
> Sorry for the mess but we did this wrong.
> The S2MPS13 RTC is slightly different than S2MPS14 and that difference
> is important. It is embarrassing... but the difference was written
> small-print as a note in datasheet. Really. I found it after carefully
> comparing two PDFs. The impact of difference was not detected because
> of error in DTS for Exynos5433-based board.
>=20
> This patch should be dropped (or reverted) and "s2mps13-rtc" should be
> used for S2MPS13 RTC mfd_cell. The RTC driver (rtc/rtxc-s5m) should
> have its own support for RTC which I will add in separate patch.
>=20
> Lee, once again sorry for the mess. How would you like to proceed? Can
> you just drop this commit?
Patch removed -- panic averted.
--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: rtc-linux@googlegroups.com, Sangbeom Kim <sbkim73@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [rtc-linux] Re: [PATCH v2 2/2] mfd: sec-core: Modify RTC compatible name of S2MPS13
Date: Thu, 26 Mar 2015 14:18:12 +0000 [thread overview]
Message-ID: <20150326141812.GO5951@x1> (raw)
In-Reply-To: <CAJKOXPeh1McgSxJD23G=2QijRAQM2YGHbDFeGiA4bQQ-mRX-FA@mail.gmail.com>
On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote:
> 2015-03-23 13:34 GMT+01:00 Lee Jones <lee.jones@linaro.org>:
> > On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote:
> >
> >> From: Chanwoo Choi <cw00.choi@samsung.com>
> >>
> >> This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is
> >> equal to S2MPS14's RTC.
> >>
> >> Cc: Lee Jones <lee.jones@linaro.org>
> >> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >>
> >> ---
> >>
> >> Changes since v1:
> >> 1. New patch.
> >> ---
> >> drivers/mfd/sec-core.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Applied, thanks.
>
> Hi,
>
> Sorry for the mess but we did this wrong.
> The S2MPS13 RTC is slightly different than S2MPS14 and that difference
> is important. It is embarrassing... but the difference was written
> small-print as a note in datasheet. Really. I found it after carefully
> comparing two PDFs. The impact of difference was not detected because
> of error in DTS for Exynos5433-based board.
>
> This patch should be dropped (or reverted) and "s2mps13-rtc" should be
> used for S2MPS13 RTC mfd_cell. The RTC driver (rtc/rtxc-s5m) should
> have its own support for RTC which I will add in separate patch.
>
> Lee, once again sorry for the mess. How would you like to proceed? Can
> you just drop this commit?
Patch removed -- panic averted.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-03-26 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 9:54 [PATCH v2 1/2] rtc: s5m: Allow usage on device type different than main MFD type Krzysztof Kozlowski
2015-03-17 9:54 ` [PATCH v2 2/2] mfd: sec-core: Modify RTC compatible name of S2MPS13 Krzysztof Kozlowski
2015-03-17 9:57 ` Krzysztof Kozlowski
2015-03-23 12:34 ` Lee Jones
2015-03-23 12:34 ` Lee Jones
2015-03-24 14:02 ` [rtc-linux] " Krzysztof Kozlowski
2015-03-26 14:18 ` Lee Jones [this message]
2015-03-26 14:18 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326141812.GO5951@x1 \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.