* [PATCH] Staging: comedi: addi_apci_1564: Delete whitespace @ 2015-03-30 15:40 Charlie Wong Super 2015-03-30 15:42 ` [Outreachy kernel] " Julia Lawall 2015-04-01 15:19 ` Greg KH 0 siblings, 2 replies; 5+ messages in thread From: Charlie Wong Super @ 2015-03-30 15:40 UTC (permalink / raw) To: outreachy-kernel This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114: + unsigned int ctrl; /* interrupt mode OR (edge) . AND (level) */ Signed-off-by: Charlie Wong Super <1213charlie@gmail.com> --- drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c b/drivers/staging/comedi/drivers/addi_apci_1564.c index c481c48..dd335e8 100644 --- a/drivers/staging/comedi/drivers/addi_apci_1564.c +++ b/drivers/staging/comedi/drivers/addi_apci_1564.c @@ -106,12 +106,12 @@ #define APCI1564_COUNTER(x) ((x) * 0x20) struct apci1564_private { - unsigned long eeprom; /* base address of EEPROM register */ - unsigned long timer; /* base address of 12-bit timer */ - unsigned long counters; /* base address of 32-bit counters */ - unsigned int mode1; /* riding-edge/high level channels */ - unsigned int mode2; /* falling-edge/low level channels */ - unsigned int ctrl; /* interrupt mode OR (edge) . AND (level) */ + unsigned long eeprom; /*base address of EEPROM register*/ + unsigned long timer; /*base address of 12-bit timer*/ + unsigned long counters; /*base address of 32-bit counters*/ + unsigned int mode1; /*riding-edge/high level channels*/ + unsigned int mode2; /*falling-edge/low level channels*/ + unsigned int ctrl; /*interrupt mode OR (edge).AND(level)*/ struct task_struct *tsk_current; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: comedi: addi_apci_1564: Delete whitespace 2015-03-30 15:40 [PATCH] Staging: comedi: addi_apci_1564: Delete whitespace Charlie Wong Super @ 2015-03-30 15:42 ` Julia Lawall 2015-03-31 5:10 ` Charlie WONG Super 2015-03-31 5:20 ` Charlie WONG Super 2015-04-01 15:19 ` Greg KH 1 sibling, 2 replies; 5+ messages in thread From: Julia Lawall @ 2015-03-30 15:42 UTC (permalink / raw) To: Charlie Wong Super; +Cc: outreachy-kernel On Mon, 30 Mar 2015, Charlie Wong Super wrote: > This patch fixes the checkpatch.pl warning: > WARNING: line over 80 characters > FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114: > + unsigned int ctrl; /* interrupt mode OR (edge) . AND (level) */ You don't really need the above two lines. One can see the specific file and the affected code lines just below. julia > > Signed-off-by: Charlie Wong Super <1213charlie@gmail.com> > --- > drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c b/drivers/staging/comedi/drivers/addi_apci_1564.c > index c481c48..dd335e8 100644 > --- a/drivers/staging/comedi/drivers/addi_apci_1564.c > +++ b/drivers/staging/comedi/drivers/addi_apci_1564.c > @@ -106,12 +106,12 @@ > #define APCI1564_COUNTER(x) ((x) * 0x20) > > struct apci1564_private { > - unsigned long eeprom; /* base address of EEPROM register */ > - unsigned long timer; /* base address of 12-bit timer */ > - unsigned long counters; /* base address of 32-bit counters */ > - unsigned int mode1; /* riding-edge/high level channels */ > - unsigned int mode2; /* falling-edge/low level channels */ > - unsigned int ctrl; /* interrupt mode OR (edge) . AND (level) */ > + unsigned long eeprom; /*base address of EEPROM register*/ > + unsigned long timer; /*base address of 12-bit timer*/ > + unsigned long counters; /*base address of 32-bit counters*/ > + unsigned int mode1; /*riding-edge/high level channels*/ > + unsigned int mode2; /*falling-edge/low level channels*/ > + unsigned int ctrl; /*interrupt mode OR (edge).AND(level)*/ > struct task_struct *tsk_current; > }; > > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150330154011.GA11201%40ThinkPad. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: comedi: addi_apci_1564: Delete whitespace 2015-03-30 15:42 ` [Outreachy kernel] " Julia Lawall @ 2015-03-31 5:10 ` Charlie WONG Super 2015-03-31 5:20 ` Charlie WONG Super 1 sibling, 0 replies; 5+ messages in thread From: Charlie WONG Super @ 2015-03-31 5:10 UTC (permalink / raw) To: outreachy-kernel; +Cc: 1213charlie [-- Attachment #1.1: Type: text/plain, Size: 5772 bytes --] I got it, and I will the message and send it again, thanks ! On Monday, March 30, 2015 at 11:43:14 PM UTC+8, Julia Lawall wrote: > > On Mon, 30 Mar 2015, Charlie Wong Super wrote: > > > This patch fixes the checkpatch.pl warning: > > WARNING: line over 80 characters > > FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114: > > + unsigned int ctrl; /* interrupt mode OR (edge) . > AND (level) */ > > You don't really need the above two lines. One can see the specific file > and the affected code lines just below. > > julia > > > > > Signed-off-by: Charlie Wong Super <1213c...@gmail.com <javascript:>> > > --- > > drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c > b/drivers/staging/comedi/drivers/addi_apci_1564.c > > index c481c48..dd335e8 100644 > > --- a/drivers/staging/comedi/drivers/addi_apci_1564.c > > +++ b/drivers/staging/comedi/drivers/addi_apci_1564.c > > @@ -106,12 +106,12 @@ > > #define APCI1564_COUNTER(x) ((x) * 0x20) > > > > struct apci1564_private { > > - unsigned long eeprom; /* base address of EEPROM > register */ > > - unsigned long timer; /* base address of 12-bit > timer */ > > - unsigned long counters; /* base address of > 32-bit counters */ > > - unsigned int mode1; /* riding-edge/high level > channels */ > > - unsigned int mode2; /* falling-edge/low level > channels */ > > - unsigned int ctrl; /* interrupt mode OR (edge) . > AND (level) */ > > + unsigned long eeprom; /*base address of EEPROM > register*/ > > + unsigned long timer; /*base address of 12-bit > timer*/ > > + unsigned long counters; /*base address of 32-bit > counters*/ > > + unsigned int mode1; /*riding-edge/high level > channels*/ > > + unsigned int mode2; /*falling-edge/low level > channels*/ > > + unsigned int ctrl; /*interrupt mode OR > (edge).AND(level)*/ > > struct task_struct *tsk_current; > > }; > > > > -- > > 1.9.1 > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to outreachy-kern...@googlegroups.com <javascript:>. > > To post to this group, send email to outreach...@googlegroups.com > <javascript:>. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20150330154011.GA11201%40ThinkPad. > > > For more options, visit https://groups.google.com/d/optout. > > > On Monday, March 30, 2015 at 11:43:14 PM UTC+8, Julia Lawall wrote: > > On Mon, 30 Mar 2015, Charlie Wong Super wrote: > > > This patch fixes the checkpatch.pl warning: > > WARNING: line over 80 characters > > FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114: > > + unsigned int ctrl; /* interrupt mode OR (edge) . > AND (level) */ > > You don't really need the above two lines. One can see the specific file > and the affected code lines just below. > > julia > > > > > Signed-off-by: Charlie Wong Super <1213c...@gmail.com <javascript:>> > > --- > > drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c > b/drivers/staging/comedi/drivers/addi_apci_1564.c > > index c481c48..dd335e8 100644 > > --- a/drivers/staging/comedi/drivers/addi_apci_1564.c > > +++ b/drivers/staging/comedi/drivers/addi_apci_1564.c > > @@ -106,12 +106,12 @@ > > #define APCI1564_COUNTER(x) ((x) * 0x20) > > > > struct apci1564_private { > > - unsigned long eeprom; /* base address of EEPROM > register */ > > - unsigned long timer; /* base address of 12-bit > timer */ > > - unsigned long counters; /* base address of > 32-bit counters */ > > - unsigned int mode1; /* riding-edge/high level > channels */ > > - unsigned int mode2; /* falling-edge/low level > channels */ > > - unsigned int ctrl; /* interrupt mode OR (edge) . > AND (level) */ > > + unsigned long eeprom; /*base address of EEPROM > register*/ > > + unsigned long timer; /*base address of 12-bit > timer*/ > > + unsigned long counters; /*base address of 32-bit > counters*/ > > + unsigned int mode1; /*riding-edge/high level > channels*/ > > + unsigned int mode2; /*falling-edge/low level > channels*/ > > + unsigned int ctrl; /*interrupt mode OR > (edge).AND(level)*/ > > struct task_struct *tsk_current; > > }; > > > > -- > > 1.9.1 > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to outreachy-kern...@googlegroups.com <javascript:>. > > To post to this group, send email to outreach...@googlegroups.com > <javascript:>. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20150330154011.GA11201%40ThinkPad. > > > For more options, visit https://groups.google.com/d/optout. > > > [-- Attachment #1.2: Type: text/html, Size: 11042 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: comedi: addi_apci_1564: Delete whitespace 2015-03-30 15:42 ` [Outreachy kernel] " Julia Lawall 2015-03-31 5:10 ` Charlie WONG Super @ 2015-03-31 5:20 ` Charlie WONG Super 1 sibling, 0 replies; 5+ messages in thread From: Charlie WONG Super @ 2015-03-31 5:20 UTC (permalink / raw) To: outreachy-kernel; +Cc: 1213charlie [-- Attachment #1.1: Type: text/plain, Size: 567 bytes --] On Monday, March 30, 2015 at 11:43:14 PM UTC+8, Julia Lawall wrote: > > On Mon, 30 Mar 2015, Charlie Wong Super wrote: > > > This patch fixes the checkpatch.pl warning: > > WARNING: line over 80 characters > > FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114: > > + unsigned int ctrl; /* interrupt mode OR (edge) . > AND (level) */ > > You don't really need the above two lines. One can see the specific file > and the affected code lines just below. > > julia > > > >I think I make a style mistake about the that replay! [-- Attachment #1.2: Type: text/html, Size: 975 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: comedi: addi_apci_1564: Delete whitespace 2015-03-30 15:40 [PATCH] Staging: comedi: addi_apci_1564: Delete whitespace Charlie Wong Super 2015-03-30 15:42 ` [Outreachy kernel] " Julia Lawall @ 2015-04-01 15:19 ` Greg KH 1 sibling, 0 replies; 5+ messages in thread From: Greg KH @ 2015-04-01 15:19 UTC (permalink / raw) To: Charlie Wong Super; +Cc: outreachy-kernel On Mon, Mar 30, 2015 at 11:40:11PM +0800, Charlie Wong Super wrote: > This patch fixes the checkpatch.pl warning: > WARNING: line over 80 characters > FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114: > + unsigned int ctrl; /* interrupt mode OR (edge) . AND (level) */ > > Signed-off-by: Charlie Wong Super <1213charlie@gmail.com> > --- > drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c b/drivers/staging/comedi/drivers/addi_apci_1564.c > index c481c48..dd335e8 100644 > --- a/drivers/staging/comedi/drivers/addi_apci_1564.c > +++ b/drivers/staging/comedi/drivers/addi_apci_1564.c > @@ -106,12 +106,12 @@ > #define APCI1564_COUNTER(x) ((x) * 0x20) > > struct apci1564_private { > - unsigned long eeprom; /* base address of EEPROM register */ > - unsigned long timer; /* base address of 12-bit timer */ > - unsigned long counters; /* base address of 32-bit counters */ > - unsigned int mode1; /* riding-edge/high level channels */ > - unsigned int mode2; /* falling-edge/low level channels */ > - unsigned int ctrl; /* interrupt mode OR (edge) . AND (level) */ > + unsigned long eeprom; /*base address of EEPROM register*/ > + unsigned long timer; /*base address of 12-bit timer*/ > + unsigned long counters; /*base address of 32-bit counters*/ > + unsigned int mode1; /*riding-edge/high level channels*/ > + unsigned int mode2; /*falling-edge/low level channels*/ > + unsigned int ctrl; /*interrupt mode OR (edge).AND(level)*/ That makes things look worse :( ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-01 15:19 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-03-30 15:40 [PATCH] Staging: comedi: addi_apci_1564: Delete whitespace Charlie Wong Super 2015-03-30 15:42 ` [Outreachy kernel] " Julia Lawall 2015-03-31 5:10 ` Charlie WONG Super 2015-03-31 5:20 ` Charlie WONG Super 2015-04-01 15:19 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.