All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Cedric Le Goater <clg@fr.ibm.com>
Cc: Stewart Smith <stewart@linux.vnet.ibm.com>,
	lm-sensors@lm-sensors.org,
	Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
	skiboot@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org,
	Jean Delvare <jdelvare@suse.de>
Subject: Re: [lm-sensors] [PATCH 4/4] hwmon: (ibmpowernv) pretty print labels
Date: Tue, 07 Apr 2015 19:22:12 +0000	[thread overview]
Message-ID: <20150407192212.GA6446@roeck-us.net> (raw)
In-Reply-To: <55241C02.60103@fr.ibm.com>

Hi Cedric,

On Tue, Apr 07, 2015 at 08:03:46PM +0200, Cedric Le Goater wrote:
> 
> on a P7  :
> 
> 	# ppc64_cpu --info
> 	Core   0:    0*    1*    2*    3* 
> 	Core   1:    4*    5*    6*    7* 
> 	Core   2:    8*    9*   10*   11* 
> 	Core   3:   12*   13*   14*   15* 
> 	Core   4:   16*   17*   18*   19* 
> 	Core   5:   20*   21*   22*   23* 
> 
How would the 'sensors' output look like on that system ?
Wouldn't it be something like the following ?

 	Core 0-7:    +29.0°C  
 	Core 4-11:   +29.0°C  

> 
> > Also, how do you know that the range of CPU IDs is always 8 ?
> 
> This is a shortcut. The code is for the ibmpowernv platform and assumes 
> that we are running on a P8 (8 hardware threads). It would be better to 
> use a "maximum threads per core" variable but I am not sure this is 
> available, as it is a tunable. I will look into it.
> 
Tunable how ? The core code must have some means to detect this number
when it initialized CPU entries, or am I missing something ?

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Cedric Le Goater <clg@fr.ibm.com>
Cc: Stewart Smith <stewart@linux.vnet.ibm.com>,
	lm-sensors@lm-sensors.org,
	Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
	skiboot@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org,
	Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH 4/4] hwmon: (ibmpowernv) pretty print labels
Date: Tue, 7 Apr 2015 12:22:12 -0700	[thread overview]
Message-ID: <20150407192212.GA6446@roeck-us.net> (raw)
In-Reply-To: <55241C02.60103@fr.ibm.com>

Hi Cedric,

On Tue, Apr 07, 2015 at 08:03:46PM +0200, Cedric Le Goater wrote:
> 
> on a P7  :
> 
> 	# ppc64_cpu --info
> 	Core   0:    0*    1*    2*    3* 
> 	Core   1:    4*    5*    6*    7* 
> 	Core   2:    8*    9*   10*   11* 
> 	Core   3:   12*   13*   14*   15* 
> 	Core   4:   16*   17*   18*   19* 
> 	Core   5:   20*   21*   22*   23* 
> 
How would the 'sensors' output look like on that system ?
Wouldn't it be something like the following ?

 	Core 0-7:    +29.0°C  
 	Core 4-11:   +29.0°C  

> 
> > Also, how do you know that the range of CPU IDs is always 8 ?
> 
> This is a shortcut. The code is for the ibmpowernv platform and assumes 
> that we are running on a P8 (8 hardware threads). It would be better to 
> use a "maximum threads per core" variable but I am not sure this is 
> available, as it is a tunable. I will look into it.
> 
Tunable how ? The core code must have some means to detect this number
when it initialized CPU entries, or am I missing something ?

Thanks,
Guenter

  reply	other threads:[~2015-04-07 19:22 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1423117857-32759-1-git-send-email-clg@fr.ibm.com>
2015-02-20 15:07 ` [lm-sensors] [RFC PATCH 0/3] hwmon: (ibmpowernv) add DTS support Cédric Le Goater
2015-02-20 15:07   ` Cédric Le Goater
2015-02-20 16:52   ` [lm-sensors] " Guenter Roeck
2015-02-20 16:52     ` Guenter Roeck
2015-02-20 20:15     ` [lm-sensors] " Cedric Le Goater
2015-02-20 20:15       ` Cedric Le Goater
2015-02-20 23:52       ` [lm-sensors] " Guenter Roeck
2015-02-20 23:52         ` Guenter Roeck
2015-02-21  7:14         ` [lm-sensors] " Cedric Le Goater
2015-02-21  7:14           ` Cedric Le Goater
2015-02-21 11:03           ` [lm-sensors] " Guenter Roeck
2015-02-21 11:03             ` Guenter Roeck
2015-02-23 10:54             ` [lm-sensors] " Cedric Le Goater
2015-02-23 10:54               ` Cedric Le Goater
2015-02-20 15:07 ` [lm-sensors] [RFC PATCH 1/3] powerpc/powernv: Check OPAL sensor calls exist Cédric Le Goater
2015-02-20 15:07   ` Cédric Le Goater
2015-02-20 16:53   ` [lm-sensors] " Guenter Roeck
2015-02-20 16:53     ` Guenter Roeck
2015-02-20 20:18     ` [lm-sensors] " Cedric Le Goater
2015-02-20 20:18       ` Cedric Le Goater
2015-02-24  4:54   ` [lm-sensors] " Michael Ellerman
2015-02-24  4:54     ` Michael Ellerman
2015-02-25 17:28     ` [lm-sensors] " Cedric Le Goater
2015-02-25 17:28       ` Cedric Le Goater
2015-02-20 15:07 ` [lm-sensors] [RFC PATCH 2/3] powerpc/powernv: handle OPAL_SUCCESS return in opal_sensor_read Cédric Le Goater
2015-02-20 15:07   ` Cédric Le Goater
2015-02-20 15:07 ` [lm-sensors] [RFC PATCH 3/3] hwmon: (ibmpowernv) add DTS support Cédric Le Goater
2015-02-20 15:07   ` Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] [PATCH 0/5] hwmon: (ibmpowernv) remove dependency on OPAL index Cédric Le Goater
2015-03-18 15:47   ` Cédric Le Goater
2015-03-19  4:05   ` [lm-sensors] " Guenter Roeck
2015-03-19  4:05     ` Guenter Roeck
2015-03-18 15:47 ` [lm-sensors] [PATCH 1/5] hwmon: (ibmpowernv) replace AMBIENT_TEMP by TEMP Cédric Le Goater
2015-03-18 15:47   ` Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] [PATCH 2/5] hwmon: (ibmpowernv) add a get_sensor_type() routine Cédric Le Goater
2015-03-18 15:47   ` Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] [PATCH 3/5] hwmon: (ibmpowernv) add a convert_opal_attr_name() routine Cédric Le Goater
2015-03-18 15:47   ` Cédric Le Goater
2015-03-19  3:58   ` [lm-sensors] " Guenter Roeck
2015-03-19  3:58     ` Guenter Roeck
2015-03-18 15:47 ` [lm-sensors] [PATCH 4/5] hwmon: (ibmpowernv) change create_hwmon_attr_name() prototype Cédric Le Goater
2015-03-18 15:47   ` Cédric Le Goater
2015-03-19  4:02   ` [lm-sensors] " Guenter Roeck
2015-03-19  4:02     ` Guenter Roeck
2015-03-18 15:47 ` [lm-sensors] [PATCH 5/5] hwmon: (ibmpowernv) do not use the OPAL index for hwmon attribute names Cédric Le Goater
2015-03-18 15:47   ` Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 0/5] hwmon: (ibmpowernv) remove dependency on OPAL index Cédric Le Goater
2015-03-19 17:44   ` Cédric Le Goater
2015-03-20 15:26   ` [lm-sensors] " Guenter Roeck
2015-03-20 15:26     ` Guenter Roeck
2015-03-20 16:52     ` [lm-sensors] " Cedric Le Goater
2015-03-20 16:52       ` Cedric Le Goater
2015-04-01 10:15   ` [lm-sensors] [PATCH 0/4] hwmon: (ibmpowernv) add DTS support Cédric Le Goater
2015-04-01 10:15     ` Cédric Le Goater
2015-04-01 10:15   ` [lm-sensors] [PATCH 1/4] hwmon: (ibmpowernv) add a helper routine create_hwmon_attr Cédric Le Goater
2015-04-01 10:15     ` Cédric Le Goater
2015-04-01 10:15   ` [lm-sensors] [PATCH 2/4] hwmon: (ibmpowernv) add support for the new device tree Cédric Le Goater
2015-04-01 10:15     ` Cédric Le Goater
2015-04-08 15:20     ` [lm-sensors] " Guenter Roeck
2015-04-08 15:20       ` Guenter Roeck
2015-04-08 16:06       ` [lm-sensors] " Cedric Le Goater
2015-04-08 16:06         ` Cedric Le Goater
2015-04-01 10:15   ` [lm-sensors] [PATCH 3/4] hwmon: (ibmpowernv) add a label attribute Cédric Le Goater
2015-04-01 10:15     ` Cédric Le Goater
2015-04-01 10:15   ` [lm-sensors] [PATCH 4/4] hwmon: (ibmpowernv) pretty print labels Cédric Le Goater
2015-04-01 10:15     ` Cédric Le Goater
2015-04-03 15:49     ` [lm-sensors] " Guenter Roeck
2015-04-03 15:49       ` Guenter Roeck
2015-04-07 14:42       ` [lm-sensors] " Cedric Le Goater
2015-04-07 14:42         ` Cedric Le Goater
2015-04-07 14:45         ` [lm-sensors] " Cédric Le Goater
2015-04-07 14:45           ` Cédric Le Goater
2015-04-07 16:44           ` [lm-sensors] " Guenter Roeck
2015-04-07 16:44             ` Guenter Roeck
2015-04-07 18:03             ` [lm-sensors] " Cedric Le Goater
2015-04-07 18:03               ` Cedric Le Goater
2015-04-07 19:22               ` Guenter Roeck [this message]
2015-04-07 19:22                 ` Guenter Roeck
2015-04-08  6:57                 ` [lm-sensors] " Cedric Le Goater
2015-04-08  6:57                   ` Cedric Le Goater
2015-04-07 20:22               ` [lm-sensors] [Skiboot] " Benjamin Herrenschmidt
2015-04-07 20:22                 ` Benjamin Herrenschmidt
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 1/5] hwmon: (ibmpowernv) replace AMBIENT_TEMP by TEMP Cédric Le Goater
2015-03-19 17:44   ` Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 2/5] hwmon: (ibmpowernv) add a get_sensor_type() routine Cédric Le Goater
2015-03-19 17:44   ` Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 3/5] hwmon: (ibmpowernv) add a convert_opal_attr_name() routine Cédric Le Goater
2015-03-19 17:44   ` Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 4/5] hwmon: (ibmpowernv) change create_hwmon_attr_name() prototype Cédric Le Goater
2015-03-19 17:44   ` Cédric Le Goater
2015-03-20  8:06   ` [lm-sensors] " Cedric Le Goater
2015-03-20  8:06     ` Cedric Le Goater
2015-03-20 15:27     ` [lm-sensors] " Guenter Roeck
2015-03-20 15:27       ` Guenter Roeck
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 5/5] hwmon: (ibmpowernv) do not use the OPAL index for hwmon attribute names Cédric Le Goater
2015-03-19 17:44   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150407192212.GA6446@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=clg@fr.ibm.com \
    --cc=jdelvare@suse.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=neelegup@linux.vnet.ibm.com \
    --cc=skiboot@lists.ozlabs.org \
    --cc=stewart@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.