From: Guenter Roeck <linux@roeck-us.net>
To: "Cédric Le Goater" <clg@fr.ibm.com>, lm-sensors@lm-sensors.org
Cc: Stewart Smith <stewart@linux.vnet.ibm.com>,
Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
skiboot@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org,
Jean Delvare <jdelvare@suse.de>
Subject: Re: [lm-sensors] [PATCH 0/5] hwmon: (ibmpowernv) remove dependency on OPAL index
Date: Thu, 19 Mar 2015 04:05:23 +0000 [thread overview]
Message-ID: <550A4B03.5070306@roeck-us.net> (raw)
In-Reply-To: <1426693665-10797-1-git-send-email-clg@fr.ibm.com>
T24gMDMvMTgvMjAxNSAwODo0NyBBTSwgQ8OpZHJpYyBMZSBHb2F0ZXIgd3JvdGU6Cj4gSGVsbG8g
IQo+Cj4gVGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gb2YgdGhlIGRyaXZlciB1c2VzIGFuIGlu
ZGV4IGZvciB0aGUgaHdtb24KPiBhdHRyaWJ1dGUgd2hpY2ggaXMgZXh0cmFjdGVkIGZyb20gdGhl
IGRldmljZSBub2RlIG5hbWUuIFRoaXMgaW5kZXgKPiBpcyBjYWxjdWxhdGVkIGJ5IHRoZSBPUEFM
IGZpcm13YXJlIGFuZCBpdHMgdXNhZ2UgY3JlYXRlcyBhIGRlcGVuZGVuY3kKPiB3aXRoIHRoZSBk
cml2ZXIgd2hpY2ggbWFrZXMgY2hhbmdlcyBhIGxpdHRsZSBtb3JlIGNvbXBsZXggaW4gT1BBTC4K
Pgo+IFRoaXMgcGF0Y2hzZXQgY2hhbmdlcyB0aGUgaWJtcG93ZXJudiBjb2RlIHRvIHVzZSBpdHMg
b3duIGluZGV4LiBJdAo+IHN0YXJ0cyB3aXRoIGEgZmV3IGNsZWFudXBzLCBtb3N0bHkgY29kZSBz
aHVmZmxpbmcgYXJvdW5kIHRoZSBjcmVhdGlvbgo+IG9mIHRoZSBod21vbiBzeXNmcyBhdHRyaWJ1
dGVzIGFuZCBjb21wbGV0ZXMgYnkgcmVtb3ZpbmcgdGhlIGRlcGVuZGVuY3kuCj4KPiBJdCBhbHNv
IHByZXBhcmVzIGdyb3VuZCBmb3IgZnV0dXJlIE9QQUwgY2hhbmdlcyA6Cj4KPiAgICAgaHR0cHM6
Ly9saXN0cy5vemxhYnMub3JnL3BpcGVybWFpbC9za2lib290LzIwMTUtTWFyY2gvMDAwNjM5Lmh0
bWwKPgo+IHdoaWNoIHdpbGwgYmUgYWRkcmVzc2VkIGluIGEgb3RoZXIgc21hbGwgcGF0Y2hzZXQu
Cj4KPgo+IFRoZSBwYXRjaGVzIGFyZSBiYXNlZCBvbiBMaW51eCA0LjAuMC1yYzQgYW5kIHdlcmUg
dGVzdGVkIG9uIElCTSBQb3dlcgo+IGFuZCBPcGVuIFBvd2VyIHN5c3RlbXMgcnVubmluZyBUcnVz
dHkuCj4KCkkgY29tbWVudGVkIG9uIHR3byBvZiB0aGUgcGF0Y2hlczsgdGhlIG90aGVycyBhcmUg
b2suCgpQbGVhc2UgcmUtc2VuZCB0aGUgZW50aXJlIHNlcmllcyBhZnRlciBhZGRyZXNzaW5nIG15
IGNvbW1lbnRzLgoKVGhhbmtzLApHdWVudGVyCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNA
bG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGlu
Zm8vbG0tc2Vuc29ycw=
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: "Cédric Le Goater" <clg@fr.ibm.com>, lm-sensors@lm-sensors.org
Cc: Stewart Smith <stewart@linux.vnet.ibm.com>,
Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
skiboot@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org,
Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH 0/5] hwmon: (ibmpowernv) remove dependency on OPAL index
Date: Wed, 18 Mar 2015 21:05:23 -0700 [thread overview]
Message-ID: <550A4B03.5070306@roeck-us.net> (raw)
In-Reply-To: <1426693665-10797-1-git-send-email-clg@fr.ibm.com>
On 03/18/2015 08:47 AM, Cédric Le Goater wrote:
> Hello !
>
> The current implementation of the driver uses an index for the hwmon
> attribute which is extracted from the device node name. This index
> is calculated by the OPAL firmware and its usage creates a dependency
> with the driver which makes changes a little more complex in OPAL.
>
> This patchset changes the ibmpowernv code to use its own index. It
> starts with a few cleanups, mostly code shuffling around the creation
> of the hwmon sysfs attributes and completes by removing the dependency.
>
> It also prepares ground for future OPAL changes :
>
> https://lists.ozlabs.org/pipermail/skiboot/2015-March/000639.html
>
> which will be addressed in a other small patchset.
>
>
> The patches are based on Linux 4.0.0-rc4 and were tested on IBM Power
> and Open Power systems running Trusty.
>
I commented on two of the patches; the others are ok.
Please re-send the entire series after addressing my comments.
Thanks,
Guenter
next prev parent reply other threads:[~2015-03-19 4:05 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1423117857-32759-1-git-send-email-clg@fr.ibm.com>
2015-02-20 15:07 ` [lm-sensors] [RFC PATCH 0/3] hwmon: (ibmpowernv) add DTS support Cédric Le Goater
2015-02-20 15:07 ` Cédric Le Goater
2015-02-20 16:52 ` [lm-sensors] " Guenter Roeck
2015-02-20 16:52 ` Guenter Roeck
2015-02-20 20:15 ` [lm-sensors] " Cedric Le Goater
2015-02-20 20:15 ` Cedric Le Goater
2015-02-20 23:52 ` [lm-sensors] " Guenter Roeck
2015-02-20 23:52 ` Guenter Roeck
2015-02-21 7:14 ` [lm-sensors] " Cedric Le Goater
2015-02-21 7:14 ` Cedric Le Goater
2015-02-21 11:03 ` [lm-sensors] " Guenter Roeck
2015-02-21 11:03 ` Guenter Roeck
2015-02-23 10:54 ` [lm-sensors] " Cedric Le Goater
2015-02-23 10:54 ` Cedric Le Goater
2015-02-20 15:07 ` [lm-sensors] [RFC PATCH 1/3] powerpc/powernv: Check OPAL sensor calls exist Cédric Le Goater
2015-02-20 15:07 ` Cédric Le Goater
2015-02-20 16:53 ` [lm-sensors] " Guenter Roeck
2015-02-20 16:53 ` Guenter Roeck
2015-02-20 20:18 ` [lm-sensors] " Cedric Le Goater
2015-02-20 20:18 ` Cedric Le Goater
2015-02-24 4:54 ` [lm-sensors] " Michael Ellerman
2015-02-24 4:54 ` Michael Ellerman
2015-02-25 17:28 ` [lm-sensors] " Cedric Le Goater
2015-02-25 17:28 ` Cedric Le Goater
2015-02-20 15:07 ` [lm-sensors] [RFC PATCH 2/3] powerpc/powernv: handle OPAL_SUCCESS return in opal_sensor_read Cédric Le Goater
2015-02-20 15:07 ` Cédric Le Goater
2015-02-20 15:07 ` [lm-sensors] [RFC PATCH 3/3] hwmon: (ibmpowernv) add DTS support Cédric Le Goater
2015-02-20 15:07 ` Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] [PATCH 0/5] hwmon: (ibmpowernv) remove dependency on OPAL index Cédric Le Goater
2015-03-18 15:47 ` Cédric Le Goater
2015-03-19 4:05 ` Guenter Roeck [this message]
2015-03-19 4:05 ` Guenter Roeck
2015-03-18 15:47 ` [lm-sensors] [PATCH 1/5] hwmon: (ibmpowernv) replace AMBIENT_TEMP by TEMP Cédric Le Goater
2015-03-18 15:47 ` Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] [PATCH 2/5] hwmon: (ibmpowernv) add a get_sensor_type() routine Cédric Le Goater
2015-03-18 15:47 ` Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] [PATCH 3/5] hwmon: (ibmpowernv) add a convert_opal_attr_name() routine Cédric Le Goater
2015-03-18 15:47 ` Cédric Le Goater
2015-03-19 3:58 ` [lm-sensors] " Guenter Roeck
2015-03-19 3:58 ` Guenter Roeck
2015-03-18 15:47 ` [lm-sensors] [PATCH 4/5] hwmon: (ibmpowernv) change create_hwmon_attr_name() prototype Cédric Le Goater
2015-03-18 15:47 ` Cédric Le Goater
2015-03-19 4:02 ` [lm-sensors] " Guenter Roeck
2015-03-19 4:02 ` Guenter Roeck
2015-03-18 15:47 ` [lm-sensors] [PATCH 5/5] hwmon: (ibmpowernv) do not use the OPAL index for hwmon attribute names Cédric Le Goater
2015-03-18 15:47 ` Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 0/5] hwmon: (ibmpowernv) remove dependency on OPAL index Cédric Le Goater
2015-03-19 17:44 ` Cédric Le Goater
2015-03-20 15:26 ` [lm-sensors] " Guenter Roeck
2015-03-20 15:26 ` Guenter Roeck
2015-03-20 16:52 ` [lm-sensors] " Cedric Le Goater
2015-03-20 16:52 ` Cedric Le Goater
2015-04-01 10:15 ` [lm-sensors] [PATCH 0/4] hwmon: (ibmpowernv) add DTS support Cédric Le Goater
2015-04-01 10:15 ` Cédric Le Goater
2015-04-01 10:15 ` [lm-sensors] [PATCH 1/4] hwmon: (ibmpowernv) add a helper routine create_hwmon_attr Cédric Le Goater
2015-04-01 10:15 ` Cédric Le Goater
2015-04-01 10:15 ` [lm-sensors] [PATCH 2/4] hwmon: (ibmpowernv) add support for the new device tree Cédric Le Goater
2015-04-01 10:15 ` Cédric Le Goater
2015-04-08 15:20 ` [lm-sensors] " Guenter Roeck
2015-04-08 15:20 ` Guenter Roeck
2015-04-08 16:06 ` [lm-sensors] " Cedric Le Goater
2015-04-08 16:06 ` Cedric Le Goater
2015-04-01 10:15 ` [lm-sensors] [PATCH 3/4] hwmon: (ibmpowernv) add a label attribute Cédric Le Goater
2015-04-01 10:15 ` Cédric Le Goater
2015-04-01 10:15 ` [lm-sensors] [PATCH 4/4] hwmon: (ibmpowernv) pretty print labels Cédric Le Goater
2015-04-01 10:15 ` Cédric Le Goater
2015-04-03 15:49 ` [lm-sensors] " Guenter Roeck
2015-04-03 15:49 ` Guenter Roeck
2015-04-07 14:42 ` [lm-sensors] " Cedric Le Goater
2015-04-07 14:42 ` Cedric Le Goater
2015-04-07 14:45 ` [lm-sensors] " Cédric Le Goater
2015-04-07 14:45 ` Cédric Le Goater
2015-04-07 16:44 ` [lm-sensors] " Guenter Roeck
2015-04-07 16:44 ` Guenter Roeck
2015-04-07 18:03 ` [lm-sensors] " Cedric Le Goater
2015-04-07 18:03 ` Cedric Le Goater
2015-04-07 19:22 ` [lm-sensors] " Guenter Roeck
2015-04-07 19:22 ` Guenter Roeck
2015-04-08 6:57 ` [lm-sensors] " Cedric Le Goater
2015-04-08 6:57 ` Cedric Le Goater
2015-04-07 20:22 ` [lm-sensors] [Skiboot] " Benjamin Herrenschmidt
2015-04-07 20:22 ` Benjamin Herrenschmidt
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 1/5] hwmon: (ibmpowernv) replace AMBIENT_TEMP by TEMP Cédric Le Goater
2015-03-19 17:44 ` Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 2/5] hwmon: (ibmpowernv) add a get_sensor_type() routine Cédric Le Goater
2015-03-19 17:44 ` Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 3/5] hwmon: (ibmpowernv) add a convert_opal_attr_name() routine Cédric Le Goater
2015-03-19 17:44 ` Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 4/5] hwmon: (ibmpowernv) change create_hwmon_attr_name() prototype Cédric Le Goater
2015-03-19 17:44 ` Cédric Le Goater
2015-03-20 8:06 ` [lm-sensors] " Cedric Le Goater
2015-03-20 8:06 ` Cedric Le Goater
2015-03-20 15:27 ` [lm-sensors] " Guenter Roeck
2015-03-20 15:27 ` Guenter Roeck
2015-03-19 17:44 ` [lm-sensors] [PATCH v2 5/5] hwmon: (ibmpowernv) do not use the OPAL index for hwmon attribute names Cédric Le Goater
2015-03-19 17:44 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550A4B03.5070306@roeck-us.net \
--to=linux@roeck-us.net \
--cc=clg@fr.ibm.com \
--cc=jdelvare@suse.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lm-sensors@lm-sensors.org \
--cc=neelegup@linux.vnet.ibm.com \
--cc=skiboot@lists.ozlabs.org \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.