From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 2/2][v2] blk-plug: don't flush nested plug lists
Date: Wed, 8 Apr 2015 18:13:55 +0200 [thread overview]
Message-ID: <20150408161355.GA16052@lst.de> (raw)
In-Reply-To: <x49wq1nrcoe.fsf_-_@segfault.boston.devel.redhat.com>
This looks good, but without the blk_finish_plug argument we're bound
to grow programming mistakes where people forget it. Any chance we
could have annotations similar to say rcu_read_lock/rcu_read_unlock
or the spinlocks so that sparse warns about it?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Ming Lei <tom.leiming@gmail.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Roger Pau Monn?? <roger.pau@citrix.com>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>, Neil Brown <neilb@suse.de>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.cz>, Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Changman Lee <cm224.lee@samsung.com>,
Steven Whitehouse <swhiteho@redhat.com>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>,
Trond Myklebust <trond.myklebust@primarydata.com>Anna Schumaker
<ann>
Subject: Re: [PATCH 2/2][v2] blk-plug: don't flush nested plug lists
Date: Wed, 8 Apr 2015 18:13:55 +0200 [thread overview]
Message-ID: <20150408161355.GA16052@lst.de> (raw)
In-Reply-To: <x49wq1nrcoe.fsf_-_@segfault.boston.devel.redhat.com>
This looks good, but without the blk_finish_plug argument we're bound
to grow programming mistakes where people forget it. Any chance we
could have annotations similar to say rcu_read_lock/rcu_read_unlock
or the spinlocks so that sparse warns about it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Ming Lei <tom.leiming@gmail.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Roger Pau Monn?? <roger.pau@citrix.com>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>, Neil Brown <neilb@suse.de>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.cz>, Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Changman Lee <cm224.lee@samsung.com>,
Steven Whitehouse <swhiteho@redhat.com>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <ann
Subject: Re: [PATCH 2/2][v2] blk-plug: don't flush nested plug lists
Date: Wed, 8 Apr 2015 18:13:55 +0200 [thread overview]
Message-ID: <20150408161355.GA16052@lst.de> (raw)
In-Reply-To: <x49wq1nrcoe.fsf_-_@segfault.boston.devel.redhat.com>
This looks good, but without the blk_finish_plug argument we're bound
to grow programming mistakes where people forget it. Any chance we
could have annotations similar to say rcu_read_lock/rcu_read_unlock
or the spinlocks so that sparse warns about it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Vladimir Davydov <vdavydov@parallels.com>,
linux-aio@kvack.org, Miklos Szeredi <mszeredi@suse.cz>,
Mike Snitzer <snitzer@redhat.com>, Neil Brown <neilb@suse.de>,
Ming Lei <tom.leiming@gmail.com>,
Ming Lei <ming.lei@canonical.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Jianyu Zhan <nasa4836@gmail.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
linux-kernel@vger.kernel.org, Sagi Grimberg <sagig@mellanox.com>,
Chris Mason <clm@fb.com>,
dm-devel@redhat.com, target-devel@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
Mark Rustad <mark.d.rustad@intel.com>,
Christoph Hellwig <hch@lst.de>, Alasdair Kergon <agk@redhat.com>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
linux-scsi@vger.kernel.org, Namjae Jeon <namjae.jeon@samsung.com>,
linux-raid@vger.kernel.org, cluster-devel@redhat.com,
Mel Gorman <mgorman@suse.de>,
Suleiman Souhlal <suleiman@google.com>,
linux-ext4@vger.kernel.org, linux-mm@kvack.org,
Changman Lee <cm224.lee@samsung.com>,
Rik van Riel <riel@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
xfs@oss.sgi.com, Fabian Frederick <fabf@skynet.be>,
Joe Perches <joe@perches.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
xen-devel@lists.xenproject.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Steven Whitehouse <swhiteho@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>, Jens Axboe <axboe@kernel.dk>,
Michal Hocko <mhocko@suse.cz>,
linux-nfs@vger.kernel.org, Fengguang Wu <fengguang.wu@intel.com>,
Theodore Ts'o <tytso@mit.edu>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Wang Sheng-Hui <shhuiw@gmail.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.cz>,
linux-f2fs-devel@lists.sourceforge.net,
linux-btrfs@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
Tejun Heo <tj@kernel.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Weston Andros Adamson <dros@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Roger Pau Monn?? <roger.pau@citrix.com>
Subject: Re: [PATCH 2/2][v2] blk-plug: don't flush nested plug lists
Date: Wed, 8 Apr 2015 18:13:55 +0200 [thread overview]
Message-ID: <20150408161355.GA16052@lst.de> (raw)
In-Reply-To: <x49wq1nrcoe.fsf_-_@segfault.boston.devel.redhat.com>
This looks good, but without the blk_finish_plug argument we're bound
to grow programming mistakes where people forget it. Any chance we
could have annotations similar to say rcu_read_lock/rcu_read_unlock
or the spinlocks so that sparse warns about it?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Ming Lei <tom.leiming@gmail.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Roger Pau Monn?? <roger.pau@citrix.com>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>, Neil Brown <neilb@suse.de>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.cz>, Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Changman Lee <cm224.lee@samsung.com>,
Steven Whitehouse <swhiteho@redhat.com>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, Christoph Hellwig <hch@lst.de>,
Weston Andros Adamson <dros@primarydata.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Sagi Grimberg <sagig@mellanox.com>, Tejun Heo <tj@kernel.org>,
Fabian Frederick <fabf@skynet.be>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Ming Lei <ming.lei@canonical.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Wang Sheng-Hui <shhuiw@gmail.com>, Michal Hocko <mhocko@suse.cz>,
Joe Perches <joe@perches.com>, Miklos Szeredi <mszeredi@suse.cz>,
Namjae Jeon <namjae.jeon@samsung.com>,
Mark Rustad <mark.d.rustad@intel.com>,
Jianyu Zhan <nasa4836@gmail.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Vladimir Davydov <vdavydov@parallels.com>,
Vlastimil Babka <vbabka@suse.cz>,
Suleiman Souhlal <suleiman@google.com>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com,
xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nfs@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2][v2] blk-plug: don't flush nested plug lists
Date: Wed, 8 Apr 2015 18:13:55 +0200 [thread overview]
Message-ID: <20150408161355.GA16052@lst.de> (raw)
In-Reply-To: <x49wq1nrcoe.fsf_-_@segfault.boston.devel.redhat.com>
This looks good, but without the blk_finish_plug argument we're bound
to grow programming mistakes where people forget it. Any chance we
could have annotations similar to say rcu_read_lock/rcu_read_unlock
or the spinlocks so that sparse warns about it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-04-08 16:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 19:14 [PATCH 1/2] [v2] blk-mq: fix plugging in blk_sq_make_request Jeff Moyer
2015-04-06 19:14 ` [PATCH 2/2] blk-plug: don't flush nested plug lists Jeff Moyer
2015-04-07 9:19 ` Ming Lei
2015-04-07 14:47 ` Jeff Moyer
2015-04-07 18:55 ` [Cluster-devel] [PATCH 2/2][v2] " Jeff Moyer
2015-04-07 18:55 ` Jeff Moyer
2015-04-07 18:55 ` Jeff Moyer
2015-04-07 18:55 ` Jeff Moyer
2015-04-07 18:55 ` Jeff Moyer
2015-04-08 16:13 ` Christoph Hellwig [this message]
2015-04-08 16:13 ` Christoph Hellwig
2015-04-08 16:13 ` Christoph Hellwig
2015-04-08 16:13 ` Christoph Hellwig
2015-04-08 16:13 ` Christoph Hellwig
2015-04-08 23:02 ` [Cluster-devel] " Dave Chinner
2015-04-08 23:02 ` Dave Chinner
2015-04-08 23:02 ` Dave Chinner
2015-04-08 23:02 ` Dave Chinner
2015-04-08 23:02 ` Dave Chinner
2015-04-09 0:54 ` Dave Chinner
2015-04-09 0:54 ` [Cluster-devel] " Dave Chinner
2015-04-09 0:54 ` Dave Chinner
2015-04-09 0:54 ` Dave Chinner
2015-04-10 21:50 ` [Cluster-devel] " Jeff Moyer
2015-04-10 21:50 ` Jeff Moyer
2015-04-10 21:50 ` Jeff Moyer
2015-04-10 21:50 ` Jeff Moyer
2015-04-10 21:50 ` Jeff Moyer
2015-04-11 4:11 ` [f2fs-dev] " nick
2015-04-11 4:11 ` nick
2015-04-11 4:11 ` nick
2015-04-11 4:11 ` nick
2015-04-08 17:38 ` [PATCH 2/2] " Jens Axboe
2015-04-07 16:09 ` Shaohua Li
2015-04-08 17:56 ` Jeff Moyer
2015-04-16 15:47 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408161355.GA16052@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.