All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH 5/6] usb: host: Add ehci-vf USB driver for ARM Vybrid SoC's
Date: Fri, 10 Apr 2015 01:26:27 +0200	[thread overview]
Message-ID: <201504100126.27930.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5CotXt_vr1V9r0m960MOKJ+whVU6yO2vNEai16HDGkvPQ@mail.gmail.com>

On Thursday, April 09, 2015 at 06:51:45 PM, Fabio Estevam wrote:
> Hi Marek,
> 
> On Wed, Apr 1, 2015 at 4:15 PM, Marek Vasut <marex@denx.de> wrote:
> >> +#define USB_NC_REG_OFFSET                            0x00000800
> >> +#define USBCx_CTRL_OFFSET                            0x00000000
> >> +#define USBCx_PHY_CTRL_OFFSET                        0x00000018
> > 
> > Please define the register offsets using the regular struct {} method,
> > see for example struct mxs_usbphy_regs and it's usage in ehci-mxs.c .
> 
> I thought we were trying to get rid of the 'no register access via
> offset' rule in U-boot.
> https://www.marc.info/?l=u-boot&m=142609602127309&w=2

Thanks! Did we reach some agreement on this ?

Best regards,
Marek Vasut

  reply	other threads:[~2015-04-09 23:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01  9:54 [U-Boot] [RESEND PATCH 0/6] Add support for Colibri Vybrid Modules Sanchayan Maity
2015-04-01  9:54 ` [U-Boot] [RESEND PATCH 1/6] ARM: vf610: Move DDR3 initialization to imx-common Sanchayan Maity
2015-04-01  9:54 ` [U-Boot] [RESEND PATCH 2/6] ARM: vf610: Enable external 32KHz oscillator Sanchayan Maity
2015-04-01  9:54 ` [U-Boot] [RESEND PATCH 3/6] ARM: vf610: Add SoC and CPU type detection Sanchayan Maity
2015-04-01  9:54 ` [U-Boot] [RESEND PATCH 4/6] ARM: vf610: Enable caches Sanchayan Maity
2015-04-01  9:54 ` [U-Boot] [RESEND PATCH 5/6] usb: host: Add ehci-vf USB driver for ARM Vybrid SoC's Sanchayan Maity
2015-04-01 19:15   ` Marek Vasut
2015-04-02 10:55     ` maitysanchayan at gmail.com
2015-04-02 16:47       ` Marek Vasut
2015-04-07  7:03     ` maitysanchayan at gmail.com
2015-04-09 16:09       ` Marek Vasut
2015-04-09 17:05         ` maitysanchayan at gmail.com
2015-04-09 23:27           ` Marek Vasut
2015-04-09 16:51     ` Fabio Estevam
2015-04-09 23:26       ` Marek Vasut [this message]
2015-04-01  9:54 ` [U-Boot] [RESEND PATCH 6/6] ARM: vf610: Initial integration for Colibri VF50/VF61 Sanchayan Maity
2015-04-01 10:44   ` Stefan Agner
2015-04-01 11:27 ` [U-Boot] [RESEND PATCH 0/6] Add support for Colibri Vybrid Modules Tom Rini
2015-04-02 10:58   ` maitysanchayan at gmail.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201504100126.27930.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.