All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Turquette <mturquette@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stephen Boyd <sboyd@codeaurora.org>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	stable@vger.kernel.org, Daniel Drake <drake@endlessm.com>,
	Kukjin Kim <kgene@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: samsung: exynos4: Disable ARMCLK down feature on Exynos4210 SoC
Date: Sun, 12 Apr 2015 21:02:12 -0700	[thread overview]
Message-ID: <20150413040212.19585.31796@quantum> (raw)
In-Reply-To: <CAJKOXPc_M=rY0aYpE_bhfa6Ku-E09UZ5YXXF3uH9ENTbPJsqMA@mail.gmail.com>

Quoting Krzysztof Kozlowski (2015-03-28 09:37:05)
> 2015-03-27 17:27 GMT+01:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> > Commit 42773b28e71d ("clk: samsung: exynos4: Enable ARMCLK
> > down feature") enabled ARMCLK down feature on all Exynos4
> > SoCs.  Unfortunately on Exynos4210 SoC ARMCLK down feature
> > causes a lockup when ondemand cpufreq governor is used.
> > Fix it by limiting ARMCLK down feature to Exynos4x12 SoCs.
> >
> > This patch was tested on:
> > - Exynos4210 SoC based Trats board
> > - Exynos4210 SoC based Origen board
> > - Exynos4412 SoC based Trats2 board
> > - Exynos4412 SoC based Odroid-U3 board
> >
> > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Cc: Daniel Drake <drake@endlessm.com>
> > Cc: Tomasz Figa <t.figa@samsung.com>
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Fixes: 42773b28e71d ("clk: samsung: exynos4: Enable ARMCLK down feature")
> > Cc: <stable@vger.kernel.org> # v3.17+
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > ---
> >  drivers/clk/samsung/clk-exynos4.c |   11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Applied.

Thanks,
Mike

> 
> Best regards,
> Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Michael Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: samsung: exynos4: Disable ARMCLK down feature on Exynos4210 SoC
Date: Sun, 12 Apr 2015 21:02:12 -0700	[thread overview]
Message-ID: <20150413040212.19585.31796@quantum> (raw)
In-Reply-To: <CAJKOXPc_M=rY0aYpE_bhfa6Ku-E09UZ5YXXF3uH9ENTbPJsqMA@mail.gmail.com>

Quoting Krzysztof Kozlowski (2015-03-28 09:37:05)
> 2015-03-27 17:27 GMT+01:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> > Commit 42773b28e71d ("clk: samsung: exynos4: Enable ARMCLK
> > down feature") enabled ARMCLK down feature on all Exynos4
> > SoCs.  Unfortunately on Exynos4210 SoC ARMCLK down feature
> > causes a lockup when ondemand cpufreq governor is used.
> > Fix it by limiting ARMCLK down feature to Exynos4x12 SoCs.
> >
> > This patch was tested on:
> > - Exynos4210 SoC based Trats board
> > - Exynos4210 SoC based Origen board
> > - Exynos4412 SoC based Trats2 board
> > - Exynos4412 SoC based Odroid-U3 board
> >
> > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Cc: Daniel Drake <drake@endlessm.com>
> > Cc: Tomasz Figa <t.figa@samsung.com>
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Fixes: 42773b28e71d ("clk: samsung: exynos4: Enable ARMCLK down feature")
> > Cc: <stable@vger.kernel.org> # v3.17+
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > ---
> >  drivers/clk/samsung/clk-exynos4.c |   11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Applied.

Thanks,
Mike

> 
> Best regards,
> Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Michael Turquette <mturquette@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>
Cc: "Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Stephen Boyd" <sboyd@codeaurora.org>,
	"Tomasz Figa" <tomasz.figa@gmail.com>,
	stable@vger.kernel.org, "Daniel Drake" <drake@endlessm.com>,
	"Kukjin Kim" <kgene@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: samsung: exynos4: Disable ARMCLK down feature on Exynos4210 SoC
Date: Sun, 12 Apr 2015 21:02:12 -0700	[thread overview]
Message-ID: <20150413040212.19585.31796@quantum> (raw)
In-Reply-To: <CAJKOXPc_M=rY0aYpE_bhfa6Ku-E09UZ5YXXF3uH9ENTbPJsqMA@mail.gmail.com>

Quoting Krzysztof Kozlowski (2015-03-28 09:37:05)
> 2015-03-27 17:27 GMT+01:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> > Commit 42773b28e71d ("clk: samsung: exynos4: Enable ARMCLK
> > down feature") enabled ARMCLK down feature on all Exynos4
> > SoCs.  Unfortunately on Exynos4210 SoC ARMCLK down feature
> > causes a lockup when ondemand cpufreq governor is used.
> > Fix it by limiting ARMCLK down feature to Exynos4x12 SoCs.
> >
> > This patch was tested on:
> > - Exynos4210 SoC based Trats board
> > - Exynos4210 SoC based Origen board
> > - Exynos4412 SoC based Trats2 board
> > - Exynos4412 SoC based Odroid-U3 board
> >
> > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Cc: Daniel Drake <drake@endlessm.com>
> > Cc: Tomasz Figa <t.figa@samsung.com>
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Fixes: 42773b28e71d ("clk: samsung: exynos4: Enable ARMCLK down feature")
> > Cc: <stable@vger.kernel.org> # v3.17+
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > ---
> >  drivers/clk/samsung/clk-exynos4.c |   11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Applied.

Thanks,
Mike

> 
> Best regards,
> Krzysztof

  reply	other threads:[~2015-04-13  4:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 16:27 [PATCH] clk: samsung: exynos4: Disable ARMCLK down feature on Exynos4210 SoC Bartlomiej Zolnierkiewicz
2015-03-27 16:27 ` Bartlomiej Zolnierkiewicz
2015-03-28 16:37 ` Krzysztof Kozlowski
2015-03-28 16:37   ` Krzysztof Kozlowski
2015-04-13  4:02   ` Michael Turquette [this message]
2015-04-13  4:02     ` Michael Turquette
2015-04-13  4:02     ` Michael Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413040212.19585.31796@quantum \
    --to=mturquette@linaro.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=drake@endlessm.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@codeaurora.org \
    --cc=stable@vger.kernel.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.