* [patch] drm/gma500: missing error codes in psb_driver_load()
@ 2015-04-17 12:24 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-04-17 12:24 UTC (permalink / raw)
To: David Airlie
Cc: Thierry Reding, Daniel Vetter, kernel-janitors, dri-devel,
Benoit Taine, Dave Airlie
We should return an error code here. In the current code they can only
fail if there is an allocation error so -ENOMEM is appropriate.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 92e7e57..4eff0d6 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -326,12 +326,16 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags)
goto out_err;
dev_priv->mmu = psb_mmu_driver_init(dev, 1, 0, 0);
- if (!dev_priv->mmu)
+ if (!dev_priv->mmu) {
+ ret = -ENOMEM;
goto out_err;
+ }
dev_priv->pf_pd = psb_mmu_alloc_pd(dev_priv->mmu, 1, 0);
- if (!dev_priv->pf_pd)
+ if (!dev_priv->pf_pd) {
+ ret = -ENOMEM;
goto out_err;
+ }
ret = psb_do_init(dev);
if (ret)
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] drm/gma500: missing error codes in psb_driver_load()
@ 2015-04-17 12:24 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-04-17 12:24 UTC (permalink / raw)
To: David Airlie
Cc: Thierry Reding, Daniel Vetter, kernel-janitors, dri-devel,
Benoit Taine, Dave Airlie
We should return an error code here. In the current code they can only
fail if there is an allocation error so -ENOMEM is appropriate.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 92e7e57..4eff0d6 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -326,12 +326,16 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags)
goto out_err;
dev_priv->mmu = psb_mmu_driver_init(dev, 1, 0, 0);
- if (!dev_priv->mmu)
+ if (!dev_priv->mmu) {
+ ret = -ENOMEM;
goto out_err;
+ }
dev_priv->pf_pd = psb_mmu_alloc_pd(dev_priv->mmu, 1, 0);
- if (!dev_priv->pf_pd)
+ if (!dev_priv->pf_pd) {
+ ret = -ENOMEM;
goto out_err;
+ }
ret = psb_do_init(dev);
if (ret)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] drm/gma500: missing error codes in psb_driver_load()
2015-04-17 12:24 ` Dan Carpenter
@ 2015-04-17 12:56 ` Patrik Jakobsson
-1 siblings, 0 replies; 4+ messages in thread
From: Patrik Jakobsson @ 2015-04-17 12:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: Daniel Vetter, kernel-janitors, dri-devel, Benoit Taine,
Dave Airlie, Thierry Reding
On Fri, Apr 17, 2015 at 2:24 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We should return an error code here. In the current code they can only
> fail if there is an allocation error so -ENOMEM is appropriate.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
> index 92e7e57..4eff0d6 100644
> --- a/drivers/gpu/drm/gma500/psb_drv.c
> +++ b/drivers/gpu/drm/gma500/psb_drv.c
> @@ -326,12 +326,16 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags)
> goto out_err;
>
> dev_priv->mmu = psb_mmu_driver_init(dev, 1, 0, 0);
> - if (!dev_priv->mmu)
> + if (!dev_priv->mmu) {
> + ret = -ENOMEM;
> goto out_err;
> + }
>
> dev_priv->pf_pd = psb_mmu_alloc_pd(dev_priv->mmu, 1, 0);
> - if (!dev_priv->pf_pd)
> + if (!dev_priv->pf_pd) {
> + ret = -ENOMEM;
> goto out_err;
> + }
>
> ret = psb_do_init(dev);
> if (ret)
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] drm/gma500: missing error codes in psb_driver_load()
@ 2015-04-17 12:56 ` Patrik Jakobsson
0 siblings, 0 replies; 4+ messages in thread
From: Patrik Jakobsson @ 2015-04-17 12:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: Daniel Vetter, kernel-janitors, dri-devel, Benoit Taine,
Dave Airlie, Thierry Reding
On Fri, Apr 17, 2015 at 2:24 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We should return an error code here. In the current code they can only
> fail if there is an allocation error so -ENOMEM is appropriate.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
> index 92e7e57..4eff0d6 100644
> --- a/drivers/gpu/drm/gma500/psb_drv.c
> +++ b/drivers/gpu/drm/gma500/psb_drv.c
> @@ -326,12 +326,16 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags)
> goto out_err;
>
> dev_priv->mmu = psb_mmu_driver_init(dev, 1, 0, 0);
> - if (!dev_priv->mmu)
> + if (!dev_priv->mmu) {
> + ret = -ENOMEM;
> goto out_err;
> + }
>
> dev_priv->pf_pd = psb_mmu_alloc_pd(dev_priv->mmu, 1, 0);
> - if (!dev_priv->pf_pd)
> + if (!dev_priv->pf_pd) {
> + ret = -ENOMEM;
> goto out_err;
> + }
>
> ret = psb_do_init(dev);
> if (ret)
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-17 12:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-17 12:24 [patch] drm/gma500: missing error codes in psb_driver_load() Dan Carpenter
2015-04-17 12:24 ` Dan Carpenter
2015-04-17 12:56 ` Patrik Jakobsson
2015-04-17 12:56 ` Patrik Jakobsson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.