From: Thierry Reding <treding@nvidia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>,
Alexandre Courbot <acourbot@nvidia.com>,
Ben Skeggs <bskeggs@redhat.com>, Vince Hsu <vinceh@nvidia.com>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/nouveau/platform: checking for IS_ERR() instead of NULL
Date: Tue, 21 Apr 2015 09:36:11 +0000 [thread overview]
Message-ID: <20150421093609.GG7379@ulmo.nvidia.com> (raw)
In-Reply-To: <20150421092507.GB12098@mwanda>
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
On Tue, Apr 21, 2015 at 12:25:07PM +0300, Dan Carpenter wrote:
> iommu_domain_alloc() returns NULL on error, it doesn't return error
> pointers.
>
> Fixes: 58fd9375c2c5 ('drm/nouveau/platform: probe IOMMU if present')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Indeed:
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <treding@nvidia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>,
Alexandre Courbot <acourbot@nvidia.com>,
Ben Skeggs <bskeggs@redhat.com>, Vince Hsu <vinceh@nvidia.com>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/nouveau/platform: checking for IS_ERR() instead of NULL
Date: Tue, 21 Apr 2015 11:36:11 +0200 [thread overview]
Message-ID: <20150421093609.GG7379@ulmo.nvidia.com> (raw)
In-Reply-To: <20150421092507.GB12098@mwanda>
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
On Tue, Apr 21, 2015 at 12:25:07PM +0300, Dan Carpenter wrote:
> iommu_domain_alloc() returns NULL on error, it doesn't return error
> pointers.
>
> Fixes: 58fd9375c2c5 ('drm/nouveau/platform: probe IOMMU if present')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Indeed:
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-21 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 9:25 [patch] drm/nouveau/platform: checking for IS_ERR() instead of NULL Dan Carpenter
2015-04-21 9:25 ` Dan Carpenter
2015-04-21 9:36 ` Thierry Reding [this message]
2015-04-21 9:36 ` Thierry Reding
2015-04-21 9:43 ` Alexandre Courbot
2015-04-21 9:43 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421093609.GG7379@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=vinceh@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.