All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Courbot <acourbot@nvidia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	David Airlie <airlied@linux.ie>
Cc: Ben Skeggs <bskeggs@redhat.com>, Vince Hsu <vinceh@nvidia.com>,
	Thierry Reding <treding@nvidia.com>,
	dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/nouveau/platform: checking for IS_ERR() instead of NULL
Date: Tue, 21 Apr 2015 09:43:08 +0000	[thread overview]
Message-ID: <55361BAC.3010503@nvidia.com> (raw)
In-Reply-To: <20150421092507.GB12098@mwanda>

On 04/21/2015 06:25 PM, Dan Carpenter wrote:
> iommu_domain_alloc() returns NULL on error, it doesn't return error
> pointers.

Oops, that's right.

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@nvidia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	David Airlie <airlied@linux.ie>
Cc: Ben Skeggs <bskeggs@redhat.com>, Vince Hsu <vinceh@nvidia.com>,
	Thierry Reding <treding@nvidia.com>,
	dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/nouveau/platform: checking for IS_ERR() instead of NULL
Date: Tue, 21 Apr 2015 18:43:08 +0900	[thread overview]
Message-ID: <55361BAC.3010503@nvidia.com> (raw)
In-Reply-To: <20150421092507.GB12098@mwanda>

On 04/21/2015 06:25 PM, Dan Carpenter wrote:
> iommu_domain_alloc() returns NULL on error, it doesn't return error
> pointers.

Oops, that's right.

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

  parent reply	other threads:[~2015-04-21  9:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21  9:25 [patch] drm/nouveau/platform: checking for IS_ERR() instead of NULL Dan Carpenter
2015-04-21  9:25 ` Dan Carpenter
2015-04-21  9:36 ` Thierry Reding
2015-04-21  9:36   ` Thierry Reding
2015-04-21  9:43 ` Alexandre Courbot [this message]
2015-04-21  9:43   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55361BAC.3010503@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=treding@nvidia.com \
    --cc=vinceh@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.