All of lore.kernel.org
 help / color / mirror / Atom feed
From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()
Date: Tue, 21 Apr 2015 14:57:16 -0600	[thread overview]
Message-ID: <20150421205716.GA474@obsidianresearch.com> (raw)
In-Reply-To: <1429648676-17755-3-git-send-email-mcgrof@do-not-panic.com>

On Tue, Apr 21, 2015 at 01:37:55PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> This driver already makes use of ioremap_wc() on PIO buffers,
> so convert it to use arch_phys_wc_add().

This is probably OK, but I think you should also remove the qib_wc_pat
module parameter.

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: cocci@systeme.lip6.fr
Subject: Re: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()
Date: Tue, 21 Apr 2015 20:57:16 +0000	[thread overview]
Message-ID: <20150421205716.GA474@obsidianresearch.com> (raw)
In-Reply-To: <1429648676-17755-3-git-send-email-mcgrof@do-not-panic.com>

On Tue, Apr 21, 2015 at 01:37:55PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> This driver already makes use of ioremap_wc() on PIO buffers,
> so convert it to use arch_phys_wc_add().

This is probably OK, but I think you should also remove the qib_wc_pat
module parameter.

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: "Luis R. Rodriguez" <mcgrof-3uybbJdB1yH774rrrx3eTA@public.gmane.org>
Cc: infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org,
	mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	cocci-/FJkirnvOdkvYVN+rsErww@public.gmane.org,
	"Luis R. Rodriguez" <mcgrof-IBi9RG/b67k@public.gmane.org>,
	Toshi Kani <toshi.kani-VXdhtT5mjnY@public.gmane.org>,
	Rickard Strandqvist
	<rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>,
	Mike Marciniszyn
	<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>,
	Dennis Dalessandro
	<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Suresh Siddha <sbsiddha-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Juergen Gross <jgross-IBi9RG/b67k@public.gmane.org>,
	Daniel Vetter <daniel.vetter-/w4YWyX8dFk@public.gmane.org>,
	Dave Airlie <airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Antonino Daplas <adaplas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Jean-Christophe Plagniol-Villard
	<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
	Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>,
	Dave Hansen <dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Arn
Subject: Re: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()
Date: Tue, 21 Apr 2015 14:57:16 -0600	[thread overview]
Message-ID: <20150421205716.GA474@obsidianresearch.com> (raw)
In-Reply-To: <1429648676-17755-3-git-send-email-mcgrof-3uybbJdB1yH774rrrx3eTA@public.gmane.org>

On Tue, Apr 21, 2015 at 01:37:55PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof-IBi9RG/b67k@public.gmane.org>
> 
> This driver already makes use of ioremap_wc() on PIO buffers,
> so convert it to use arch_phys_wc_add().

This is probably OK, but I think you should also remove the qib_wc_pat
module parameter.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: infinipath@intel.com, roland@kernel.org, sean.hefty@intel.com,
	hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org,
	luto@amacapital.net, mst@redhat.com, cocci@systeme.lip6.fr,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	"Toshi Kani" <toshi.kani@hp.com>,
	"Rickard Strandqvist" <rickard_strandqvist@spectrumdigital.se>,
	"Mike Marciniszyn" <mike.marciniszyn@intel.com>,
	"Roland Dreier" <roland@purestorage.com>,
	"Dennis Dalessandro" <dennis.dalessandro@intel.com>,
	"Suresh Siddha" <sbsiddha@gmail.com>,
	"Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Juergen Gross" <jgross@suse.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Dave Airlie" <airlied@redhat.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Antonino Daplas" <adaplas@gmail.com>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Stefan Bader" <stefan.bader@canonical.com>,
	konrad.wilk@oracle.com, ville.syrjala@linux.intel.com,
	david.vrabel@citrix.com, jbeulich@suse.com,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	xen-devel@lists.xensource.com
Subject: Re: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()
Date: Tue, 21 Apr 2015 14:57:16 -0600	[thread overview]
Message-ID: <20150421205716.GA474@obsidianresearch.com> (raw)
In-Reply-To: <1429648676-17755-3-git-send-email-mcgrof@do-not-panic.com>

On Tue, Apr 21, 2015 at 01:37:55PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> This driver already makes use of ioremap_wc() on PIO buffers,
> so convert it to use arch_phys_wc_add().

This is probably OK, but I think you should also remove the qib_wc_pat
module parameter.

Jason

  reply	other threads:[~2015-04-21 20:57 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 20:37 [Cocci] [PATCH v3 0/3] infiniband: few MTRR fixes and conversions Luis R. Rodriguez
2015-04-21 20:37 ` Luis R. Rodriguez
2015-04-21 20:37 ` [Cocci] [PATCH v3 1/3] IB/qib: add acounting for MTRR Luis R. Rodriguez
2015-04-21 20:37   ` Luis R. Rodriguez
2015-04-21 20:37   ` Luis R. Rodriguez
2015-04-21 20:37 ` [Cocci] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add() Luis R. Rodriguez
2015-04-21 20:37   ` Luis R. Rodriguez
2015-04-21 20:37   ` Luis R. Rodriguez
2015-04-21 20:37   ` Luis R. Rodriguez
2015-04-21 20:57   ` Jason Gunthorpe [this message]
2015-04-21 20:57     ` Jason Gunthorpe
2015-04-21 20:57     ` Jason Gunthorpe
2015-04-21 20:57     ` Jason Gunthorpe
2015-04-21 20:59     ` [Cocci] " Marciniszyn, Mike
2015-04-21 20:59       ` Marciniszyn, Mike
2015-04-21 20:59       ` Marciniszyn, Mike
2015-04-21 20:59       ` Marciniszyn, Mike
2015-04-21 21:09       ` [Cocci] " Luis R. Rodriguez
2015-04-21 21:09         ` Luis R. Rodriguez
2015-04-21 21:09         ` Luis R. Rodriguez
2015-04-21 21:09         ` Luis R. Rodriguez
2015-04-21 21:12         ` [Cocci] " Andy Lutomirski
2015-04-21 21:12           ` Andy Lutomirski
2015-04-21 21:12           ` Andy Lutomirski
2015-04-21 21:12           ` Andy Lutomirski
2015-04-21 21:14           ` [Cocci] " Luis R. Rodriguez
2015-04-21 21:14             ` Luis R. Rodriguez
2015-04-21 21:14             ` Luis R. Rodriguez
2015-04-21 21:14             ` Luis R. Rodriguez
2015-04-21 20:37 ` [Cocci] [PATCH v3 3/3] IB/ipath: add counting for MTRR Luis R. Rodriguez
2015-04-21 20:37   ` Luis R. Rodriguez
2015-04-21 20:37   ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150421205716.GA474@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.