All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Zhuang Jin Can <jin.can.zhuang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
	dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	pmladek-AlSwsSmVLrQ@public.gmane.org,
	peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] usb: core: add usb3 lpm sysfs
Date: Tue, 28 Apr 2015 12:42:24 +0200	[thread overview]
Message-ID: <20150428104224.GB540@kroah.com> (raw)
In-Reply-To: <20150419034612.GA31576-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote:
> Some usb3 devices may not support usb3 lpm well.
> The patch adds a sysfs to enable/disable u1 or u2 of the port.The
> settings apply to both before and after device enumeration.
> Supported values are "0" - u1 and u2 are disabled, "u1" - only u1 is
> enabled, "u2" - only u2 is enabled, "u1_u2" - u1 and u2 are enabled.
> 
> The interface is useful for testing some USB3 devices during
> development, and provides a way to disable usb3 lpm if the issues can
> not be fixed in final products.

How is a user supposed to "know" to make this setting for a device?  Why
can't the kernel automatically set this value properly?  Why does it
need to be a kernel issue at all?

And when you are doing development of broken devices, the kernel doesn't
have to support you, you can run with debugging patches of your own
until you fix your firmware :)

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Zhuang Jin Can <jin.can.zhuang@intel.com>
Cc: rafael.j.wysocki@intel.com, stern@rowland.harvard.edu,
	dan.j.williams@intel.com, pmladek@suse.cz,
	peter.chen@freescale.com, jwerner@chromium.org,
	linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: core: add usb3 lpm sysfs
Date: Tue, 28 Apr 2015 12:42:24 +0200	[thread overview]
Message-ID: <20150428104224.GB540@kroah.com> (raw)
In-Reply-To: <20150419034612.GA31576@intel.com>

On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote:
> Some usb3 devices may not support usb3 lpm well.
> The patch adds a sysfs to enable/disable u1 or u2 of the port.The
> settings apply to both before and after device enumeration.
> Supported values are "0" - u1 and u2 are disabled, "u1" - only u1 is
> enabled, "u2" - only u2 is enabled, "u1_u2" - u1 and u2 are enabled.
> 
> The interface is useful for testing some USB3 devices during
> development, and provides a way to disable usb3 lpm if the issues can
> not be fixed in final products.

How is a user supposed to "know" to make this setting for a device?  Why
can't the kernel automatically set this value properly?  Why does it
need to be a kernel issue at all?

And when you are doing development of broken devices, the kernel doesn't
have to support you, you can run with debugging patches of your own
until you fix your firmware :)

thanks,

greg k-h

  parent reply	other threads:[~2015-04-28 10:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-19  3:46 [PATCH] usb: core: add usb3 lpm sysfs Zhuang Jin Can
2015-04-22  9:21 ` Zhuang Jin Can
     [not found] ` <20150419034612.GA31576-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-28 10:42   ` Greg KH [this message]
2015-04-28 10:42     ` Greg KH
2015-04-28 16:51     ` Zhuang Jin Can
2015-04-28 21:11       ` Greg KH
     [not found]         ` <20150428211110.GA32383-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-04-29  7:20           ` Zhuang Jin Can
2015-04-29  7:20             ` Zhuang Jin Can
     [not found]             ` <20150429072004.GA20961-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29  9:01               ` Greg KH
2015-04-29  9:01                 ` Greg KH
     [not found]                 ` <20150429090148.GA22743-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-04-29 10:57                   ` Zhuang Jin Can
2015-04-29 10:57                     ` Zhuang Jin Can
     [not found]                     ` <20150429105730.GA12505-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29 11:06                       ` Greg KH
2015-04-29 11:06                         ` Greg KH
     [not found]                         ` <20150429110622.GA26820-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-04-29 16:21                           ` Zhuang Jin Can
2015-04-29 16:21                             ` Zhuang Jin Can
     [not found]                             ` <20150429162132.GA21141-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29 19:57                               ` Greg KH
2015-04-29 19:57                                 ` Greg KH
     [not found]                                 ` <20150429195733.GA19183-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-04-30  8:49                                   ` Zhuang Jin Can
2015-04-30  8:49                                     ` Zhuang Jin Can

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150428104224.GB540@kroah.com \
    --to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
    --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=jin.can.zhuang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=pmladek-AlSwsSmVLrQ@public.gmane.org \
    --cc=rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.