From: Theodore Ts'o <tytso@mit.edu>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, Michael Halcrow <mhalcrow@google.com>
Subject: Re: ext4 crypto: Do not select from EXT4_FS_ENCRYPTION
Date: Sat, 2 May 2015 09:40:29 -0400 [thread overview]
Message-ID: <20150502134029.GB10014@thunk.org> (raw)
In-Reply-To: <20150501001855.GA31516@gondor.apana.org.au>
On Fri, May 01, 2015 at 08:18:55AM +0800, Herbert Xu wrote:
> This patch adds a tristate EXT4_ENCRYPTION to do the selections
> for EXT4_FS_ENCRYPTION because selecting from a bool causes all
> the selected options to be built-in, even if EXT4 itself is a
> module.
Thanks for pointing out the problem!
This certainly fixes the problem, but it's a bit confusing; if you
answer "y" instead of "m" to the question, it will force the crypto
mechanisms to be built-in, and that's not necessarily obvious. That
being said, I suspect the people who will care the most about this
will be people building the distro kernels, and it will hopefully be
obvious to them.
In any case, I can't find a better way of doing this, so thanks,
applied. I'll get this pushed to Linus ASAP.
- Ted
next prev parent reply other threads:[~2015-05-02 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 0:18 ext4 crypto: Do not select from EXT4_FS_ENCRYPTION Herbert Xu
2015-05-02 13:40 ` Theodore Ts'o [this message]
2015-05-03 12:34 ` Anssi Hannula
2015-05-03 17:53 ` Theodore Ts'o
2015-05-03 18:29 ` Anssi Hannula
2015-05-03 21:11 ` Theodore Ts'o
2015-05-04 1:00 ` Herbert Xu
2015-05-04 1:37 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150502134029.GB10014@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=herbert@gondor.apana.org.au \
--cc=linux-ext4@vger.kernel.org \
--cc=mhalcrow@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.