Re: ext4 crypto: Do not select from EXT4_FS_ENCRYPTION

[Theodore Ts'o <tytso@mit.edu>]

On Sun, May 03, 2015 at 09:29:02PM +0300, Anssi Hannula wrote:
> > I believe the situation which is causing concern is when someone wants
> > to build a kernel where EXT4_FS=y, but they want the cryptographic
> > algorithms to be modules.  In that case, since EXT4_FS_ENCRYPTION is
> > 'y', it forces the all of the crypto modules to be built into the
> > kernel, and so it forecloses that option from someone who is building
> > or packaging a kernel.
> 
> Ah, OK, so not "EXT4 itself as a module" like the commit message said :)
> 
> For the situation you described I don't see a better solution either.

Thanks for pointing out problem in the commit message.  I guess I
wasn't reading all that carefully, but started experimenting, and came
up with some case where, if they aren't lack _bugs_, do constrain
flexibility a little.  You are correct that various crypto modules can
still be built as modules even if ext4 is a module and
EXT4_FS_ENCRYPTION is 'y'.  The main issue that I was able to find is
that if ext4 is _not_ a module, then it also forces the crypto modules
to also be built in.

(Personally from a performance perspective, I'd always want to make
the common crypto modules always built in to avoid pressure on the TLB
cache, but I understand that distributions seem to like to build
_everything_ as modules (which is one of the reasons why I generally
don't use distro kernels myself.  :-)

In any case, I'll correct the commit message so that it describes the
problem which it addresses more clearly.

							- Ted