* [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
@ 2015-05-05 3:18 Armin Kuster
2015-05-08 15:12 ` Joe MacDonald
2015-05-11 9:09 ` Martin Jansa
0 siblings, 2 replies; 13+ messages in thread
From: Armin Kuster @ 2015-05-05 3:18 UTC (permalink / raw)
To: openembedded-devel, joe_macdonald
WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build dependency? [build-deps]
Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
.../recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
index 8d37c98..36a4a7e 100644
--- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
+++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
@@ -37,11 +37,12 @@ PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES','systemd','systemd','conso
PACKAGECONFIG[systemd] = " \
--with-systemdsystemunitdir=${systemd_unitdir}/system --with-session-tracking=systemd --enable-polkit, \
--without-systemdsystemunitdir, \
- polkit \
+ polkit, polkit \
"
# consolekit is not picked by shlibs, so add it to RDEPENDS too
PACKAGECONFIG[consolekit] = "--with-session-tracking=consolekit,,consolekit,consolekit"
PACKAGECONFIG[concheck] = "--enable-concheck,--disable-concheck,libsoup-2.4"
+PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
# Work around dbus permission problems since we lack a proper at_console
do_install_prepend() {
--
2.3.5
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-05 3:18 [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit Armin Kuster
@ 2015-05-08 15:12 ` Joe MacDonald
2015-05-08 17:02 ` akuster808
2015-05-11 9:09 ` Martin Jansa
1 sibling, 1 reply; 13+ messages in thread
From: Joe MacDonald @ 2015-05-08 15:12 UTC (permalink / raw)
To: Armin Kuster; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2649 bytes --]
Hi Armin,
I don't know if you've noticed, but it looks like this caused an issue
with the current world build:
commit 00ea492451d221fcc4af5613732035184b8ee43a
Author: Armin Kuster <akuster808@gmail.com>
Date: Sat Apr 4 14:52:03 2015 -0700
networkmanger: meta-oe world build failes
ERROR: Nothing RPROVIDES 'dnsmasq' (but /home/akuster/oss/clean/meta-openembedded/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb RDEPENDS on or otherwise requires it)
NOTE: Runtime target 'dnsmasq' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['dnsmasq']
ERROR: Required build target 'networkmanager' has no buildable providers.
Missing or unbuildable dependency chain was: ['networkmanager', 'dnsmasq']
move networkmanager from meta-oe to meta-networking.
Signed-off-by: Armin Kuster <akuster808@gmail.com>
I'll see if I can reproduce it, it's not obvious to me on the surface
why this would be an issue with your patch.
-J.
[[meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit] On 15.05.04 (Mon 20:18) Armin Kuster wrote:
> WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build dependency? [build-deps]
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
> .../recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> index 8d37c98..36a4a7e 100644
> --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> @@ -37,11 +37,12 @@ PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES','systemd','systemd','conso
> PACKAGECONFIG[systemd] = " \
> --with-systemdsystemunitdir=${systemd_unitdir}/system --with-session-tracking=systemd --enable-polkit, \
> --without-systemdsystemunitdir, \
> - polkit \
> + polkit, polkit \
> "
> # consolekit is not picked by shlibs, so add it to RDEPENDS too
> PACKAGECONFIG[consolekit] = "--with-session-tracking=consolekit,,consolekit,consolekit"
> PACKAGECONFIG[concheck] = "--enable-concheck,--disable-concheck,libsoup-2.4"
> +PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
>
> # Work around dbus permission problems since we lack a proper at_console
> do_install_prepend() {
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-08 15:12 ` Joe MacDonald
@ 2015-05-08 17:02 ` akuster808
2015-05-08 17:18 ` Joe MacDonald
0 siblings, 1 reply; 13+ messages in thread
From: akuster808 @ 2015-05-08 17:02 UTC (permalink / raw)
To: Joe MacDonald; +Cc: openembedded-devel
Joe,
On 05/08/2015 08:12 AM, Joe MacDonald wrote:
> Hi Armin,
>
> I don't know if you've noticed, but it looks like this caused an issue
> with the current world build:
You mean the Galaxy build Martin does? no I have not.
>
> commit 00ea492451d221fcc4af5613732035184b8ee43a
> Author: Armin Kuster <akuster808@gmail.com>
> Date: Sat Apr 4 14:52:03 2015 -0700
>
> networkmanger: meta-oe world build failes
>
> ERROR: Nothing RPROVIDES 'dnsmasq' (but /home/akuster/oss/clean/meta-openembedded/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb RDEPENDS on or otherwise requires it)
> NOTE: Runtime target 'dnsmasq' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['dnsmasq']
> ERROR: Required build target 'networkmanager' has no buildable providers.
> Missing or unbuildable dependency chain was: ['networkmanager', 'dnsmasq']
>
> move networkmanager from meta-oe to meta-networking.
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>
> I'll see if I can reproduce it, it's not obvious to me on the surface
> why this would be an issue with your patch.
maybe it prefers to live in meta-oe ; )
thanks.
>
> -J.
>
> [[meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit] On 15.05.04 (Mon 20:18) Armin Kuster wrote:
>
>> WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build dependency? [build-deps]
>>
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>> ---
>> .../recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
>> index 8d37c98..36a4a7e 100644
>> --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
>> +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
>> @@ -37,11 +37,12 @@ PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES','systemd','systemd','conso
>> PACKAGECONFIG[systemd] = " \
>> --with-systemdsystemunitdir=${systemd_unitdir}/system --with-session-tracking=systemd --enable-polkit, \
>> --without-systemdsystemunitdir, \
>> - polkit \
>> + polkit, polkit \
>> "
>> # consolekit is not picked by shlibs, so add it to RDEPENDS too
>> PACKAGECONFIG[consolekit] = "--with-session-tracking=consolekit,,consolekit,consolekit"
>> PACKAGECONFIG[concheck] = "--enable-concheck,--disable-concheck,libsoup-2.4"
>> +PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
>>
>> # Work around dbus permission problems since we lack a proper at_console
>> do_install_prepend() {
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-08 17:02 ` akuster808
@ 2015-05-08 17:18 ` Joe MacDonald
0 siblings, 0 replies; 13+ messages in thread
From: Joe MacDonald @ 2015-05-08 17:18 UTC (permalink / raw)
To: akuster808; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 3316 bytes --]
[Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit] On 15.05.08 (Fri 10:02) akuster808 wrote:
> Joe,
>
>
> On 05/08/2015 08:12 AM, Joe MacDonald wrote:
> >Hi Armin,
> >
> >I don't know if you've noticed, but it looks like this caused an issue
> >with the current world build:
>
> You mean the Galaxy build Martin does? no I have not.
I noticed it because the commit log was updated when I was cherry
picking out of master-next, that's how I found it. :)
> >commit 00ea492451d221fcc4af5613732035184b8ee43a
> >Author: Armin Kuster <akuster808@gmail.com>
> >Date: Sat Apr 4 14:52:03 2015 -0700
> >
> > networkmanger: meta-oe world build failes
> >
> > ERROR: Nothing RPROVIDES 'dnsmasq' (but /home/akuster/oss/clean/meta-openembedded/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb RDEPENDS on or otherwise requires it)
> > NOTE: Runtime target 'dnsmasq' is unbuildable, removing...
> > Missing or unbuildable dependency chain was: ['dnsmasq']
> > ERROR: Required build target 'networkmanager' has no buildable providers.
> > Missing or unbuildable dependency chain was: ['networkmanager', 'dnsmasq']
> >
> > move networkmanager from meta-oe to meta-networking.
> >
> > Signed-off-by: Armin Kuster <akuster808@gmail.com>
> >
> >I'll see if I can reproduce it, it's not obvious to me on the surface
> >why this would be an issue with your patch.
>
> maybe it prefers to live in meta-oe ; )
Maybe it's freaked out being moved closer to dnsmasq or something.
We'll see.
-J.
> thanks.
> >
> >-J.
> >
> >[[meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit] On 15.05.04 (Mon 20:18) Armin Kuster wrote:
> >
> >>WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build dependency? [build-deps]
> >>
> >>Signed-off-by: Armin Kuster <akuster808@gmail.com>
> >>---
> >> .../recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >>diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> >>index 8d37c98..36a4a7e 100644
> >>--- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> >>+++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> >>@@ -37,11 +37,12 @@ PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES','systemd','systemd','conso
> >> PACKAGECONFIG[systemd] = " \
> >> --with-systemdsystemunitdir=${systemd_unitdir}/system --with-session-tracking=systemd --enable-polkit, \
> >> --without-systemdsystemunitdir, \
> >>- polkit \
> >>+ polkit, polkit \
> >> "
> >> # consolekit is not picked by shlibs, so add it to RDEPENDS too
> >> PACKAGECONFIG[consolekit] = "--with-session-tracking=consolekit,,consolekit,consolekit"
> >> PACKAGECONFIG[concheck] = "--enable-concheck,--disable-concheck,libsoup-2.4"
> >>+PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
> >>
> >> # Work around dbus permission problems since we lack a proper at_console
> >> do_install_prepend() {
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-05 3:18 [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit Armin Kuster
2015-05-08 15:12 ` Joe MacDonald
@ 2015-05-11 9:09 ` Martin Jansa
2015-05-11 18:44 ` Khem Raj
1 sibling, 1 reply; 13+ messages in thread
From: Martin Jansa @ 2015-05-11 9:09 UTC (permalink / raw)
To: openembedded-devel
On Mon, May 04, 2015 at 08:18:20PM -0700, Armin Kuster wrote:
> WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build dependency? [build-deps]
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
> .../recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> index 8d37c98..36a4a7e 100644
> --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> @@ -37,11 +37,12 @@ PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES','systemd','systemd','conso
> PACKAGECONFIG[systemd] = " \
> --with-systemdsystemunitdir=${systemd_unitdir}/system --with-session-tracking=systemd --enable-polkit, \
> --without-systemdsystemunitdir, \
> - polkit \
> + polkit, polkit \
> "
> # consolekit is not picked by shlibs, so add it to RDEPENDS too
> PACKAGECONFIG[consolekit] = "--with-session-tracking=consolekit,,consolekit,consolekit"
> PACKAGECONFIG[concheck] = "--enable-concheck,--disable-concheck,libsoup-2.4"
> +PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
Shouldn't it have polkit as build time dependency (3rd argument, not 4th)
Also the subject is wrong, it's networkmanager, not networkingmanager.
>
> # Work around dbus permission problems since we lack a proper at_console
> do_install_prepend() {
> --
> 2.3.5
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-11 9:09 ` Martin Jansa
@ 2015-05-11 18:44 ` Khem Raj
2015-05-11 19:00 ` Martin Jansa
0 siblings, 1 reply; 13+ messages in thread
From: Khem Raj @ 2015-05-11 18:44 UTC (permalink / raw)
To: openembeded-devel
On Mon, May 11, 2015 at 2:09 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> +PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
>
> Shouldn't it have polkit as build time dependency (3rd argument, not 4th)
if something is added to RDEPENDS it automatically gets added to DEPENDS too
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-11 18:44 ` Khem Raj
@ 2015-05-11 19:00 ` Martin Jansa
2015-05-11 19:43 ` Khem Raj
0 siblings, 1 reply; 13+ messages in thread
From: Martin Jansa @ 2015-05-11 19:00 UTC (permalink / raw)
To: openembedded-devel
On Mon, May 11, 2015 at 11:44:11AM -0700, Khem Raj wrote:
> On Mon, May 11, 2015 at 2:09 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> +PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
> >
> > Shouldn't it have polkit as build time dependency (3rd argument, not 4th)
>
> if something is added to RDEPENDS it automatically gets added to DEPENDS too
No that's not true.
RDEPENDS adds dependency only between do_package tasks for build time
dependency you need do_configure depending on do_populate_sysroot
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-11 19:00 ` Martin Jansa
@ 2015-05-11 19:43 ` Khem Raj
2015-05-11 19:46 ` Khem Raj
2015-05-11 19:52 ` Martin Jansa
0 siblings, 2 replies; 13+ messages in thread
From: Khem Raj @ 2015-05-11 19:43 UTC (permalink / raw)
To: openembeded-devel
On Mon, May 11, 2015 at 12:00 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>
> RDEPENDS adds dependency only between do_package tasks for build time
> dependency you need do_configure depending on do_populate_sysroot
its do_build which will depend on do_package_write task in case of RDEPENDS
and do_package_write task will then recurse further to build it.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-11 19:43 ` Khem Raj
@ 2015-05-11 19:46 ` Khem Raj
2015-05-11 19:56 ` Martin Jansa
2015-05-11 19:58 ` akuster808
2015-05-11 19:52 ` Martin Jansa
1 sibling, 2 replies; 13+ messages in thread
From: Khem Raj @ 2015-05-11 19:46 UTC (permalink / raw)
To: openembeded-devel
On Mon, May 11, 2015 at 12:43 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Mon, May 11, 2015 at 12:00 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>>
>> RDEPENDS adds dependency only between do_package tasks for build time
>> dependency you need do_configure depending on do_populate_sysroot
>
> its do_build which will depend on do_package_write task in case of RDEPENDS
> and do_package_write task will then recurse further to build it.
backtracking on warning
WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a
build dependency? [build-deps]
its confusing to me. It says 'rdepends' but then expects it in
build-dependency and not build-rdep or somesuch
but lets say it depends on buildtime then I agree adding it to third
place is needed and may be adding to 4th place too
if shlib is not detecting it.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-11 19:46 ` Khem Raj
@ 2015-05-11 19:56 ` Martin Jansa
2015-05-11 19:58 ` akuster808
1 sibling, 0 replies; 13+ messages in thread
From: Martin Jansa @ 2015-05-11 19:56 UTC (permalink / raw)
To: openembedded-devel
On Mon, May 11, 2015 at 12:46:13PM -0700, Khem Raj wrote:
> On Mon, May 11, 2015 at 12:43 PM, Khem Raj <raj.khem@gmail.com> wrote:
> > On Mon, May 11, 2015 at 12:00 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >>
> >> RDEPENDS adds dependency only between do_package tasks for build time
> >> dependency you need do_configure depending on do_populate_sysroot
> >
> > its do_build which will depend on do_package_write task in case of RDEPENDS
> > and do_package_write task will then recurse further to build it.
>
> backtracking on warning
>
> WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a
> build dependency? [build-deps]
>
> its confusing to me. It says 'rdepends' but then expects it in
> build-dependency and not build-rdep or somesuch
It says "rdepends" because that dependency was added by shlib providers
code to RDEPENDS. But that means that some binary is linked against
library provided by polkit -> it's build time dependency autodetected in
do_configure -> needs polkit in DEPENDS.
> but lets say it depends on buildtime then I agree adding it to third
> place is needed and may be adding to 4th place too
> if shlib is not detecting it.
It needs it only in 3rd, because shlib code works correctly, otherwise you
wouldn't see this QA warning.
In other words the QA check warns about runtime dependencies being added
by shlibs code without having their providers in build time dependencies.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-11 19:46 ` Khem Raj
2015-05-11 19:56 ` Martin Jansa
@ 2015-05-11 19:58 ` akuster808
1 sibling, 0 replies; 13+ messages in thread
From: akuster808 @ 2015-05-11 19:58 UTC (permalink / raw)
To: openembedded-devel
On 05/11/2015 12:46 PM, Khem Raj wrote:
> On Mon, May 11, 2015 at 12:43 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Mon, May 11, 2015 at 12:00 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>>>
>>> RDEPENDS adds dependency only between do_package tasks for build time
>>> dependency you need do_configure depending on do_populate_sysroot
>>
>> its do_build which will depend on do_package_write task in case of RDEPENDS
>> and do_package_write task will then recurse further to build it.
>
> backtracking on warning
>
> WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a
> build dependency? [build-deps]
for me the warning went away with the current change but I guess I
didn't poke it enough.
>
> its confusing to me. It says 'rdepends' but then expects it in
> build-dependency and not build-rdep or somesuch
>
> but lets say it depends on buildtime then I agree adding it to third
> place is needed and may be adding to 4th place too
> if shlib is not detecting it.
>
I will change it to both places.
thanks for the feedback.
- armin
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-11 19:43 ` Khem Raj
2015-05-11 19:46 ` Khem Raj
@ 2015-05-11 19:52 ` Martin Jansa
2015-05-12 8:53 ` Paul Eggleton
1 sibling, 1 reply; 13+ messages in thread
From: Martin Jansa @ 2015-05-11 19:52 UTC (permalink / raw)
To: openembedded-devel
On Mon, May 11, 2015 at 12:43:41PM -0700, Khem Raj wrote:
> On Mon, May 11, 2015 at 12:00 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >
> > RDEPENDS adds dependency only between do_package tasks for build time
> > dependency you need do_configure depending on do_populate_sysroot
>
> its do_build which will depend on do_package_write task in case of RDEPENDS
> and do_package_write task will then recurse further to build it.
<section id='build-dependencies'>
<title>Build Dependencies</title>
<para>
BitBake uses the
<link linkend='var-DEPENDS'><filename>DEPENDS</filename></link>
variable to manage build time dependencies.
The "deptask" varflag for tasks signifies the task of each
item listed in <filename>DEPENDS</filename> that must
complete before that task can be executed.
Here is an example:
<literallayout class='monospaced'>
do_configure[deptask] = "do_populate_sysroot"
</literallayout>
In this example, the <filename>do_populate_sysroot</filename>
task of each item in <filename>DEPENDS</filename> must complete before
<filename>do_configure</filename> can execute.
</para>
</section>
<section id='runtime-dependencies'>
<title>Runtime Dependencies</title>
<para>
BitBake uses the
<link linkend='var-PACKAGES'><filename>PACKAGES</filename></link>,
<link linkend='var-RDEPENDS'><filename>RDEPENDS</filename></link>, and
<link linkend='var-RRECOMMENDS'><filename>RRECOMMENDS</filename></link>
variables to manage runtime dependencies.
</para>
<para>
The <filename>PACKAGES</filename> variable lists runtime
packages.
Each of those packages can have <filename>RDEPENDS</filename> and
<filename>RRECOMMENDS</filename> runtime dependencies.
The "rdeptask" flag for tasks is used to signify the task of each
item runtime dependency which must have completed before that
task can be executed.
<literallayout class='monospaced'>
do_package_qa[rdeptask] = "do_packagedata"
</literallayout>
In the previous example, the <filename>do_packagedata</filename>
task of each item in <filename>RDEPENDS</filename> must have
completed before <filename>do_package_qa</filename> can execute.
</para>
</section>
so again, RDEPENDS isn't good enough for build time dependencies
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
2015-05-11 19:52 ` Martin Jansa
@ 2015-05-12 8:53 ` Paul Eggleton
0 siblings, 0 replies; 13+ messages in thread
From: Paul Eggleton @ 2015-05-12 8:53 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-devel
On Monday 11 May 2015 21:52:00 Martin Jansa wrote:
> On Mon, May 11, 2015 at 12:43:41PM -0700, Khem Raj wrote:
> > On Mon, May 11, 2015 at 12:00 PM, Martin Jansa <martin.jansa@gmail.com>
wrote:
> > > RDEPENDS adds dependency only between do_package tasks for build time
> > > dependency you need do_configure depending on do_populate_sysroot
> >
> > its do_build which will depend on do_package_write task in case of
> > RDEPENDS
> > and do_package_write task will then recurse further to build it.
>
> <section id='build-dependencies'>
> <title>Build Dependencies</title>
>
> <para>
> BitBake uses the
> <link
> linkend='var-DEPENDS'><filename>DEPENDS</filename></link> variable to
> manage build time dependencies.
> The "deptask" varflag for tasks signifies the task of each
> item listed in <filename>DEPENDS</filename> that must
> complete before that task can be executed.
> Here is an example:
> <literallayout class='monospaced'>
> do_configure[deptask] = "do_populate_sysroot"
> </literallayout>
> In this example, the
> <filename>do_populate_sysroot</filename> task of each item in
> <filename>DEPENDS</filename> must complete before
> <filename>do_configure</filename> can execute.
> </para>
> </section>
>
>
> <section id='runtime-dependencies'>
> <title>Runtime Dependencies</title>
>
> <para>
> BitBake uses the
> <link
> linkend='var-PACKAGES'><filename>PACKAGES</filename></link>, <link
> linkend='var-RDEPENDS'><filename>RDEPENDS</filename></link>, and <link
> linkend='var-RRECOMMENDS'><filename>RRECOMMENDS</filename></link> variables
> to manage runtime dependencies.
> </para>
>
> <para>
> The <filename>PACKAGES</filename> variable lists runtime
> packages.
> Each of those packages can have
> <filename>RDEPENDS</filename> and <filename>RRECOMMENDS</filename> runtime
> dependencies. The "rdeptask" flag for tasks is used to signify the task of
> each item runtime dependency which must have completed before that task can
> be executed.
> <literallayout class='monospaced'>
> do_package_qa[rdeptask] = "do_packagedata"
> </literallayout>
> In the previous example, the
> <filename>do_packagedata</filename> task of each item in
> <filename>RDEPENDS</filename> must have completed before
> <filename>do_package_qa</filename> can execute. </para>
> </section>
>
>
> so again, RDEPENDS isn't good enough for build time dependencies
This is correct. Even an explicit RDEPENDS within the recipe does not add any
dependency from do_configure on do_populate_sysroot, so if there is a build
time dependency you definitely need DEPENDS as well.
I do agree though that the warning message needs improvement in order to be as
clear as possible.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2015-05-12 8:53 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-05 3:18 [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit Armin Kuster
2015-05-08 15:12 ` Joe MacDonald
2015-05-08 17:02 ` akuster808
2015-05-08 17:18 ` Joe MacDonald
2015-05-11 9:09 ` Martin Jansa
2015-05-11 18:44 ` Khem Raj
2015-05-11 19:00 ` Martin Jansa
2015-05-11 19:43 ` Khem Raj
2015-05-11 19:46 ` Khem Raj
2015-05-11 19:56 ` Martin Jansa
2015-05-11 19:58 ` akuster808
2015-05-11 19:52 ` Martin Jansa
2015-05-12 8:53 ` Paul Eggleton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.