All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Suman Tripathi <stripathi@apm.com>
Cc: olof@lixom.net, arnd@arndb.de, linux-scsi@vger.kernel.org,
	linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, mlangsdo@redhat.com,
	jcm@redhat.com, patches@apm.com
Subject: Re: [PATCH v6 1/1] ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller.
Date: Mon, 11 May 2015 07:28:00 -0400	[thread overview]
Message-ID: <20150511112800.GA11388@htj.duckdns.org> (raw)
In-Reply-To: <1431333375-30433-2-git-send-email-stripathi@apm.com>

Hello, Suman.

On Mon, May 11, 2015 at 02:06:15PM +0530, Suman Tripathi wrote:
> -#ifdef CONFIG_ACPI
> -static const struct acpi_device_id xgene_ahci_acpi_match[] = {
> -	{ "APMC0D0D", },
> -	{ }
> -};
> -MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match);
> -#endif
> -
> -static const struct of_device_id xgene_ahci_of_match[] = {
> -	{.compatible = "apm,xgene-ahci"},
> -	{},
> -};
> -MODULE_DEVICE_TABLE(of, xgene_ahci_of_match);

I applied the patch as-is this time but please don't combine code
movement with actual changes in the future.  Split them out to
separate patches.  It makes the changes a lot easier to follow and
verify.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/1] ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller.
Date: Mon, 11 May 2015 07:28:00 -0400	[thread overview]
Message-ID: <20150511112800.GA11388@htj.duckdns.org> (raw)
In-Reply-To: <1431333375-30433-2-git-send-email-stripathi@apm.com>

Hello, Suman.

On Mon, May 11, 2015 at 02:06:15PM +0530, Suman Tripathi wrote:
> -#ifdef CONFIG_ACPI
> -static const struct acpi_device_id xgene_ahci_acpi_match[] = {
> -	{ "APMC0D0D", },
> -	{ }
> -};
> -MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match);
> -#endif
> -
> -static const struct of_device_id xgene_ahci_of_match[] = {
> -	{.compatible = "apm,xgene-ahci"},
> -	{},
> -};
> -MODULE_DEVICE_TABLE(of, xgene_ahci_of_match);

I applied the patch as-is this time but please don't combine code
movement with actual changes in the future.  Split them out to
separate patches.  It makes the changes a lot easier to follow and
verify.

Thanks.

-- 
tejun

  reply	other threads:[~2015-05-11 11:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11  8:36 [PATCH v6 0/1] ata: ahci_xgene: Add support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller driver Suman Tripathi
2015-05-11  8:36 ` [PATCH v6 1/1] ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller Suman Tripathi
2015-05-11 11:28   ` Tejun Heo [this message]
2015-05-11 11:28     ` Tejun Heo
2015-05-11 13:31     ` Suman Tripathi
2015-05-11 13:31       ` Suman Tripathi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511112800.GA11388@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jcm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mlangsdo@redhat.com \
    --cc=olof@lixom.net \
    --cc=patches@apm.com \
    --cc=stripathi@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.