* [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format @ 2015-02-13 5:25 ` Liu Ying 0 siblings, 0 replies; 10+ messages in thread From: Liu Ying @ 2015-02-13 5:25 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Liu Ying <Ying.Liu@freescale.com> --- v9->v9.5: * Add kernel-doc for the new helper function to address Daniel Vetter's comment. v8->v9: * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. v7->v8: * None. v6->v7: * None. v5->v6: * Address the over 80 characters in one line warning reported by the checkpatch.pl script. v4->v5: * None. v3->v4: * None. v2->v3: * None. v1->v2: * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function could be placed at the common DRM MIPI DSI driver. This patch is newly added. include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index f1d8d0d..cabc910 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) return container_of(dev, struct mipi_dsi_device, dev); } +/** + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi + * pixel format + * @fmt: mipi dsi pixel format + * + * Return: The bits per pixel value for the mipi dsi pixel format on success or + * a negative error code on failure. + */ +static inline int mipi_dsi_pixel_format_to_bpp(enum mipi_dsi_pixel_format fmt) +{ + switch (fmt) { + case MIPI_DSI_FMT_RGB888: + case MIPI_DSI_FMT_RGB666: + return 24; + case MIPI_DSI_FMT_RGB666_PACKED: + return 18; + case MIPI_DSI_FMT_RGB565: + return 16; + } + return -EINVAL; +} + struct mipi_dsi_device *of_find_mipi_dsi_device_by_node(struct device_node *np); int mipi_dsi_attach(struct mipi_dsi_device *dsi); int mipi_dsi_detach(struct mipi_dsi_device *dsi); -- 2.1.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format @ 2015-02-13 5:25 ` Liu Ying 0 siblings, 0 replies; 10+ messages in thread From: Liu Ying @ 2015-02-13 5:25 UTC (permalink / raw) To: dri-devel Cc: devicetree, linux-arm-kernel, linux, kernel, p.zabel, thierry.reding, shawn.guo, mturquette, airlied, andyshrk, stefan.wahren, a.hajda, sboyd, daniel.vetter, linux-kernel Signed-off-by: Liu Ying <Ying.Liu@freescale.com> --- v9->v9.5: * Add kernel-doc for the new helper function to address Daniel Vetter's comment. v8->v9: * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. v7->v8: * None. v6->v7: * None. v5->v6: * Address the over 80 characters in one line warning reported by the checkpatch.pl script. v4->v5: * None. v3->v4: * None. v2->v3: * None. v1->v2: * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function could be placed at the common DRM MIPI DSI driver. This patch is newly added. include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index f1d8d0d..cabc910 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) return container_of(dev, struct mipi_dsi_device, dev); } +/** + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi + * pixel format + * @fmt: mipi dsi pixel format + * + * Return: The bits per pixel value for the mipi dsi pixel format on success or + * a negative error code on failure. + */ +static inline int mipi_dsi_pixel_format_to_bpp(enum mipi_dsi_pixel_format fmt) +{ + switch (fmt) { + case MIPI_DSI_FMT_RGB888: + case MIPI_DSI_FMT_RGB666: + return 24; + case MIPI_DSI_FMT_RGB666_PACKED: + return 18; + case MIPI_DSI_FMT_RGB565: + return 16; + } + return -EINVAL; +} + struct mipi_dsi_device *of_find_mipi_dsi_device_by_node(struct device_node *np); int mipi_dsi_attach(struct mipi_dsi_device *dsi); int mipi_dsi_detach(struct mipi_dsi_device *dsi); -- 2.1.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format @ 2015-02-13 5:25 ` Liu Ying 0 siblings, 0 replies; 10+ messages in thread From: Liu Ying @ 2015-02-13 5:25 UTC (permalink / raw) To: dri-devel Cc: stefan.wahren, devicetree, linux, kernel, daniel.vetter, sboyd, linux-kernel, a.hajda, mturquette, linux-arm-kernel, andyshrk Signed-off-by: Liu Ying <Ying.Liu@freescale.com> --- v9->v9.5: * Add kernel-doc for the new helper function to address Daniel Vetter's comment. v8->v9: * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. v7->v8: * None. v6->v7: * None. v5->v6: * Address the over 80 characters in one line warning reported by the checkpatch.pl script. v4->v5: * None. v3->v4: * None. v2->v3: * None. v1->v2: * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function could be placed at the common DRM MIPI DSI driver. This patch is newly added. include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index f1d8d0d..cabc910 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) return container_of(dev, struct mipi_dsi_device, dev); } +/** + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi + * pixel format + * @fmt: mipi dsi pixel format + * + * Return: The bits per pixel value for the mipi dsi pixel format on success or + * a negative error code on failure. + */ +static inline int mipi_dsi_pixel_format_to_bpp(enum mipi_dsi_pixel_format fmt) +{ + switch (fmt) { + case MIPI_DSI_FMT_RGB888: + case MIPI_DSI_FMT_RGB666: + return 24; + case MIPI_DSI_FMT_RGB666_PACKED: + return 18; + case MIPI_DSI_FMT_RGB565: + return 16; + } + return -EINVAL; +} + struct mipi_dsi_device *of_find_mipi_dsi_device_by_node(struct device_node *np); int mipi_dsi_attach(struct mipi_dsi_device *dsi); int mipi_dsi_detach(struct mipi_dsi_device *dsi); -- 2.1.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format 2015-02-13 5:25 ` Liu Ying (?) (?) @ 2015-05-12 13:23 ` Jani Nikula -1 siblings, 0 replies; 10+ messages in thread From: Jani Nikula @ 2015-05-12 13:23 UTC (permalink / raw) To: Liu Ying, dri-devel; +Cc: daniel.vetter I guess this fell between the cracks. Reviewed-by: Jani Nikula <jani.nikula@intel.com> On Fri, 13 Feb 2015, Liu Ying <Ying.Liu@freescale.com> wrote: > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > --- > v9->v9.5: > * Add kernel-doc for the new helper function to address Daniel Vetter's > comment. > > v8->v9: > * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. > > v7->v8: > * None. > > v6->v7: > * None. > > v5->v6: > * Address the over 80 characters in one line warning reported by the > checkpatch.pl script. > > v4->v5: > * None. > > v3->v4: > * None. > > v2->v3: > * None. > > v1->v2: > * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function > could be placed at the common DRM MIPI DSI driver. > This patch is newly added. > > include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index f1d8d0d..cabc910 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) > return container_of(dev, struct mipi_dsi_device, dev); > } > > +/** > + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi > + * pixel format > + * @fmt: mipi dsi pixel format > + * > + * Return: The bits per pixel value for the mipi dsi pixel format on success or > + * a negative error code on failure. > + */ > +static inline int mipi_dsi_pixel_format_to_bpp(enum mipi_dsi_pixel_format fmt) > +{ > + switch (fmt) { > + case MIPI_DSI_FMT_RGB888: > + case MIPI_DSI_FMT_RGB666: > + return 24; > + case MIPI_DSI_FMT_RGB666_PACKED: > + return 18; > + case MIPI_DSI_FMT_RGB565: > + return 16; > + } > + return -EINVAL; > +} > + > struct mipi_dsi_device *of_find_mipi_dsi_device_by_node(struct device_node *np); > int mipi_dsi_attach(struct mipi_dsi_device *dsi); > int mipi_dsi_detach(struct mipi_dsi_device *dsi); > -- > 2.1.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format 2015-02-13 5:25 ` Liu Ying (?) @ 2015-05-12 13:36 ` Thierry Reding -1 siblings, 0 replies; 10+ messages in thread From: Thierry Reding @ 2015-05-12 13:36 UTC (permalink / raw) To: linux-arm-kernel On Fri, Feb 13, 2015 at 01:25:19PM +0800, Liu Ying wrote: > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> This could use a commit message. Describe for example why this is useful or when to use it. > --- > v9->v9.5: > * Add kernel-doc for the new helper function to address Daniel Vetter's > comment. > > v8->v9: > * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. > > v7->v8: > * None. > > v6->v7: > * None. > > v5->v6: > * Address the over 80 characters in one line warning reported by the > checkpatch.pl script. > > v4->v5: > * None. > > v3->v4: > * None. > > v2->v3: > * None. > > v1->v2: > * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function > could be placed at the common DRM MIPI DSI driver. > This patch is newly added. > > include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index f1d8d0d..cabc910 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) > return container_of(dev, struct mipi_dsi_device, dev); > } > > +/** > + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi > + * pixel format > + * @fmt: mipi dsi pixel format > + * > + * Return: The bits per pixel value for the mipi dsi pixel format on success or > + * a negative error code on failure. > + */ s/mipi dsi/MIPI DSI/, please. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150512/5280e193/attachment.sig> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format @ 2015-05-12 13:36 ` Thierry Reding 0 siblings, 0 replies; 10+ messages in thread From: Thierry Reding @ 2015-05-12 13:36 UTC (permalink / raw) To: Liu Ying Cc: dri-devel, devicetree, linux-arm-kernel, linux, kernel, p.zabel, shawn.guo, mturquette, airlied, andyshrk, stefan.wahren, a.hajda, sboyd, daniel.vetter, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1633 bytes --] On Fri, Feb 13, 2015 at 01:25:19PM +0800, Liu Ying wrote: > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> This could use a commit message. Describe for example why this is useful or when to use it. > --- > v9->v9.5: > * Add kernel-doc for the new helper function to address Daniel Vetter's > comment. > > v8->v9: > * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. > > v7->v8: > * None. > > v6->v7: > * None. > > v5->v6: > * Address the over 80 characters in one line warning reported by the > checkpatch.pl script. > > v4->v5: > * None. > > v3->v4: > * None. > > v2->v3: > * None. > > v1->v2: > * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function > could be placed at the common DRM MIPI DSI driver. > This patch is newly added. > > include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index f1d8d0d..cabc910 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) > return container_of(dev, struct mipi_dsi_device, dev); > } > > +/** > + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi > + * pixel format > + * @fmt: mipi dsi pixel format > + * > + * Return: The bits per pixel value for the mipi dsi pixel format on success or > + * a negative error code on failure. > + */ s/mipi dsi/MIPI DSI/, please. Thierry [-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format @ 2015-05-12 13:36 ` Thierry Reding 0 siblings, 0 replies; 10+ messages in thread From: Thierry Reding @ 2015-05-12 13:36 UTC (permalink / raw) To: Liu Ying Cc: stefan.wahren, devicetree, linux, daniel.vetter, sboyd, linux-kernel, dri-devel, a.hajda, kernel, mturquette, linux-arm-kernel, andyshrk [-- Attachment #1.1: Type: text/plain, Size: 1633 bytes --] On Fri, Feb 13, 2015 at 01:25:19PM +0800, Liu Ying wrote: > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> This could use a commit message. Describe for example why this is useful or when to use it. > --- > v9->v9.5: > * Add kernel-doc for the new helper function to address Daniel Vetter's > comment. > > v8->v9: > * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. > > v7->v8: > * None. > > v6->v7: > * None. > > v5->v6: > * Address the over 80 characters in one line warning reported by the > checkpatch.pl script. > > v4->v5: > * None. > > v3->v4: > * None. > > v2->v3: > * None. > > v1->v2: > * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function > could be placed at the common DRM MIPI DSI driver. > This patch is newly added. > > include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index f1d8d0d..cabc910 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) > return container_of(dev, struct mipi_dsi_device, dev); > } > > +/** > + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi > + * pixel format > + * @fmt: mipi dsi pixel format > + * > + * Return: The bits per pixel value for the mipi dsi pixel format on success or > + * a negative error code on failure. > + */ s/mipi dsi/MIPI DSI/, please. Thierry [-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format 2015-05-12 13:36 ` Thierry Reding (?) @ 2015-05-14 2:10 ` Liu Ying -1 siblings, 0 replies; 10+ messages in thread From: Liu Ying @ 2015-05-14 2:10 UTC (permalink / raw) To: linux-arm-kernel 2015-05-12 21:36 GMT+08:00 Thierry Reding <thierry.reding@gmail.com>: > On Fri, Feb 13, 2015 at 01:25:19PM +0800, Liu Ying wrote: >> Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > > This could use a commit message. Describe for example why this is useful > or when to use it. Ok, I'll add it in the next version. > >> --- >> v9->v9.5: >> * Add kernel-doc for the new helper function to address Daniel Vetter's >> comment. >> >> v8->v9: >> * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. >> >> v7->v8: >> * None. >> >> v6->v7: >> * None. >> >> v5->v6: >> * Address the over 80 characters in one line warning reported by the >> checkpatch.pl script. >> >> v4->v5: >> * None. >> >> v3->v4: >> * None. >> >> v2->v3: >> * None. >> >> v1->v2: >> * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function >> could be placed at the common DRM MIPI DSI driver. >> This patch is newly added. >> >> include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h >> index f1d8d0d..cabc910 100644 >> --- a/include/drm/drm_mipi_dsi.h >> +++ b/include/drm/drm_mipi_dsi.h >> @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) >> return container_of(dev, struct mipi_dsi_device, dev); >> } >> >> +/** >> + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi >> + * pixel format >> + * @fmt: mipi dsi pixel format >> + * >> + * Return: The bits per pixel value for the mipi dsi pixel format on success or >> + * a negative error code on failure. >> + */ > > s/mipi dsi/MIPI DSI/, please. Ok. Thanks, Liu Ying > > Thierry > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Best Regards, Liu Ying ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format @ 2015-05-14 2:10 ` Liu Ying 0 siblings, 0 replies; 10+ messages in thread From: Liu Ying @ 2015-05-14 2:10 UTC (permalink / raw) To: Thierry Reding Cc: Liu Ying, stefan.wahren, devicetree@vger.kernel.org, Russell King - ARM Linux, daniel.vetter, sboyd, linux-kernel, dri-devel, a.hajda, kernel, Mike Turquette, linux-arm-kernel, andyshrk 2015-05-12 21:36 GMT+08:00 Thierry Reding <thierry.reding@gmail.com>: > On Fri, Feb 13, 2015 at 01:25:19PM +0800, Liu Ying wrote: >> Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > > This could use a commit message. Describe for example why this is useful > or when to use it. Ok, I'll add it in the next version. > >> --- >> v9->v9.5: >> * Add kernel-doc for the new helper function to address Daniel Vetter's >> comment. >> >> v8->v9: >> * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. >> >> v7->v8: >> * None. >> >> v6->v7: >> * None. >> >> v5->v6: >> * Address the over 80 characters in one line warning reported by the >> checkpatch.pl script. >> >> v4->v5: >> * None. >> >> v3->v4: >> * None. >> >> v2->v3: >> * None. >> >> v1->v2: >> * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function >> could be placed at the common DRM MIPI DSI driver. >> This patch is newly added. >> >> include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h >> index f1d8d0d..cabc910 100644 >> --- a/include/drm/drm_mipi_dsi.h >> +++ b/include/drm/drm_mipi_dsi.h >> @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) >> return container_of(dev, struct mipi_dsi_device, dev); >> } >> >> +/** >> + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi >> + * pixel format >> + * @fmt: mipi dsi pixel format >> + * >> + * Return: The bits per pixel value for the mipi dsi pixel format on success or >> + * a negative error code on failure. >> + */ > > s/mipi dsi/MIPI DSI/, please. Ok. Thanks, Liu Ying > > Thierry > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Best Regards, Liu Ying ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format @ 2015-05-14 2:10 ` Liu Ying 0 siblings, 0 replies; 10+ messages in thread From: Liu Ying @ 2015-05-14 2:10 UTC (permalink / raw) To: Thierry Reding Cc: stefan.wahren, devicetree@vger.kernel.org, Russell King - ARM Linux, andyshrk, daniel.vetter, sboyd, linux-kernel, dri-devel, a.hajda, kernel, Mike Turquette, linux-arm-kernel 2015-05-12 21:36 GMT+08:00 Thierry Reding <thierry.reding@gmail.com>: > On Fri, Feb 13, 2015 at 01:25:19PM +0800, Liu Ying wrote: >> Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > > This could use a commit message. Describe for example why this is useful > or when to use it. Ok, I'll add it in the next version. > >> --- >> v9->v9.5: >> * Add kernel-doc for the new helper function to address Daniel Vetter's >> comment. >> >> v8->v9: >> * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. >> >> v7->v8: >> * None. >> >> v6->v7: >> * None. >> >> v5->v6: >> * Address the over 80 characters in one line warning reported by the >> checkpatch.pl script. >> >> v4->v5: >> * None. >> >> v3->v4: >> * None. >> >> v2->v3: >> * None. >> >> v1->v2: >> * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function >> could be placed at the common DRM MIPI DSI driver. >> This patch is newly added. >> >> include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h >> index f1d8d0d..cabc910 100644 >> --- a/include/drm/drm_mipi_dsi.h >> +++ b/include/drm/drm_mipi_dsi.h >> @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) >> return container_of(dev, struct mipi_dsi_device, dev); >> } >> >> +/** >> + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi >> + * pixel format >> + * @fmt: mipi dsi pixel format >> + * >> + * Return: The bits per pixel value for the mipi dsi pixel format on success or >> + * a negative error code on failure. >> + */ > > s/mipi dsi/MIPI DSI/, please. Ok. Thanks, Liu Ying > > Thierry > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Best Regards, Liu Ying _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-05-14 2:10 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-02-13 5:25 [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format Liu Ying 2015-02-13 5:25 ` Liu Ying 2015-02-13 5:25 ` Liu Ying 2015-05-12 13:23 ` Jani Nikula 2015-05-12 13:36 ` Thierry Reding 2015-05-12 13:36 ` Thierry Reding 2015-05-12 13:36 ` Thierry Reding 2015-05-14 2:10 ` Liu Ying 2015-05-14 2:10 ` Liu Ying 2015-05-14 2:10 ` Liu Ying
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.