All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Grygorii.Strashko@linaro.org" <grygorii.strashko@linaro.org>
Cc: Johan Hovold <johan@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: debugfs: display gpios requested as irq only
Date: Mon, 18 May 2015 17:58:37 +0200	[thread overview]
Message-ID: <20150518155837.GJ28127@localhost> (raw)
In-Reply-To: <555A0299.3030803@linaro.org>

On Mon, May 18, 2015 at 06:17:45PM +0300, Grygorii.Strashko@linaro.org wrote:
> On 05/18/2015 06:08 PM, Johan Hovold wrote:

> > How about instead of
> > 
> > 	GPIOs 160-191, platform/4805d000.gpio, gpio:
> > 	gpio-171 ((null)              ) in  hi IRQ209
> > 
> > you do something like:
> > 
> > 	GPIOs 160-191, platform/4805d000.gpio, gpio:
> > 	gpio-171 (<irq-only>          ) in  hi IRQ-209
> 
> In general agree, but i propose to do it as 
> 	GPIOs 160-191, platform/4805d000.gpio, gpio:
>  	gpio-171 ((null)          ) in  hi IRQ-209 <irq-only>

I have no strong opinion on whether to use the name-field here or not.

Using the name-field rather than adding a new one could perhaps be
less confusing to current parsers.

> My intention is - this interface could be considered as more or less
> stable, so it is better to add additional information at the end of
> each line to avoid potential breakage of User space SW (test/debug
> scripts).

But if the interface is considered stable (and some people do) you would
not be able to add anything here. This *is* a real issue, but I'll defer
this one to Linus and Alexandre.

Perhaps we should just leave things as they are.

Johan

  reply	other threads:[~2015-05-18 15:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15 13:25 [PATCH] gpiolib: debugfs: display gpios requested as irq only grygorii.strashko
2015-05-18 11:02 ` Johan Hovold
2015-05-18 13:06   ` Grygorii.Strashko@linaro.org
2015-05-18 15:08     ` Johan Hovold
2015-05-18 15:17       ` Grygorii.Strashko@linaro.org
2015-05-18 15:58         ` Johan Hovold [this message]
2015-05-19 14:12         ` Linus Walleij
2015-05-19 14:37           ` Grygorii.Strashko@linaro.org
2015-05-19 14:50             ` Linus Walleij
2015-05-19 15:39           ` Johan Hovold
2015-05-20  7:21             ` Linus Walleij
2015-05-21 14:34               ` Johan Hovold
2015-05-19 14:28   ` Linus Walleij
2015-05-21 14:25     ` Johan Hovold
2015-05-21 20:33       ` Grygorii.Strashko@linaro.org
2015-05-24 17:12         ` Johan Hovold
2015-05-25 18:54           ` Grygorii.Strashko@linaro.org
2015-05-25 20:39             ` Johan Hovold
2015-06-01 13:09             ` Linus Walleij
2015-06-02 12:33               ` Grygorii.Strashko@linaro.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150518155837.GJ28127@localhost \
    --to=johan@kernel.org \
    --cc=gnurou@gmail.com \
    --cc=grygorii.strashko@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.