From: "Grygorii.Strashko@linaro.org" <grygorii.strashko@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Johan Hovold <johan@kernel.org>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: debugfs: display gpios requested as irq only
Date: Tue, 19 May 2015 17:37:48 +0300 [thread overview]
Message-ID: <555B4ABC.60304@linaro.org> (raw)
In-Reply-To: <CACRpkdYs+r+oSegZuMjvg9PueWr6xB7Z-BmsHD+cmgeV=XD=Sg@mail.gmail.com>
Hi Linus,
On 05/19/2015 05:12 PM, Linus Walleij wrote:
> On Mon, May 18, 2015 at 5:17 PM, Grygorii.Strashko@linaro.org
> <grygorii.strashko@linaro.org> wrote:
>> On 05/18/2015 06:08 PM, Johan Hovold wrote:
>
>>> GPIOs 160-191, platform/4805d000.gpio, gpio:
>>> gpio-171 (<irq-only> ) in hi IRQ-209
>>
>> In general agree, but i propose to do it as
>> GPIOs 160-191, platform/4805d000.gpio, gpio:
>> gpio-171 ((null) ) in hi IRQ-209 <irq-only>
>>
>> My intention is - this interface could be considered as more or less stable, so
>> it is better to add additional information at the end of each line to avoid
>> potential breakage of User space SW (test/debug scripts).
>
> What? If I wanted a stable interface I would use sysfs and document
> the ABI in Documentation/ABI/*.
>
> debugfs is not ABI.
>
> Debugfs is instable by definition, it is not for production. If tests depend on
> it they need to be ready to break and be updated, and in such case
> it is a very very good idea to put any such tests in tools/* in the
> kernel itself, as does trace-cmd and friends so you can patch the
> tests at the same time you patch the code.
Okay. Sorry, My comment was not fully correct - keyword was "more or less stable"
and of course it is not ABI.
Any way, the question is till here - How would it better to do?
gpio-171 (<irq-only> ) in hi IRQ-209
-- or --
gpio-171 ((null) ) in hi IRQ-209 <irq-only>
Thanks a lot for your comments.
--
regards,
-grygorii
next prev parent reply other threads:[~2015-05-19 14:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 13:25 [PATCH] gpiolib: debugfs: display gpios requested as irq only grygorii.strashko
2015-05-18 11:02 ` Johan Hovold
2015-05-18 13:06 ` Grygorii.Strashko@linaro.org
2015-05-18 15:08 ` Johan Hovold
2015-05-18 15:17 ` Grygorii.Strashko@linaro.org
2015-05-18 15:58 ` Johan Hovold
2015-05-19 14:12 ` Linus Walleij
2015-05-19 14:37 ` Grygorii.Strashko@linaro.org [this message]
2015-05-19 14:50 ` Linus Walleij
2015-05-19 15:39 ` Johan Hovold
2015-05-20 7:21 ` Linus Walleij
2015-05-21 14:34 ` Johan Hovold
2015-05-19 14:28 ` Linus Walleij
2015-05-21 14:25 ` Johan Hovold
2015-05-21 20:33 ` Grygorii.Strashko@linaro.org
2015-05-24 17:12 ` Johan Hovold
2015-05-25 18:54 ` Grygorii.Strashko@linaro.org
2015-05-25 20:39 ` Johan Hovold
2015-06-01 13:09 ` Linus Walleij
2015-06-02 12:33 ` Grygorii.Strashko@linaro.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555B4ABC.60304@linaro.org \
--to=grygorii.strashko@linaro.org \
--cc=gnurou@gmail.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.