From: Mark Brown <broonie@kernel.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
David Hendricks <dhendrix@google.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/4] spi: spidev: Add Google SPI flash compatible string
Date: Wed, 20 May 2015 11:37:46 +0100 [thread overview]
Message-ID: <20150520103746.GD21577@sirena.org.uk> (raw)
In-Reply-To: <555C5F65.7010204@collabora.co.uk>
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
On Wed, May 20, 2015 at 12:18:13PM +0200, Javier Martinez Canillas wrote:
> On 05/20/2015 12:13 PM, Mark Brown wrote:
> > This is adding a binding with no documentation, documentation is
> > mandatory for all bindings.
> Yes, I missed... sorry about that. Do you agree with the approach
> though so I can re-spin the patches adding the missing DT binding?
It's probably OK but I didn't really drill through since the binding was
missing. If these parts are commodity as described it seems surprising
that they aren't compatible with any existing kernel driver.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/4] spi: spidev: Add Google SPI flash compatible string
Date: Wed, 20 May 2015 11:37:46 +0100 [thread overview]
Message-ID: <20150520103746.GD21577@sirena.org.uk> (raw)
In-Reply-To: <555C5F65.7010204@collabora.co.uk>
On Wed, May 20, 2015 at 12:18:13PM +0200, Javier Martinez Canillas wrote:
> On 05/20/2015 12:13 PM, Mark Brown wrote:
> > This is adding a binding with no documentation, documentation is
> > mandatory for all bindings.
> Yes, I missed... sorry about that. Do you agree with the approach
> though so I can re-spin the patches adding the missing DT binding?
It's probably OK but I didn't really drill through since the binding was
missing. If these parts are commodity as described it seems surprising
that they aren't compatible with any existing kernel driver.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150520/22d5a0a5/attachment.sig>
next prev parent reply other threads:[~2015-05-20 10:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 13:34 [RFC PATCH 0/4] Add SPI flash support for Exynos Chromebooks Javier Martinez Canillas
2015-05-19 13:34 ` Javier Martinez Canillas
2015-05-19 13:34 ` [RFC PATCH 1/4] spi: spidev: Add Google SPI flash compatible string Javier Martinez Canillas
2015-05-19 13:34 ` Javier Martinez Canillas
2015-05-19 19:53 ` Baruch Siach
2015-05-19 19:53 ` Baruch Siach
2015-05-20 7:35 ` Javier Martinez Canillas
2015-05-20 7:35 ` Javier Martinez Canillas
2015-05-20 10:13 ` Mark Brown
2015-05-20 10:13 ` Mark Brown
2015-05-20 10:18 ` Javier Martinez Canillas
2015-05-20 10:18 ` Javier Martinez Canillas
2015-05-20 10:37 ` Mark Brown [this message]
2015-05-20 10:37 ` Mark Brown
2015-05-20 11:21 ` Javier Martinez Canillas
2015-05-20 11:21 ` Javier Martinez Canillas
2015-05-20 11:41 ` Mark Brown
2015-05-20 11:41 ` Mark Brown
2015-05-19 13:34 ` [RFC PATCH 2/4] ARM: dts: Add SPI flash node for Peach boards Javier Martinez Canillas
2015-05-19 13:34 ` Javier Martinez Canillas
2015-05-20 3:37 ` Krzysztof Kozlowski
2015-05-20 3:37 ` Krzysztof Kozlowski
2015-05-20 10:17 ` Javier Martinez Canillas
2015-05-20 10:17 ` Javier Martinez Canillas
2015-05-21 0:44 ` Krzysztof Kozlowski
2015-05-21 0:44 ` Krzysztof Kozlowski
2015-05-19 13:34 ` [RFC PATCH 3/4] ARM: dts: Add SPI flash node to exynos5250-snow Javier Martinez Canillas
2015-05-19 13:34 ` Javier Martinez Canillas
2015-05-20 3:38 ` Krzysztof Kozlowski
2015-05-20 3:38 ` Krzysztof Kozlowski
2015-05-19 13:34 ` [RFC PATCH 4/4] ARM: exynos_defconfig: Enable user mode SPI device support Javier Martinez Canillas
2015-05-19 13:34 ` Javier Martinez Canillas
2015-05-20 3:38 ` Krzysztof Kozlowski
2015-05-20 3:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520103746.GD21577@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dhendrix@google.com \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.