From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Mark Brown <broonie@kernel.org>
Cc: Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
David Hendricks <dhendrix@google.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/4] spi: spidev: Add Google SPI flash compatible string
Date: Wed, 20 May 2015 12:18:13 +0200 [thread overview]
Message-ID: <555C5F65.7010204@collabora.co.uk> (raw)
In-Reply-To: <20150520101318.GB21577@sirena.org.uk>
Hello Mark,
On 05/20/2015 12:13 PM, Mark Brown wrote:
> On Tue, May 19, 2015 at 03:34:11PM +0200, Javier Martinez Canillas wrote:
>> Google Chromebooks have a SPI flash that is used to store firmware and
>> different system parameters and data (i.e: Google Binary Block flags).
>
>> ---
>> drivers/spi/spidev.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> This is adding a binding with no documentation, documentation is
> mandatory for all bindings.
>
Yes, I missed... sorry about that. Do you agree with the approach
though so I can re-spin the patches adding the missing DT binding?
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/4] spi: spidev: Add Google SPI flash compatible string
Date: Wed, 20 May 2015 12:18:13 +0200 [thread overview]
Message-ID: <555C5F65.7010204@collabora.co.uk> (raw)
In-Reply-To: <20150520101318.GB21577@sirena.org.uk>
Hello Mark,
On 05/20/2015 12:13 PM, Mark Brown wrote:
> On Tue, May 19, 2015 at 03:34:11PM +0200, Javier Martinez Canillas wrote:
>> Google Chromebooks have a SPI flash that is used to store firmware and
>> different system parameters and data (i.e: Google Binary Block flags).
>
>> ---
>> drivers/spi/spidev.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> This is adding a binding with no documentation, documentation is
> mandatory for all bindings.
>
Yes, I missed... sorry about that. Do you agree with the approach
though so I can re-spin the patches adding the missing DT binding?
Best regards,
Javier
next prev parent reply other threads:[~2015-05-20 10:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 13:34 [RFC PATCH 0/4] Add SPI flash support for Exynos Chromebooks Javier Martinez Canillas
2015-05-19 13:34 ` Javier Martinez Canillas
2015-05-19 13:34 ` [RFC PATCH 1/4] spi: spidev: Add Google SPI flash compatible string Javier Martinez Canillas
2015-05-19 13:34 ` Javier Martinez Canillas
2015-05-19 19:53 ` Baruch Siach
2015-05-19 19:53 ` Baruch Siach
2015-05-20 7:35 ` Javier Martinez Canillas
2015-05-20 7:35 ` Javier Martinez Canillas
2015-05-20 10:13 ` Mark Brown
2015-05-20 10:13 ` Mark Brown
2015-05-20 10:18 ` Javier Martinez Canillas [this message]
2015-05-20 10:18 ` Javier Martinez Canillas
2015-05-20 10:37 ` Mark Brown
2015-05-20 10:37 ` Mark Brown
2015-05-20 11:21 ` Javier Martinez Canillas
2015-05-20 11:21 ` Javier Martinez Canillas
2015-05-20 11:41 ` Mark Brown
2015-05-20 11:41 ` Mark Brown
2015-05-19 13:34 ` [RFC PATCH 2/4] ARM: dts: Add SPI flash node for Peach boards Javier Martinez Canillas
2015-05-19 13:34 ` Javier Martinez Canillas
2015-05-20 3:37 ` Krzysztof Kozlowski
2015-05-20 3:37 ` Krzysztof Kozlowski
2015-05-20 10:17 ` Javier Martinez Canillas
2015-05-20 10:17 ` Javier Martinez Canillas
2015-05-21 0:44 ` Krzysztof Kozlowski
2015-05-21 0:44 ` Krzysztof Kozlowski
2015-05-19 13:34 ` [RFC PATCH 3/4] ARM: dts: Add SPI flash node to exynos5250-snow Javier Martinez Canillas
2015-05-19 13:34 ` Javier Martinez Canillas
2015-05-20 3:38 ` Krzysztof Kozlowski
2015-05-20 3:38 ` Krzysztof Kozlowski
2015-05-19 13:34 ` [RFC PATCH 4/4] ARM: exynos_defconfig: Enable user mode SPI device support Javier Martinez Canillas
2015-05-19 13:34 ` Javier Martinez Canillas
2015-05-20 3:38 ` Krzysztof Kozlowski
2015-05-20 3:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555C5F65.7010204@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=broonie@kernel.org \
--cc=dhendrix@google.com \
--cc=dianders@chromium.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.