From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase
Date: Thu, 21 May 2015 12:37:39 +0100 [thread overview]
Message-ID: <20150521113738.GI2129@work-vm> (raw)
In-Reply-To: <CAFEAcA94hYg31v2Kif3A49r5eeJTaQT4_XBMxViepHVOcZx6-A@mail.gmail.com>
* Peter Maydell (peter.maydell@linaro.org) wrote:
> On 21 May 2015 at 12:09, Markus Armbruster <armbru@redhat.com> wrote:
> > Kevin Wolf <kwolf@redhat.com> writes:
> >
> >> Am 21.05.2015 um 12:11 hat Peter Maydell geschrieben:
> >>> 2b add a subsection, send the subsection always in new qemu,
> >>> if receiving from an old qemu then calculate the phase from
> >>> the register fields in post-load
> >
> > Doesn't this break new -> old migration?
>
> Do we care about that? Personally I would have thought it was
> too hard to defend and a very narrow use case compared to old->new.
I have to care about it downstream so I'd prefer if it wasn't
broken upstream except where really hard.
Dave
> -- PMM
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2015-05-21 11:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 15:35 [Qemu-devel] [PATCH 0/8] fdc: Clean up and fix command processing Kevin Wolf
2015-05-19 15:35 ` [Qemu-devel] [PATCH 1/8] fdc: Rename fdctrl_reset_fifo() to fdctrl_to_command_phase() Kevin Wolf
2015-05-19 20:37 ` John Snow
2015-05-19 15:35 ` [Qemu-devel] [PATCH 2/8] fdc: Rename fdctrl_set_fifo() to fdctrl_to_result_phase() Kevin Wolf
2015-05-19 20:38 ` John Snow
2015-05-19 15:35 ` [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase Kevin Wolf
2015-05-19 20:38 ` John Snow
2015-05-19 20:44 ` Peter Maydell
2015-05-19 20:52 ` John Snow
2015-05-19 20:57 ` Peter Maydell
2015-05-20 7:54 ` Kevin Wolf
2015-05-20 8:06 ` Peter Maydell
2015-05-20 8:43 ` Kevin Wolf
2015-05-20 9:24 ` Peter Maydell
2015-05-20 11:55 ` John Snow
2015-05-20 12:07 ` Peter Maydell
2015-05-21 9:42 ` Kevin Wolf
2015-05-21 9:47 ` Dr. David Alan Gilbert
2015-05-21 10:11 ` Peter Maydell
2015-05-21 10:31 ` Kevin Wolf
2015-05-21 11:09 ` Markus Armbruster
2015-05-21 11:14 ` Peter Maydell
2015-05-21 11:37 ` Dr. David Alan Gilbert [this message]
2015-05-19 15:35 ` [Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data() Kevin Wolf
2015-05-19 20:39 ` John Snow
2015-05-19 20:52 ` Peter Maydell
2015-05-19 15:35 ` [Qemu-devel] [PATCH 5/8] fdc: Code cleanup " Kevin Wolf
2015-05-19 20:40 ` John Snow
2015-05-20 8:18 ` Kevin Wolf
2015-05-19 15:36 ` [Qemu-devel] [PATCH 6/8] fdc: Disentangle phases in fdctrl_read_data() Kevin Wolf
2015-05-19 20:40 ` John Snow
2015-05-20 8:25 ` Kevin Wolf
2015-05-20 11:59 ` John Snow
2015-05-19 15:36 ` [Qemu-devel] [PATCH 7/8] fdc: Fix MSR.RQM flag Kevin Wolf
2015-05-19 20:40 ` John Snow
2015-05-20 8:14 ` Kevin Wolf
2015-05-20 11:58 ` John Snow
2015-05-19 15:36 ` [Qemu-devel] [PATCH 8/8] fdc-test: Test state for existing cases more thoroughly Kevin Wolf
2015-05-19 20:41 ` John Snow
2015-05-19 20:37 ` [Qemu-devel] [PATCH 0/8] fdc: Clean up and fix command processing John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521113738.GI2129@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.