* [PATCH] kernel:ptrace - Fix typo in comment in function __ptrace_unlink().
@ 2015-05-23 5:08 Shailendra Verma
2015-05-24 1:19 ` Valdis.Kletnieks
2015-05-24 18:47 ` Oleg Nesterov
0 siblings, 2 replies; 3+ messages in thread
From: Shailendra Verma @ 2015-05-23 5:08 UTC (permalink / raw)
To: Roland McGrath, Oleg Nesterov; +Cc: linux-kernel, Shailendra Verma
Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
kernel/ptrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/ptrace.c b/kernel/ptrace.c
index c8e0e05..46249f9 100644
--- a/kernel/ptrace.c
+++ b/kernel/ptrace.c
@@ -108,7 +108,7 @@ void __ptrace_unlink(struct task_struct *child)
/*
* If transition to TASK_STOPPED is pending or in TASK_TRACED, kick
- * @child in the butt. Note that @resume should be used iff @child
+ * @child in the butt. Note that @resume should be used if @child
* is in TASK_TRACED; otherwise, we might unduly disrupt
* TASK_KILLABLE sleeps.
*/
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kernel:ptrace - Fix typo in comment in function __ptrace_unlink().
2015-05-23 5:08 [PATCH] kernel:ptrace - Fix typo in comment in function __ptrace_unlink() Shailendra Verma
@ 2015-05-24 1:19 ` Valdis.Kletnieks
2015-05-24 18:47 ` Oleg Nesterov
1 sibling, 0 replies; 3+ messages in thread
From: Valdis.Kletnieks @ 2015-05-24 1:19 UTC (permalink / raw)
To: Shailendra Verma; +Cc: Roland McGrath, Oleg Nesterov, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
On Sat, 23 May 2015 10:38:35 +0530, Shailendra Verma said:
> --- a/kernel/ptrace.c
> +++ b/kernel/ptrace.c
> @@ -108,7 +108,7 @@ void __ptrace_unlink(struct task_struct *child)
>
> /*
> * If transition to TASK_STOPPED is pending or in TASK_TRACED, kick
> - * @child in the butt. Note that @resume should be used iff @child
> + * @child in the butt. Note that @resume should be used if @child
Probably incorrect, as it appears to be using 'iff' in the mathematical
sense of 'if and only if'....
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kernel:ptrace - Fix typo in comment in function __ptrace_unlink().
2015-05-23 5:08 [PATCH] kernel:ptrace - Fix typo in comment in function __ptrace_unlink() Shailendra Verma
2015-05-24 1:19 ` Valdis.Kletnieks
@ 2015-05-24 18:47 ` Oleg Nesterov
1 sibling, 0 replies; 3+ messages in thread
From: Oleg Nesterov @ 2015-05-24 18:47 UTC (permalink / raw)
To: Shailendra Verma; +Cc: Roland McGrath, linux-kernel
So this "fix" is wrong.
But you know, even if it was correct... IMO, the fixes like this can
only make sense as a "while at it" part of the meaningful change.
On 05/23, Shailendra Verma wrote:
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
> kernel/ptrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/ptrace.c b/kernel/ptrace.c
> index c8e0e05..46249f9 100644
> --- a/kernel/ptrace.c
> +++ b/kernel/ptrace.c
> @@ -108,7 +108,7 @@ void __ptrace_unlink(struct task_struct *child)
>
> /*
> * If transition to TASK_STOPPED is pending or in TASK_TRACED, kick
> - * @child in the butt. Note that @resume should be used iff @child
> + * @child in the butt. Note that @resume should be used if @child
> * is in TASK_TRACED; otherwise, we might unduly disrupt
> * TASK_KILLABLE sleeps.
> */
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-24 18:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-23 5:08 [PATCH] kernel:ptrace - Fix typo in comment in function __ptrace_unlink() Shailendra Verma
2015-05-24 1:19 ` Valdis.Kletnieks
2015-05-24 18:47 ` Oleg Nesterov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.