Re: [PATCH v4 2/6] Document: dt: fsl: snvs: change support syscon

[Shawn Guo <shawn.guo@linaro.org>]

On Fri, May 22, 2015 at 10:36:35PM +0800, Frank.Li@freescale.com wrote:
> From: Frank Li <Frank.Li@freescale.com>
> 
> snvs actually is multi fucntion driver.
> Change to use syscon to access register.

The rationale of 'interrupts' change did not get covered in the commit
log.

Shawn

> 
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
> ---
>  .../devicetree/bindings/crypto/fsl-sec4.txt        | 28 ++++++++++++----------
>  1 file changed, 15 insertions(+), 13 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> index e402277..87f5921 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> @@ -288,12 +288,13 @@ Secure Non-Volatile Storage (SNVS) Node
>      Node defines address range and the associated
>      interrupt for the SNVS function.  This function
>      monitors security state information & reports
> -    security violations.
> +    security violations. This also included rtc,
> +    system power off and ON/OFF key.
>  
>    - compatible
>        Usage: required
>        Value type: <string>
> -      Definition: Must include "fsl,sec-v4.0-mon".
> +      Definition: Must include "fsl,sec-v4.0-mon" and "syscon".
>  
>    - reg
>        Usage: required
> @@ -324,7 +325,7 @@ Secure Non-Volatile Storage (SNVS) Node
>             the child address, parent address, & length.
>  
>     - interrupts
> -      Usage: required
> +      Usage: optional
>        Value type: <prop_encoded-array>
>        Definition:  Specifies the interrupts generated by this
>             device.  The value of the interrupts property
> @@ -341,7 +342,7 @@ Secure Non-Volatile Storage (SNVS) Node
>  
>  EXAMPLE
>  	sec_mon@314000 {
> -		compatible = "fsl,sec-v4.0-mon";
> +		compatible = "fsl,sec-v4.0-mon", "syscon";
>  		reg = <0x314000 0x1000>;
>  		ranges = <0 0x314000 0x1000>;
>  		interrupt-parent = <&mpic>;
> @@ -358,16 +359,19 @@ Secure Non-Volatile Storage (SNVS) Low Power (LP) RTC Node
>        Value type: <string>
>        Definition: Must include "fsl,sec-v4.0-mon-rtc-lp".
>  
> -  - reg
> +  - interrupts
>        Usage: required
> -      Value type: <prop-encoded-array>
> -      Definition: A standard property.  Specifies the physical
> -          address and length of the SNVS LP configuration registers.
> +      Value type: <prop_encoded-array>
> +      Definition: Specifies the interrupts generated by this
> +	   device.  The value of the interrupts property
> +	   consists of one interrupt specifier. The format
> +	   of the specifier is defined by the binding document
> +	   describing the node's interrupt parent.
>  
>  EXAMPLE
> -	sec_mon_rtc_lp@314000 {
> +	sec_mon_rtc_lp@1 {
>  		compatible = "fsl,sec-v4.0-mon-rtc-lp";
> -		reg = <0x34 0x58>;
> +		interrupts = <93 2>;
>  	};
>  
>  =====================================================================
> @@ -443,12 +447,10 @@ FULL EXAMPLE
>  		compatible = "fsl,sec-v4.0-mon";
>  		reg = <0x314000 0x1000>;
>  		ranges = <0 0x314000 0x1000>;
> -		interrupt-parent = <&mpic>;
> -		interrupts = <93 2>;
>  
>  		sec_mon_rtc_lp@34 {
>  			compatible = "fsl,sec-v4.0-mon-rtc-lp";
> -			reg = <0x34 0x58>;
> +			interrupts = <93 2>;
>  		};
>  	};
>  
> -- 
> 1.9.1
>