All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: Frank.Li@freescale.com
Cc: lznuaa@gmail.com, dmitry.torokhov@gmail.com, robh+dt@kernel.org,
	alexandre.belloni@free-electrons.com, linux@arm.linux.org.uk,
	linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org, rtc-linux@googlegroups.com,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 6/6] arm: dts: imx6sx: enable snvs power key
Date: Mon, 25 May 2015 15:39:05 +0800	[thread overview]
Message-ID: <20150525073904.GJ3264@dragon> (raw)
In-Reply-To: <1432305399-30571-7-git-send-email-Frank.Li@freescale.com>

On Fri, May 22, 2015 at 10:36:39PM +0800, Frank.Li@freescale.com wrote:
> From: Frank Li <Frank.Li@freescale.com>
> 
> enable snvs ONOFF power key support
> 
> Signed-off-by: Frank Li <Frank.Li@freescale.com>

Please use 'ARM: dts: imx6sx: ...' for the patch subject.

> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 3cb3b5b..ad38aea 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -677,6 +677,13 @@
>  					mask = <0x60>;
>  					status = "disabled";
>  				};
> +
> +				snvs_pwrkey: snvs-powerkey {
> +					compatible = "fsl,sec-v4.0-pwrkey";
> +					interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> +					linux,keycode = <116>; /* KEY_POWER */

With include/dt-bindings/input/input.h, you can use KEY_POWER directly
and save the comment.

Shawn

> +					wakeup;
> +				};
>  			};
>  
>  			epit1: epit@020d0000 {
> -- 
> 1.9.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@linaro.org>
To: Frank.Li@freescale.com
Cc: lznuaa@gmail.com, dmitry.torokhov@gmail.com, robh+dt@kernel.org,
	alexandre.belloni@free-electrons.com, linux@arm.linux.org.uk,
	linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org, rtc-linux@googlegroups.com,
	devicetree@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH v4 6/6] arm: dts: imx6sx: enable snvs power key
Date: Mon, 25 May 2015 15:39:05 +0800	[thread overview]
Message-ID: <20150525073904.GJ3264@dragon> (raw)
In-Reply-To: <1432305399-30571-7-git-send-email-Frank.Li@freescale.com>

On Fri, May 22, 2015 at 10:36:39PM +0800, Frank.Li@freescale.com wrote:
> From: Frank Li <Frank.Li@freescale.com>
> 
> enable snvs ONOFF power key support
> 
> Signed-off-by: Frank Li <Frank.Li@freescale.com>

Please use 'ARM: dts: imx6sx: ...' for the patch subject.

> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 3cb3b5b..ad38aea 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -677,6 +677,13 @@
>  					mask = <0x60>;
>  					status = "disabled";
>  				};
> +
> +				snvs_pwrkey: snvs-powerkey {
> +					compatible = "fsl,sec-v4.0-pwrkey";
> +					interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> +					linux,keycode = <116>; /* KEY_POWER */

With include/dt-bindings/input/input.h, you can use KEY_POWER directly
and save the comment.

Shawn

> +					wakeup;
> +				};
>  			};
>  
>  			epit1: epit@020d0000 {
> -- 
> 1.9.1
> 

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/6] arm: dts: imx6sx: enable snvs power key
Date: Mon, 25 May 2015 15:39:05 +0800	[thread overview]
Message-ID: <20150525073904.GJ3264@dragon> (raw)
In-Reply-To: <1432305399-30571-7-git-send-email-Frank.Li@freescale.com>

On Fri, May 22, 2015 at 10:36:39PM +0800, Frank.Li at freescale.com wrote:
> From: Frank Li <Frank.Li@freescale.com>
> 
> enable snvs ONOFF power key support
> 
> Signed-off-by: Frank Li <Frank.Li@freescale.com>

Please use 'ARM: dts: imx6sx: ...' for the patch subject.

> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 3cb3b5b..ad38aea 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -677,6 +677,13 @@
>  					mask = <0x60>;
>  					status = "disabled";
>  				};
> +
> +				snvs_pwrkey: snvs-powerkey {
> +					compatible = "fsl,sec-v4.0-pwrkey";
> +					interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> +					linux,keycode = <116>; /* KEY_POWER */

With include/dt-bindings/input/input.h, you can use KEY_POWER directly
and save the comment.

Shawn

> +					wakeup;
> +				};
>  			};
>  
>  			epit1: epit at 020d0000 {
> -- 
> 1.9.1
> 

  reply	other threads:[~2015-05-25  7:39 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 14:36 [PATCH v4 0/6] Change snvs rtc and poweroff to use syscon add pwrkey driver Frank.Li
2015-05-22 14:36 ` Frank.Li at freescale.com
2015-05-22 14:36 ` [rtc-linux] " Frank.Li
2015-05-22 14:36 ` [PATCH v4 1/6] rtc: arm: imx: snvs: change use syscon to access register Frank.Li
2015-05-22 14:36   ` Frank.Li at freescale.com
2015-05-22 14:36   ` [rtc-linux] " Frank.Li
2015-05-25  6:18   ` Shawn Guo
2015-05-25  6:18     ` Shawn Guo
2015-05-25  6:18     ` [rtc-linux] " Shawn Guo
2015-05-25  6:44   ` Shawn Guo
2015-05-25  6:44     ` Shawn Guo
2015-05-25  6:44     ` [rtc-linux] " Shawn Guo
2015-05-22 14:36 ` [PATCH v4 2/6] Document: dt: fsl: snvs: change support syscon Frank.Li
2015-05-22 14:36   ` Frank.Li at freescale.com
2015-05-22 14:36   ` [rtc-linux] " Frank.Li
2015-05-25  6:26   ` Shawn Guo
2015-05-25  6:26     ` Shawn Guo
2015-05-25  6:26     ` [rtc-linux] " Shawn Guo
2015-05-22 14:36 ` [PATCH v4 3/6] arm: dts: imx: update snvs to use syscon access register Frank.Li
2015-05-22 14:36   ` Frank.Li at freescale.com
2015-05-22 14:36   ` [rtc-linux] " Frank.Li
2015-05-25  6:39   ` Shawn Guo
2015-05-25  6:39     ` Shawn Guo
2015-05-25  6:39     ` [rtc-linux] " Shawn Guo
2015-05-22 14:36 ` [PATCH v4 4/6] input: keyboard: imx: add snvs power key driver Frank.Li
2015-05-22 14:36   ` Frank.Li at freescale.com
2015-05-22 14:36   ` [rtc-linux] " Frank.Li
2015-05-25  7:35   ` Shawn Guo
2015-05-25  7:35     ` Shawn Guo
2015-05-25  7:35     ` [rtc-linux] " Shawn Guo
2015-05-22 14:36 ` [PATCH v4 5/6] document: devicetree: input: imx: i.mx snvs power device tree bindings Frank.Li
2015-05-22 14:36   ` Frank.Li at freescale.com
2015-05-22 14:36   ` [rtc-linux] " Frank.Li
     [not found] ` <1432305399-30571-1-git-send-email-Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-05-22 14:36   ` [PATCH v4 6/6] arm: dts: imx6sx: enable snvs power key Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-05-22 14:36     ` Frank.Li at freescale.com
2015-05-22 14:36     ` [rtc-linux] " Frank.Li
2015-05-25  7:39     ` Shawn Guo [this message]
2015-05-25  7:39       ` Shawn Guo
2015-05-25  7:39       ` [rtc-linux] " Shawn Guo
2015-05-25  6:47 ` [PATCH v4 0/6] Change snvs rtc and poweroff to use syscon add pwrkey driver Shawn Guo
2015-05-25  6:47   ` Shawn Guo
2015-05-25  6:47   ` [rtc-linux] " Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150525073904.GJ3264@dragon \
    --to=shawn.guo@linaro.org \
    --cc=Frank.Li@freescale.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=lznuaa@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.