From: Viresh Kumar <viresh.kumar@linaro.org>
To: Nishanth Menon <nm@ti.com>
Cc: thomas.petazzoni@free-electrons.com, rob.herring@linaro.org,
kesavan.abhilash@gmail.com, linaro-kernel@lists.linaro.org,
ta.omasab@gmail.com, khilman@linaro.org,
linux-pm@vger.kernel.org, viswanath.puttagunta@linaro.org,
sboyd@codeaurora.org, santosh.shilimkar@oracle.com,
Rafael Wysocki <rjw@rjwysocki.net>,
olof@lixom.net, devicetree@vger.kernel.org, broonie@kernel.org,
mike.turquette@linaro.org, Sudeep.Holla@arm.com,
grant.likely@linaro.org, arnd.bergmann@linaro.org,
linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de
Subject: Re: [PATCH V5 2/3] OPP: Allow multiple OPP tables to be passed via DT
Date: Tue, 26 May 2015 10:21:24 +0530 [thread overview]
Message-ID: <20150526045124.GH23464@linux> (raw)
In-Reply-To: <555D6E77.3060206@ti.com>
On 21-05-15, 00:34, Nishanth Menon wrote:
> > + cpu0_opp0: opp0 {
>
> Maybe we should rename these as cpu0_opp_table_slow opp_table-fast
>
> > + compatible = "operating-points-v2";
> > + opp-name = "opp-slow";
>
> just name = "slow" ?
>
> > + opp-shared;
> > +
> > + entry00 {
>
> rename these as opp0, opp01 etc?
> these are the actual OPP description, while, what we call "cpu0_opp0" is
> actually an OPP table choice we have.
What about this now:
+Example 5: Multiple OPP tables
+
+/ {
+ cpus {
+ cpu@0 {
+ compatible = "arm,cortex-a7";
+ ...
+
+ opp-supply = <&cpu_supply>
+ operating-points-v2 = <&cpu0_opp_table_slow>, <&cpu0_opp_table_fast>;
+ };
+ };
+
+ cpu0_opp_table_slow: opp_table_slow {
+ compatible = "operating-points-v2";
+ opp-name = "slow";
+ opp-shared;
+
+ opp00 {
+ opp-hz = <600000000>;
+ ...
+ };
+
+ opp01 {
+ opp-hz = <800000000>;
+ ...
+ };
+ };
+
+ cpu0_opp_table_fast: opp_table_fast {
+ compatible = "operating-points-v2";
+ opp-name = "fast";
+ opp-shared;
+
+ opp10 {
+ opp-hz = <1000000000>;
+ ...
+ };
+
+ opp11 {
+ opp-hz = <1100000000>;
+ ...
+ };
+ };
+};
May I carry your Ack or you want to give it again?
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 2/3] OPP: Allow multiple OPP tables to be passed via DT
Date: Tue, 26 May 2015 10:21:24 +0530 [thread overview]
Message-ID: <20150526045124.GH23464@linux> (raw)
In-Reply-To: <555D6E77.3060206@ti.com>
On 21-05-15, 00:34, Nishanth Menon wrote:
> > + cpu0_opp0: opp0 {
>
> Maybe we should rename these as cpu0_opp_table_slow opp_table-fast
>
> > + compatible = "operating-points-v2";
> > + opp-name = "opp-slow";
>
> just name = "slow" ?
>
> > + opp-shared;
> > +
> > + entry00 {
>
> rename these as opp0, opp01 etc?
> these are the actual OPP description, while, what we call "cpu0_opp0" is
> actually an OPP table choice we have.
What about this now:
+Example 5: Multiple OPP tables
+
+/ {
+ cpus {
+ cpu at 0 {
+ compatible = "arm,cortex-a7";
+ ...
+
+ opp-supply = <&cpu_supply>
+ operating-points-v2 = <&cpu0_opp_table_slow>, <&cpu0_opp_table_fast>;
+ };
+ };
+
+ cpu0_opp_table_slow: opp_table_slow {
+ compatible = "operating-points-v2";
+ opp-name = "slow";
+ opp-shared;
+
+ opp00 {
+ opp-hz = <600000000>;
+ ...
+ };
+
+ opp01 {
+ opp-hz = <800000000>;
+ ...
+ };
+ };
+
+ cpu0_opp_table_fast: opp_table_fast {
+ compatible = "operating-points-v2";
+ opp-name = "fast";
+ opp-shared;
+
+ opp10 {
+ opp-hz = <1000000000>;
+ ...
+ };
+
+ opp11 {
+ opp-hz = <1100000000>;
+ ...
+ };
+ };
+};
May I carry your Ack or you want to give it again?
--
viresh
next prev parent reply other threads:[~2015-05-26 4:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 3:41 [PATCH V5 0/3] OPP: Introduce OPP (V2) bindings Viresh Kumar
2015-05-20 3:41 ` Viresh Kumar
2015-05-20 3:41 ` [PATCH V5 1/3] OPP: Redefine bindings to overcome shortcomings Viresh Kumar
2015-05-20 3:41 ` Viresh Kumar
2015-05-20 13:27 ` Rob Herring
2015-05-20 13:27 ` Rob Herring
[not found] ` <CAL_JsqKR0-TcBjCnoaLBR9M2wGHCOuO2KSyL+4U+dpTvHGzubQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-20 13:35 ` Viresh Kumar
2015-05-20 13:35 ` Viresh Kumar
2015-05-21 5:27 ` Nishanth Menon
2015-05-21 5:27 ` Nishanth Menon
2015-05-21 5:46 ` Viresh Kumar
2015-05-21 5:46 ` Viresh Kumar
2015-05-21 5:58 ` Nishanth Menon
2015-05-21 5:58 ` Nishanth Menon
2015-05-21 6:06 ` Viresh Kumar
2015-05-21 6:06 ` Viresh Kumar
2015-05-22 15:55 ` Rob Herring
2015-05-22 15:55 ` Rob Herring
[not found] ` <CAL_JsqKhpyLgh5_1jZ_u0OP7=Piw=pgqZdQJ0K4Rm7DQ5ve+gA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-26 5:20 ` Viresh Kumar
2015-05-26 5:20 ` Viresh Kumar
2015-05-26 5:14 ` Viresh Kumar
2015-05-26 5:14 ` Viresh Kumar
2015-05-20 3:41 ` [PATCH V5 2/3] OPP: Allow multiple OPP tables to be passed via DT Viresh Kumar
2015-05-20 3:41 ` Viresh Kumar
2015-05-21 5:34 ` Nishanth Menon
2015-05-21 5:34 ` Nishanth Menon
2015-05-21 5:50 ` Viresh Kumar
2015-05-21 5:50 ` Viresh Kumar
2015-05-26 4:51 ` Viresh Kumar [this message]
2015-05-26 4:51 ` Viresh Kumar
2015-05-20 3:41 ` [PATCH V5 3/3] OPP: Add binding for 'opp-suspend' Viresh Kumar
2015-05-20 3:41 ` Viresh Kumar
2015-05-21 5:32 ` Nishanth Menon
2015-05-21 5:32 ` Nishanth Menon
2015-05-21 5:49 ` Viresh Kumar
2015-05-21 5:49 ` Viresh Kumar
2015-05-21 6:04 ` Nishanth Menon
2015-05-21 6:04 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526045124.GH23464@linux \
--to=viresh.kumar@linaro.org \
--cc=Sudeep.Holla@arm.com \
--cc=arnd.bergmann@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=kesavan.abhilash@gmail.com \
--cc=khilman@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mike.turquette@linaro.org \
--cc=nm@ti.com \
--cc=olof@lixom.net \
--cc=rjw@rjwysocki.net \
--cc=rob.herring@linaro.org \
--cc=santosh.shilimkar@oracle.com \
--cc=sboyd@codeaurora.org \
--cc=ta.omasab@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=viswanath.puttagunta@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.