All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Joe Perches <joe@perches.com>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	devel@driverdev.osuosl.org,
	Sudip Mukherjee <sudip@vectorindia.org>,
	linux-wireless@vger.kernel.org, Stable <stable@vger.kernel.org>,
	netdev@vger.kernel.org, Haggai Eran <haggai.eran@gmail.com>,
	Arek Rusniak <arek.rusi@gmail.com>,
	Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()
Date: Tue, 26 May 2015 18:48:26 +0300	[thread overview]
Message-ID: <20150526154826.GJ11588@mwanda> (raw)
In-Reply-To: <20150526141401.GC21573@kroah.com>

On Tue, May 26, 2015 at 07:14:01AM -0700, Greg KH wrote:
> I take the blame for any problems with Outreachy patches.  Given the
> huge volume of them, one bug out of 900 isn't that bad of a percentage.

We don't get many bugs through outreachy, but this isn't the first one.
For example, in March and April people complained about:

95745e9b1de2 ('staging: lustre: Use kasprintf.')
45de432775d6 ('Staging: rtl8712: Use memdup_user() instead of copy_from_user()')

There have been others but I have a short memory.  We have this
discussion every time.  How come no one caught this bug in review??  Oh,
it never went through the list.

I'm fine with 5 bugs per 900 patches or whatever.  I wish that the
patches came to the list, but I get that that would double your review
workload to review 900 patches on the outreachy list and again on the
normal dev list.

regards,
dan carpenter

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org,
	Sudip Mukherjee <sudip@vectorindia.org>,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	Stable <stable@vger.kernel.org>,
	Haggai Eran <haggai.eran@gmail.com>,
	Joe Perches <joe@perches.com>, Arek Rusniak <arek.rusi@gmail.com>,
	Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()
Date: Tue, 26 May 2015 18:48:26 +0300	[thread overview]
Message-ID: <20150526154826.GJ11588@mwanda> (raw)
In-Reply-To: <20150526141401.GC21573@kroah.com>

On Tue, May 26, 2015 at 07:14:01AM -0700, Greg KH wrote:
> I take the blame for any problems with Outreachy patches.  Given the
> huge volume of them, one bug out of 900 isn't that bad of a percentage.

We don't get many bugs through outreachy, but this isn't the first one.
For example, in March and April people complained about:

95745e9b1de2 ('staging: lustre: Use kasprintf.')
45de432775d6 ('Staging: rtl8712: Use memdup_user() instead of copy_from_user()')

There have been others but I have a short memory.  We have this
discussion every time.  How come no one caught this bug in review??  Oh,
it never went through the list.

I'm fine with 5 bugs per 900 patches or whatever.  I wish that the
patches came to the list, but I get that that would double your review
workload to review 900 patches on the outreachy list and again on the
normal dev list.

regards,
dan carpenter

  parent reply	other threads:[~2015-05-26 15:48 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-23 21:16 [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync() Larry Finger
2015-05-24 19:03 ` Haggai Eran
2015-05-25  0:11   ` Larry Finger
2015-05-25  9:17     ` Dan Carpenter
2015-05-25  9:17       ` Dan Carpenter
     [not found]       ` <CAK-LDb+1WscLTFw=NDY=_aUOGw72a4wRsqCU-1N+KJ11k15S5w@mail.gmail.com>
2015-05-25 10:12         ` Dan Carpenter
2015-05-25 10:12           ` Dan Carpenter
2015-05-25 15:52         ` Larry Finger
2015-05-25 15:52           ` Larry Finger
2015-05-25 17:37       ` Joe Perches
2015-05-25 17:37         ` Joe Perches
2015-05-26  4:46         ` Sudip Mukherjee
2015-05-26  4:46           ` Sudip Mukherjee
2015-05-26  4:55           ` Joe Perches
2015-05-26  4:55             ` Joe Perches
2015-05-26  5:02             ` Sudip Mukherjee
2015-05-26  5:02               ` Sudip Mukherjee
2015-05-26  5:07               ` Joe Perches
2015-05-26  5:30                 ` Sudip Mukherjee
2015-05-26  5:30                   ` Sudip Mukherjee
2015-05-26 15:31                   ` Larry Finger
2015-05-26 14:14                 ` Greg KH
2015-05-26 14:14                   ` Greg KH
2015-05-26 14:48                   ` Joe Perches
2015-05-26 16:35                     ` Greg KH
2015-05-26 17:06                       ` Joe Perches
2015-05-26 20:25                         ` Dan Carpenter
2015-05-26 20:25                           ` Dan Carpenter
2015-05-26 20:30                         ` Greg KH
2015-05-26 20:09                       ` Dan Carpenter
2015-05-26 20:09                         ` Dan Carpenter
2015-05-26 15:48                   ` Dan Carpenter [this message]
2015-05-26 15:48                     ` Dan Carpenter
2015-05-26 16:40                     ` Larry Finger
2015-05-25 16:02 ` Larry Finger
2015-05-31  2:53   ` Greg KH
2015-05-31  2:53     ` Greg KH
2015-05-31  2:54     ` Greg KH
2015-05-31  2:54       ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2015-05-25  4:42 Sudip Mukherjee
2015-05-25 15:59 ` Larry Finger
2015-05-25 15:59   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150526154826.GJ11588@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=arek.rusi@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=haggai.eran@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=sudip@vectorindia.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.