From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Jan Kardell <jan.kardell@telliq.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
Vincent Donnefort <vdonnefort@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
oen@telliq.com
Subject: [rtc-linux] Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.
Date: Wed, 27 May 2015 20:53:52 +0200 [thread overview]
Message-ID: <20150527185352.GJ2185@piout.net> (raw)
In-Reply-To: <1432730896-13423-1-git-send-email-jan.kardell@telliq.com>
Hi,
On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote :
> @@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm)
> pcf8563->voltage_low = 1;
> dev_info(&client->dev,
Aren't dev_err or dev_warn more appropriate? You used dev_err in your
first patch, what made you change your mind?
> "low voltage detected, date/time is not reliable.\n");
> + return -EINVAL;
> }
>
> dev_dbg(&client->dev,
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Jan Kardell <jan.kardell@telliq.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
Vincent Donnefort <vdonnefort@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
oen@telliq.com
Subject: Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.
Date: Wed, 27 May 2015 20:53:52 +0200 [thread overview]
Message-ID: <20150527185352.GJ2185@piout.net> (raw)
In-Reply-To: <1432730896-13423-1-git-send-email-jan.kardell@telliq.com>
Hi,
On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote :
> @@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm)
> pcf8563->voltage_low = 1;
> dev_info(&client->dev,
Aren't dev_err or dev_warn more appropriate? You used dev_err in your
first patch, what made you change your mind?
> "low voltage detected, date/time is not reliable.\n");
> + return -EINVAL;
> }
>
> dev_dbg(&client->dev,
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-27 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 12:48 [rtc-linux] [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time Jan Kardell
2015-05-27 12:48 ` Jan Kardell
2015-05-27 18:53 ` Alexandre Belloni [this message]
2015-05-27 18:53 ` Alexandre Belloni
2015-05-28 6:40 ` [rtc-linux] " Jan Kardell
2015-05-28 6:40 ` Jan Kardell
2015-05-30 22:16 ` [rtc-linux] " Richard Weinberger
2015-05-30 22:16 ` Richard Weinberger
2015-05-30 22:21 ` [rtc-linux] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527185352.GJ2185@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=dan.carpenter@oracle.com \
--cc=jan.kardell@telliq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oen@telliq.com \
--cc=rtc-linux@googlegroups.com \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.