From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Andrew Andrianov <andrew@ncrmnt.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] pinctrl: mvebu: Fix mapping of pin 63 (gpo -> gpio)
Date: Fri, 29 May 2015 11:10:02 +0200 [thread overview]
Message-ID: <20150529111002.7368ca50@free-electrons.com> (raw)
In-Reply-To: <1428784160-19431-2-git-send-email-andrew@ncrmnt.org>
Dear Andrew Andrianov,
On Sat, 11 Apr 2015 23:29:19 +0300, Andrew Andrianov wrote:
> Signed-off-by: Andrew Andrianov <andrew@ncrmnt.org>
> ---
> drivers/pinctrl/mvebu/pinctrl-armada-370.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-370.c b/drivers/pinctrl/mvebu/pinctrl-armada-370.c
> index c4f51d0..78c332d 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-370.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-370.c
> @@ -364,7 +364,7 @@ static struct mvebu_mpp_mode mv88f6710_mpp_modes[] = {
> MPP_FUNCTION(0x5, "audio", "mclk"),
> MPP_FUNCTION(0x6, "uart0", "cts")),
> MPP_MODE(63,
> - MPP_FUNCTION(0x0, "gpo", NULL),
> + MPP_FUNCTION(0x0, "gpio", NULL),
> MPP_FUNCTION(0x1, "spi0", "sck"),
> MPP_FUNCTION(0x2, "tclk", NULL)),
> MPP_MODE(64,
I know the patch has already been applied, but this is weird: I just
checked the datasheet again, and it really says this pin is a "gpo".
I'll try to get some more information.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] pinctrl: mvebu: Fix mapping of pin 63 (gpo -> gpio)
Date: Fri, 29 May 2015 11:10:02 +0200 [thread overview]
Message-ID: <20150529111002.7368ca50@free-electrons.com> (raw)
In-Reply-To: <1428784160-19431-2-git-send-email-andrew@ncrmnt.org>
Dear Andrew Andrianov,
On Sat, 11 Apr 2015 23:29:19 +0300, Andrew Andrianov wrote:
> Signed-off-by: Andrew Andrianov <andrew@ncrmnt.org>
> ---
> drivers/pinctrl/mvebu/pinctrl-armada-370.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-370.c b/drivers/pinctrl/mvebu/pinctrl-armada-370.c
> index c4f51d0..78c332d 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-370.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-370.c
> @@ -364,7 +364,7 @@ static struct mvebu_mpp_mode mv88f6710_mpp_modes[] = {
> MPP_FUNCTION(0x5, "audio", "mclk"),
> MPP_FUNCTION(0x6, "uart0", "cts")),
> MPP_MODE(63,
> - MPP_FUNCTION(0x0, "gpo", NULL),
> + MPP_FUNCTION(0x0, "gpio", NULL),
> MPP_FUNCTION(0x1, "spi0", "sck"),
> MPP_FUNCTION(0x2, "tclk", NULL)),
> MPP_MODE(64,
I know the patch has already been applied, but this is weird: I just
checked the datasheet again, and it really says this pin is a "gpo".
I'll try to get some more information.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-29 9:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-11 20:29 [PATCH 0/2] ARM: mvebu: Add DLINK-DNS327L support Andrew Andrianov
2015-04-11 20:29 ` Andrew Andrianov
2015-04-11 20:29 ` [PATCH 1/2] pinctrl: mvebu: Fix mapping of pin 63 (gpo -> gpio) Andrew Andrianov
2015-04-11 20:29 ` Andrew Andrianov
2015-04-27 13:24 ` Linus Walleij
2015-04-27 13:24 ` Linus Walleij
2015-05-29 9:10 ` Thomas Petazzoni [this message]
2015-05-29 9:10 ` Thomas Petazzoni
2015-05-29 9:55 ` Andrew
2015-05-29 9:55 ` Andrew
2015-05-29 9:55 ` Andrew
2015-05-29 10:06 ` Thomas Petazzoni
2015-05-29 10:06 ` Thomas Petazzoni
2015-04-11 20:29 ` [PATCH 2/2] ARM: mvebu: dts: Add dts file for DLink DNS-327L Andrew Andrianov
2015-04-11 20:29 ` Andrew Andrianov
2015-04-11 21:40 ` Andrew Lunn
2015-04-11 21:40 ` Andrew Lunn
[not found] ` <20150411214005.GJ5244-g2DYL2Zd6BY@public.gmane.org>
2015-04-11 21:45 ` Andrew Lunn
2015-04-11 21:45 ` Andrew Lunn
2015-04-11 21:45 ` Andrew Lunn
2015-04-12 11:25 ` [PATCH v2 0/2] ARM: mvebu: Add support for DLINK DNS-327L Andrew Andrianov
2015-04-12 11:25 ` Andrew Andrianov
2015-04-12 11:25 ` Andrew Andrianov
2015-04-12 11:25 ` [PATCH v2 1/2] pinctrl: mvebu: Fix mapping of pin 63 (gpo -> gpio) Andrew Andrianov
2015-04-12 11:25 ` Andrew Andrianov
2015-04-12 11:25 ` [PATCH v2 2/2] ARM: mvebu: dts: Add dts file for DLink DNS-327L Andrew Andrianov
2015-04-12 11:25 ` Andrew Andrianov
2015-04-12 11:25 ` Andrew Andrianov
2015-04-12 11:38 ` Sebastian Hesselbarth
2015-04-12 11:38 ` Sebastian Hesselbarth
2015-04-11 22:33 ` [PATCH " Andrew
2015-04-11 22:33 ` Andrew
2015-04-12 11:20 ` Sebastian Hesselbarth
2015-04-12 11:20 ` Sebastian Hesselbarth
2015-04-11 21:28 ` [PATCH 0/2] ARM: mvebu: Add DLINK-DNS327L support Andrew Lunn
2015-04-11 21:28 ` Andrew Lunn
2015-04-13 14:39 ` Gregory CLEMENT
2015-04-13 14:39 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529111002.7368ca50@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=andrew@ncrmnt.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.