From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Andrew Andrianov <andrew@ncrmnt.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] ARM: mvebu: Add DLINK-DNS327L support
Date: Mon, 13 Apr 2015 16:39:10 +0200 [thread overview]
Message-ID: <552BD50E.9080403@free-electrons.com> (raw)
In-Reply-To: <20150411212823.GI5244@lunn.ch>
Hi Andrew,
On 11/04/2015 23:28, Andrew Lunn wrote:
>> When power button is pressed to turn the NAS off, weltrend signals
>> the SoC by driving mpp63 line low. Apparently right now pinctrl assumes
>> that this line can only work as 'gpo' that screws up gpio-buttons driver.
>> Since without gpio-buttons, mpp63 works as input properly via sysfs
>> interface, I've added a patch for pinctrl-armada-370.c that fixes the
>> issue.
>
> Hi Andrew
>
> This is odd. I just checked the Marvell datasheets, and they list this
> pin a GPO.
>
> We probably want Thomas or Gregory to check this with Marvell.
I have check on the datasheet I have (in case of it was different of the public one)
and for all the variant of the Armada 370: 88F6710, 88F6707, and 88F6W11 the MPP63
is list as GPO.
I will ask Marvell to see if it was a typo on their datasheet.
Thanks,
Gregory
>
> Andrew
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] ARM: mvebu: Add DLINK-DNS327L support
Date: Mon, 13 Apr 2015 16:39:10 +0200 [thread overview]
Message-ID: <552BD50E.9080403@free-electrons.com> (raw)
In-Reply-To: <20150411212823.GI5244@lunn.ch>
Hi Andrew,
On 11/04/2015 23:28, Andrew Lunn wrote:
>> When power button is pressed to turn the NAS off, weltrend signals
>> the SoC by driving mpp63 line low. Apparently right now pinctrl assumes
>> that this line can only work as 'gpo' that screws up gpio-buttons driver.
>> Since without gpio-buttons, mpp63 works as input properly via sysfs
>> interface, I've added a patch for pinctrl-armada-370.c that fixes the
>> issue.
>
> Hi Andrew
>
> This is odd. I just checked the Marvell datasheets, and they list this
> pin a GPO.
>
> We probably want Thomas or Gregory to check this with Marvell.
I have check on the datasheet I have (in case of it was different of the public one)
and for all the variant of the Armada 370: 88F6710, 88F6707, and 88F6W11 the MPP63
is list as GPO.
I will ask Marvell to see if it was a typo on their datasheet.
Thanks,
Gregory
>
> Andrew
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-04-13 14:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-11 20:29 [PATCH 0/2] ARM: mvebu: Add DLINK-DNS327L support Andrew Andrianov
2015-04-11 20:29 ` Andrew Andrianov
2015-04-11 20:29 ` [PATCH 1/2] pinctrl: mvebu: Fix mapping of pin 63 (gpo -> gpio) Andrew Andrianov
2015-04-11 20:29 ` Andrew Andrianov
2015-04-27 13:24 ` Linus Walleij
2015-04-27 13:24 ` Linus Walleij
2015-05-29 9:10 ` Thomas Petazzoni
2015-05-29 9:10 ` Thomas Petazzoni
2015-05-29 9:55 ` Andrew
2015-05-29 9:55 ` Andrew
2015-05-29 9:55 ` Andrew
2015-05-29 10:06 ` Thomas Petazzoni
2015-05-29 10:06 ` Thomas Petazzoni
2015-04-11 20:29 ` [PATCH 2/2] ARM: mvebu: dts: Add dts file for DLink DNS-327L Andrew Andrianov
2015-04-11 20:29 ` Andrew Andrianov
2015-04-11 21:40 ` Andrew Lunn
2015-04-11 21:40 ` Andrew Lunn
[not found] ` <20150411214005.GJ5244-g2DYL2Zd6BY@public.gmane.org>
2015-04-11 21:45 ` Andrew Lunn
2015-04-11 21:45 ` Andrew Lunn
2015-04-11 21:45 ` Andrew Lunn
2015-04-12 11:25 ` [PATCH v2 0/2] ARM: mvebu: Add support for DLINK DNS-327L Andrew Andrianov
2015-04-12 11:25 ` Andrew Andrianov
2015-04-12 11:25 ` Andrew Andrianov
2015-04-12 11:25 ` [PATCH v2 1/2] pinctrl: mvebu: Fix mapping of pin 63 (gpo -> gpio) Andrew Andrianov
2015-04-12 11:25 ` Andrew Andrianov
2015-04-12 11:25 ` [PATCH v2 2/2] ARM: mvebu: dts: Add dts file for DLink DNS-327L Andrew Andrianov
2015-04-12 11:25 ` Andrew Andrianov
2015-04-12 11:25 ` Andrew Andrianov
2015-04-12 11:38 ` Sebastian Hesselbarth
2015-04-12 11:38 ` Sebastian Hesselbarth
2015-04-11 22:33 ` [PATCH " Andrew
2015-04-11 22:33 ` Andrew
2015-04-12 11:20 ` Sebastian Hesselbarth
2015-04-12 11:20 ` Sebastian Hesselbarth
2015-04-11 21:28 ` [PATCH 0/2] ARM: mvebu: Add DLINK-DNS327L support Andrew Lunn
2015-04-11 21:28 ` Andrew Lunn
2015-04-13 14:39 ` Gregory CLEMENT [this message]
2015-04-13 14:39 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552BD50E.9080403@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=andrew@ncrmnt.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.