From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG
Date: Mon, 1 Jun 2015 11:22:49 +0200 [thread overview]
Message-ID: <20150601092249.GF17267@lukather> (raw)
In-Reply-To: <1433088626-8858-2-git-send-email-hdegoede@redhat.com>
On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote:
> + /* We either want both gpio pins or neither (when in host mode) */
> + if (!data->id_det_gpio != !data->vbus_det_gpio) {
> + dev_err(dev, "failed to get id or vbus detect pin\n");
> + return -ENODEV;
> + }
The fact that the driver expects both to be set if one is should be in
the binding documentation.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150601/3108a512/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Roman Byshko <rbyshko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG
Date: Mon, 1 Jun 2015 11:22:49 +0200 [thread overview]
Message-ID: <20150601092249.GF17267@lukather> (raw)
In-Reply-To: <1433088626-8858-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote:
> + /* We either want both gpio pins or neither (when in host mode) */
> + if (!data->id_det_gpio != !data->vbus_det_gpio) {
> + dev_err(dev, "failed to get id or vbus detect pin\n");
> + return -ENODEV;
> + }
The fact that the driver expects both to be set if one is should be in
the binding documentation.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-06-01 9:22 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-31 16:10 [PATCH v4 0/2] Remaining sunxi musb patches Hans de Goede
2015-05-31 16:10 ` Hans de Goede
2015-05-31 16:10 ` [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG Hans de Goede
2015-05-31 16:10 ` Hans de Goede
2015-06-01 9:22 ` Maxime Ripard [this message]
2015-06-01 9:22 ` Maxime Ripard
2015-06-01 9:28 ` Hans de Goede
2015-06-01 9:28 ` Hans de Goede
2015-06-02 15:22 ` Maxime Ripard
2015-06-02 15:22 ` Maxime Ripard
2015-06-11 5:48 ` Kishon Vijay Abraham I
2015-06-11 5:48 ` Kishon Vijay Abraham I
2015-06-11 7:56 ` [linux-sunxi] " Hans de Goede
2015-06-11 7:56 ` Hans de Goede
2015-06-11 8:28 ` Hans de Goede
2015-06-11 8:28 ` Hans de Goede
2015-06-11 8:07 ` Chanwoo Choi
2015-06-11 8:07 ` Chanwoo Choi
2015-06-11 8:21 ` [linux-sunxi] " Hans de Goede
2015-06-11 8:21 ` Hans de Goede
2015-06-11 8:29 ` Chanwoo Choi
2015-06-11 8:29 ` Chanwoo Choi
2015-06-11 8:59 ` [linux-sunxi] " Hans de Goede
2015-06-11 8:59 ` Hans de Goede
2015-06-11 9:33 ` Chanwoo Choi
2015-06-11 9:33 ` Chanwoo Choi
2015-06-11 9:37 ` [linux-sunxi] " Chanwoo Choi
2015-06-11 9:37 ` Chanwoo Choi
2015-06-11 9:38 ` Hans de Goede
2015-06-11 9:38 ` Hans de Goede
2015-06-11 10:30 ` Chanwoo Choi
2015-06-11 10:30 ` Chanwoo Choi
2015-06-11 9:42 ` Kishon Vijay Abraham I
2015-06-11 9:42 ` Kishon Vijay Abraham I
2015-06-11 9:53 ` Hans de Goede
2015-06-11 9:53 ` Hans de Goede
2015-06-11 11:16 ` Kishon Vijay Abraham I
2015-06-11 11:16 ` Kishon Vijay Abraham I
2015-06-11 12:35 ` [linux-sunxi] " Hans de Goede
2015-06-11 12:35 ` Hans de Goede
2015-06-11 12:59 ` Kishon Vijay Abraham I
2015-06-11 12:59 ` Kishon Vijay Abraham I
2015-07-15 10:55 ` Kishon Vijay Abraham I
2015-07-15 10:55 ` Kishon Vijay Abraham I
2015-07-15 10:58 ` Kishon Vijay Abraham I
2015-07-15 10:58 ` Kishon Vijay Abraham I
2015-05-31 16:10 ` [PATCH v4 2/2] musb: Add support for the Allwinner sunxi musb controller Hans de Goede
2015-05-31 16:10 ` Hans de Goede
2015-06-02 15:02 ` Felipe Balbi
2015-06-02 15:02 ` Felipe Balbi
[not found] ` <1433088626-8858-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-01 18:30 ` [PATCH v4 0/2] Remaining sunxi musb patches Hans de Goede
2015-06-01 18:34 ` Felipe Balbi
2015-06-01 18:34 ` Felipe Balbi
2015-06-02 7:14 ` Hans de Goede
2015-06-02 7:14 ` Hans de Goede
2015-06-02 14:45 ` Felipe Balbi
2015-06-02 14:45 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601092249.GF17267@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.