From: Thierry Reding <treding@nvidia.com>
To: Doug Anderson <dianders@chromium.org>
Cc: fabio.estevam@freescale.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, ykk@rock-chips.com,
Russell King <rmk+kernel@arm.linux.org.uk>,
andy.yan@rock-chips.com
Subject: Re: [PATCH] drm: bridge/dw_hdmi: Return num_modes in dw_hdmi_connector_get_modes
Date: Fri, 5 Jun 2015 12:02:40 +0200 [thread overview]
Message-ID: <20150605100237.GC6436@ulmo.nvidia.com> (raw)
In-Reply-To: <1433441076-20049-1-git-send-email-dianders@chromium.org>
On Thu, Jun 04, 2015 at 11:04:36AM -0700, Doug Anderson wrote:
> The dw_hdmi_connector_get_modes() function accidentally forgets to
> return the number of modes it added, although it has this information
> stored in a local variable. Let's fix that.
>
> Without this fix, drm_helper_probe_single_connector_modes_merge_bits()
> could get confused and always call drm_add_modes_noedid(). That's not
> right.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> drivers/gpu/drm/bridge/dw_hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <treding@nvidia.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Russell King <rmk+kernel@arm.linux.org.uk>, <airlied@linux.ie>,
<andy.yan@rock-chips.com>, <ykk@rock-chips.com>,
<fabio.estevam@freescale.com>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: bridge/dw_hdmi: Return num_modes in dw_hdmi_connector_get_modes
Date: Fri, 5 Jun 2015 12:02:40 +0200 [thread overview]
Message-ID: <20150605100237.GC6436@ulmo.nvidia.com> (raw)
In-Reply-To: <1433441076-20049-1-git-send-email-dianders@chromium.org>
On Thu, Jun 04, 2015 at 11:04:36AM -0700, Doug Anderson wrote:
> The dw_hdmi_connector_get_modes() function accidentally forgets to
> return the number of modes it added, although it has this information
> stored in a local variable. Let's fix that.
>
> Without this fix, drm_helper_probe_single_connector_modes_merge_bits()
> could get confused and always call drm_add_modes_noedid(). That's not
> right.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> drivers/gpu/drm/bridge/dw_hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
next prev parent reply other threads:[~2015-06-05 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 18:04 [PATCH] drm: bridge/dw_hdmi: Return num_modes in dw_hdmi_connector_get_modes Doug Anderson
2015-06-05 6:15 ` Yakir
2015-06-05 10:02 ` Thierry Reding [this message]
2015-06-05 10:02 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150605100237.GC6436@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=andy.yan@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.