[Qemu-devel] [PATCH] qemu-sanity-check.in: Use '-display none' instead of '-nographic'

[Qemu-devel] [PATCH] qemu-sanity-check.in: Use '-display none' instead of '-nographic'

[Kashyap Chamarthy]

Upstream QEMU recommends to use '-display none' as opposed to
'-nographic' -- which is a "legacy option that does a whole bunch of
confusing stuff" (thanks Peter Maydell).

Upstream libguestfs already made the switch [1] in DEC-2013.

[1] https://github.com/libguestfs/libguestfs/commit/7a41f5c1 -- "launch:
    switch from -nographic to -display none "
---
 qemu-sanity-check.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/qemu-sanity-check.in b/qemu-sanity-check.in
index 5bb5b292def5caff5ca63071565bd447cf5f4efd..34cd9385f56b5eedd0ec26abd128232a47e51996 100644
--- a/qemu-sanity-check.in
+++ b/qemu-sanity-check.in
@@ -140,7 +140,8 @@ test_output="$(mktemp --suff=.out)"
 declare -a argv
 i=0
 argv[$((i++))]="$qemu"
-argv[$((i++))]="-nographic"
+argv[$((i++))]="-display"
+argv[$((i++))]="none"
 argv[$((i++))]="-nodefconfig"
 argv[$((i++))]="-nodefaults"
 argv[$((i++))]="-machine"
-- 
2.1.0

Re: [Qemu-devel] [PATCH] qemu-sanity-check.in: Use '-display none' instead of '-nographic'

[Richard W.M. Jones]

On Mon, Jun 08, 2015 at 06:47:00PM +0200, Kashyap Chamarthy wrote:
> Upstream QEMU recommends to use '-display none' as opposed to
> '-nographic' -- which is a "legacy option that does a whole bunch of
> confusing stuff" (thanks Peter Maydell).
> 
> Upstream libguestfs already made the switch [1] in DEC-2013.
> 
> [1] https://github.com/libguestfs/libguestfs/commit/7a41f5c1 -- "launch:
>     switch from -nographic to -display none "
> ---
>  qemu-sanity-check.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/qemu-sanity-check.in b/qemu-sanity-check.in
> index 5bb5b292def5caff5ca63071565bd447cf5f4efd..34cd9385f56b5eedd0ec26abd128232a47e51996 100644
> --- a/qemu-sanity-check.in
> +++ b/qemu-sanity-check.in
> @@ -140,7 +140,8 @@ test_output="$(mktemp --suff=.out)"
>  declare -a argv
>  i=0
>  argv[$((i++))]="$qemu"
> -argv[$((i++))]="-nographic"
> +argv[$((i++))]="-display"
> +argv[$((i++))]="none"
>  argv[$((i++))]="-nodefconfig"
>  argv[$((i++))]="-nodefaults"
>  argv[$((i++))]="-machine"
> -- 
> 2.1.0

Thanks -- I have pushed this patch upstream.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html