From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: alsa-devel@alsa-project.org, Timur Tabi <timur@tabi.org>,
Xiubo Li <Xiubo.Lee@gmail.com>, Takashi Iwai <tiwai@suse.de>,
kernel-janitors@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [patch] ASoC: fsl: add an error check
Date: Wed, 10 Jun 2015 22:17:32 +0300 [thread overview]
Message-ID: <20150610191732.GC11734@mwanda> (raw)
In-Reply-To: <20150610165544.GA8552@Asurada>
> Could you please use an subject like:
> ASoC: imx-wm8962: Add a missing error check
> (Since it only applies to this file)
>
I have been meaning to say something about this.
This is sort of a recurrent problem for me because I'm often the first
person to touch a driver after it's added. I just copied your patch
prefix from 8de2ae2a7f1f ('ASoC: fsl: add imx-wm8962 machine driver').
Really you should also have used "ASoC: imx-wm8962:" as well.
This is the third new driver today where I have faced this situation.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: alsa-devel@alsa-project.org, Timur Tabi <timur@tabi.org>,
Xiubo Li <Xiubo.Lee@gmail.com>, Takashi Iwai <tiwai@suse.de>,
kernel-janitors@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [patch] ASoC: fsl: add an error check
Date: Wed, 10 Jun 2015 19:17:32 +0000 [thread overview]
Message-ID: <20150610191732.GC11734@mwanda> (raw)
In-Reply-To: <20150610165544.GA8552@Asurada>
> Could you please use an subject like:
> ASoC: imx-wm8962: Add a missing error check
> (Since it only applies to this file)
>
I have been meaning to say something about this.
This is sort of a recurrent problem for me because I'm often the first
person to touch a driver after it's added. I just copied your patch
prefix from 8de2ae2a7f1f ('ASoC: fsl: add imx-wm8962 machine driver').
Really you should also have used "ASoC: imx-wm8962:" as well.
This is the third new driver today where I have faced this situation.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Timur Tabi <timur@tabi.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ASoC: fsl: add an error check
Date: Wed, 10 Jun 2015 22:17:32 +0300 [thread overview]
Message-ID: <20150610191732.GC11734@mwanda> (raw)
In-Reply-To: <20150610165544.GA8552@Asurada>
> Could you please use an subject like:
> ASoC: imx-wm8962: Add a missing error check
> (Since it only applies to this file)
>
I have been meaning to say something about this.
This is sort of a recurrent problem for me because I'm often the first
person to touch a driver after it's added. I just copied your patch
prefix from 8de2ae2a7f1f ('ASoC: fsl: add imx-wm8962 machine driver').
Really you should also have used "ASoC: imx-wm8962:" as well.
This is the third new driver today where I have faced this situation.
regards,
dan carpenter
next prev parent reply other threads:[~2015-06-10 19:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 15:37 [patch] ASoC: fsl: add an error check Dan Carpenter
2015-06-10 15:37 ` Dan Carpenter
2015-06-10 15:37 ` Dan Carpenter
2015-06-10 16:55 ` Nicolin Chen
2015-06-10 16:55 ` Nicolin Chen
2015-06-10 19:17 ` Dan Carpenter [this message]
2015-06-10 19:17 ` Dan Carpenter
2015-06-10 19:17 ` Dan Carpenter
2015-06-10 17:33 ` Mark Brown
2015-06-10 17:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610191732.GC11734@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.