All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Michal Marek <mmarek@suse.cz>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>, X86 ML <x86@kernel.org>,
	live-patching@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 00/10] x86/asm: Compile-time asm code validation
Date: Wed, 10 Jun 2015 15:26:29 -0500	[thread overview]
Message-ID: <20150610202629.GE1125@treble.redhat.com> (raw)
In-Reply-To: <CALCETrVQ2pX8dDrHgnymZjTe=dpGsoaNA=XGpAVV7J=ON+U7Ng@mail.gmail.com>

On Wed, Jun 10, 2015 at 11:24:05AM -0700, Andy Lutomirski wrote:
> Slightly off-topic, but this reminds me: when writing inline asm that
> needs to push to the stack (for whatever reason), it's incredibly
> messy to get the annotations right -- they're different depending on
> whether the previous frame base (is that what "CFA" is?) is currently
> sp + constant, in which case we need an annotation adjusting the
> constant or whether it's independent of sp (bp + constant), in which
> case we shouldn't adjust the offset.  (If it's some other function of
> sp, we're screwed.)
> 
> Regardless of whether these types of annotations end up being done by
> hand or by script, should we consider asking the binutils people to
> give us some nice .cfi_adjust_for_push and .cfi_adjust_for_pop or
> similar directives?

Hm, that's a tough one.  Might be worth asking...

Another alternative would be to ask gcc to make a change to always setup
the frame pointer for any function which has inline assembly, so that
you know (hopefully) that CFA is based on bp.

Or, maybe there's already a way to force gcc to do that with the asm
directive somehow?

> 
> See here for Jan Beulich's solution, which is incomprehensible to me:
> 
> http://thread.gmane.org/gmane.linux.kernel/1820765

<brain explodes>

-- 
Josh

      reply	other threads:[~2015-06-10 20:26 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 12:06 [PATCH v5 00/10] x86/asm: Compile-time asm code validation Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros Josh Poimboeuf
2015-06-10 18:17   ` Pavel Machek
2015-06-10 18:24     ` Josh Poimboeuf
2015-06-11  4:22     ` Jiri Kosina
2015-06-11  6:46       ` Pavel Machek
2015-06-11 12:06         ` Jiri Kosina
2015-06-11 14:18         ` Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 02/10] x86: Compile-time asm code validation Josh Poimboeuf
2015-06-10 17:21   ` Andy Lutomirski
2015-06-10 17:53     ` Josh Poimboeuf
2015-06-10 18:15       ` Andy Lutomirski
2015-06-10 18:58         ` Josh Poimboeuf
2015-06-10 22:17           ` Josh Poimboeuf
2015-06-11  6:08             ` Ingo Molnar
2015-06-11 14:01               ` Josh Poimboeuf
2015-06-11  6:10           ` Ingo Molnar
2015-06-11 14:10             ` Josh Poimboeuf
2015-06-12 11:18               ` Pedro Alves
2015-06-12 14:10                 ` Josh Poimboeuf
2015-06-12 16:00                   ` Pedro Alves
2015-06-12 16:41                     ` Josh Poimboeuf
2015-06-10 18:16     ` Vojtech Pavlik
2015-06-10 18:18       ` Andy Lutomirski
2015-06-10 12:06 ` [PATCH v5 03/10] x86/asm/entry: Fix asmvalidate warnings for entry_64_compat.S Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 04/10] x86/asm/crypto: Fix asmvalidate warnings for aesni-intel_asm.S Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 05/10] x86/asm/crypto: Fix asmvalidate warnings for ghash-clmulni-intel_asm.S Josh Poimboeuf
     [not found] ` <cover.1433937132.git.jpoimboe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-10 12:06   ` [PATCH v5 06/10] x86/asm/efi: Fix asmvalidate warnings for efi_stub_64.S Josh Poimboeuf
2015-06-10 12:06     ` Josh Poimboeuf
     [not found]     ` <3e1d9ce523b3174a49b4317cd8b1b85dfd0c319a.1433937132.git.jpoimboe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-11 13:14       ` Matt Fleming
2015-06-11 13:14         ` Matt Fleming
2015-06-12 19:24         ` Borislav Petkov
2015-06-10 12:06 ` [PATCH v5 07/10] x86/asm/acpi: Fix asmvalidate warnings for wakeup_64.S Josh Poimboeuf
2015-06-10 13:19   ` Pavel Machek
2015-06-10 14:08     ` Josh Poimboeuf
2015-06-11 12:36       ` Pavel Machek
2015-06-10 13:21   ` Pavel Machek
2015-06-10 14:13     ` Josh Poimboeuf
2015-06-11  6:13       ` Ingo Molnar
2015-06-10 12:06 ` [PATCH v5 08/10] x86/asm/head: Fix asmvalidate warnings for head_64.S Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 09/10] x86/asm/lib: Fix asmvalidate warnings for lib functions Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 10/10] x86/asm/lib: Fix asmvalidate warnings for rwsem.S Josh Poimboeuf
2015-06-10 12:16 ` [PATCH v5 00/10] x86/asm: Compile-time asm code validation Josh Poimboeuf
2015-06-10 13:08 ` Andi Kleen
2015-06-10 13:52   ` Josh Poimboeuf
2015-06-10 14:11     ` Andi Kleen
2015-06-10 14:32       ` Josh Poimboeuf
2015-06-10 15:04         ` Andi Kleen
2015-06-10 15:31           ` Josh Poimboeuf
2015-06-10 16:50             ` Josh Poimboeuf
2015-06-10 18:41               ` Andi Kleen
2015-06-10 19:43                 ` Josh Poimboeuf
2015-06-10 18:40             ` Andi Kleen
2015-06-10 19:36               ` Josh Poimboeuf
2015-06-10 19:38                 ` Andy Lutomirski
2015-06-10 19:51                   ` Josh Poimboeuf
2015-06-10 13:42 ` Pavel Machek
2015-06-10 14:20   ` Josh Poimboeuf
2015-06-10 18:24 ` Andy Lutomirski
2015-06-10 20:26   ` Josh Poimboeuf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150610202629.GE1125@treble.redhat.com \
    --to=jpoimboe@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.cz \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.