From: Pavel Machek <pavel@ucw.cz>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Michal Marek <mmarek@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
x86@kernel.org, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 07/10] x86/asm/acpi: Fix asmvalidate warnings for wakeup_64.S
Date: Thu, 11 Jun 2015 14:36:54 +0200 [thread overview]
Message-ID: <20150611123654.GA24528@amd> (raw)
In-Reply-To: <20150610140830.GA25848@treble.redhat.com>
Hi!
> > > 5. Remove superfluous rsp changes.
> >
> > Did you test the changes?
>
> Yes, I verified that it didn't break suspend/resume on my system.
Ok, so I can not see anything wrong, either. I'd like to understand
why the original code manipulated %rsp, but...
If you did testing with frame pointer on, you can get my
Acked-by: Pavel Machek <pavel@ucw.cz>
> > Do you plan to make similar changes to wakeup_32.S?
>
> Currently, asmvalidate is x86_64 only, so I'm only fixing the 64-bit
> stuff right now.
Well, you are "improving debuggability", afaict. It worked well before.
> > > @@ -108,8 +108,9 @@ ENTRY(do_suspend_lowlevel)
> > > movq pt_regs_r15(%rax), %r15
> > >
> > > xorl %eax, %eax
> > > - addq $8, %rsp
> > > - jmp restore_processor_state
> > > + call restore_processor_state
> > > + FP_RESTORE
> > > + ret
> > > ENDPROC(do_suspend_lowlevel)
> >
> > Umm. I rather liked the direct jump.
>
> Why?
It is both smaller and faster than the new code. But...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-06-11 12:36 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 12:06 [PATCH v5 00/10] x86/asm: Compile-time asm code validation Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros Josh Poimboeuf
2015-06-10 18:17 ` Pavel Machek
2015-06-10 18:24 ` Josh Poimboeuf
2015-06-11 4:22 ` Jiri Kosina
2015-06-11 6:46 ` Pavel Machek
2015-06-11 12:06 ` Jiri Kosina
2015-06-11 14:18 ` Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 02/10] x86: Compile-time asm code validation Josh Poimboeuf
2015-06-10 17:21 ` Andy Lutomirski
2015-06-10 17:53 ` Josh Poimboeuf
2015-06-10 18:15 ` Andy Lutomirski
2015-06-10 18:58 ` Josh Poimboeuf
2015-06-10 22:17 ` Josh Poimboeuf
2015-06-11 6:08 ` Ingo Molnar
2015-06-11 14:01 ` Josh Poimboeuf
2015-06-11 6:10 ` Ingo Molnar
2015-06-11 14:10 ` Josh Poimboeuf
2015-06-12 11:18 ` Pedro Alves
2015-06-12 14:10 ` Josh Poimboeuf
2015-06-12 16:00 ` Pedro Alves
2015-06-12 16:41 ` Josh Poimboeuf
2015-06-10 18:16 ` Vojtech Pavlik
2015-06-10 18:18 ` Andy Lutomirski
2015-06-10 12:06 ` [PATCH v5 03/10] x86/asm/entry: Fix asmvalidate warnings for entry_64_compat.S Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 04/10] x86/asm/crypto: Fix asmvalidate warnings for aesni-intel_asm.S Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 05/10] x86/asm/crypto: Fix asmvalidate warnings for ghash-clmulni-intel_asm.S Josh Poimboeuf
[not found] ` <cover.1433937132.git.jpoimboe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-10 12:06 ` [PATCH v5 06/10] x86/asm/efi: Fix asmvalidate warnings for efi_stub_64.S Josh Poimboeuf
2015-06-10 12:06 ` Josh Poimboeuf
[not found] ` <3e1d9ce523b3174a49b4317cd8b1b85dfd0c319a.1433937132.git.jpoimboe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-11 13:14 ` Matt Fleming
2015-06-11 13:14 ` Matt Fleming
2015-06-12 19:24 ` Borislav Petkov
2015-06-10 12:06 ` [PATCH v5 07/10] x86/asm/acpi: Fix asmvalidate warnings for wakeup_64.S Josh Poimboeuf
2015-06-10 13:19 ` Pavel Machek
2015-06-10 14:08 ` Josh Poimboeuf
2015-06-11 12:36 ` Pavel Machek [this message]
2015-06-10 13:21 ` Pavel Machek
2015-06-10 14:13 ` Josh Poimboeuf
2015-06-11 6:13 ` Ingo Molnar
2015-06-10 12:06 ` [PATCH v5 08/10] x86/asm/head: Fix asmvalidate warnings for head_64.S Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 09/10] x86/asm/lib: Fix asmvalidate warnings for lib functions Josh Poimboeuf
2015-06-10 12:06 ` [PATCH v5 10/10] x86/asm/lib: Fix asmvalidate warnings for rwsem.S Josh Poimboeuf
2015-06-10 12:16 ` [PATCH v5 00/10] x86/asm: Compile-time asm code validation Josh Poimboeuf
2015-06-10 13:08 ` Andi Kleen
2015-06-10 13:52 ` Josh Poimboeuf
2015-06-10 14:11 ` Andi Kleen
2015-06-10 14:32 ` Josh Poimboeuf
2015-06-10 15:04 ` Andi Kleen
2015-06-10 15:31 ` Josh Poimboeuf
2015-06-10 16:50 ` Josh Poimboeuf
2015-06-10 18:41 ` Andi Kleen
2015-06-10 19:43 ` Josh Poimboeuf
2015-06-10 18:40 ` Andi Kleen
2015-06-10 19:36 ` Josh Poimboeuf
2015-06-10 19:38 ` Andy Lutomirski
2015-06-10 19:51 ` Josh Poimboeuf
2015-06-10 13:42 ` Pavel Machek
2015-06-10 14:20 ` Josh Poimboeuf
2015-06-10 18:24 ` Andy Lutomirski
2015-06-10 20:26 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611123654.GA24528@amd \
--to=pavel@ucw.cz \
--cc=andi@firstfloor.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.