Re: [PATCH] drm/bridge/ptn3460: add include for gpiod*

Re: [PATCH] drm/bridge/ptn3460: add include for gpiod*

[Uwe Kleine-König]

Hello,

Cc += dri-devel@lists.freedesktop.org + kernel@pengutronix.de, forgot
that for the original submission. Also added (hopefully the right)
Geert.

On Mon, Jun 08, 2015 at 11:45:17AM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Fri, Jun 05, 2015 at 04:46:25PM +0200, Thierry Reding wrote:
> > On Mon, Jun 01, 2015 at 04:43:32PM +0200, Uwe Kleine-König wrote:
> > > This fixes:
> > > 
> > > 	  CC      drivers/gpu/drm/bridge/ptn3460.o
> > > 	drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_pre_enable’:
> > > 	drivers/gpu/drm/bridge/ptn3460.c:135:2: error: implicit declaration of function ‘gpiod_set_value’ [-Werror=implicit-function-declaration]
> > > 	  gpiod_set_value(ptn_bridge->gpio_pd_n, 1);
> > > 	  ^
> > > 	drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_probe’:
> > > 	drivers/gpu/drm/bridge/ptn3460.c:333:2: error: implicit declaration of function ‘devm_gpiod_get’ [-Werror=implicit-function-declaration]
> > > 	  ptn_bridge->gpio_pd_n = devm_gpiod_get(&client->dev, "powerdown");
> > > 	  ^
> > > 	drivers/gpu/drm/bridge/ptn3460.c:333:24: warning: assignment makes pointer from integer without a cast
> > > 	  ptn_bridge->gpio_pd_n = devm_gpiod_get(&client->dev, "powerdown");
> > > 				^
> > > 	drivers/gpu/drm/bridge/ptn3460.c:340:2: error: implicit declaration of function ‘gpiod_direction_output’ [-Werror=implicit-function-declaration]
> > > 	  ret = gpiod_direction_output(ptn_bridge->gpio_pd_n, 1);
> > > 	  ^
> > > 	drivers/gpu/drm/bridge/ptn3460.c:346:25: warning: assignment makes pointer from integer without a cast
> > > 	  ptn_bridge->gpio_rst_n = devm_gpiod_get(&client->dev, "reset");
> > > 				 ^
> > > 
> > > Fixes: af478d8823a7 ("drm/bridge: ptn3460: use gpiod interface")
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > ---
> > >  drivers/gpu/drm/bridge/ptn3460.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > Geert had sent similar patches a while ago, so I applied his instead.
> I didn't find where you applied it. Did you send this patch to Linus for
> 4.1?
If you want to get this into 4.1 it's about time to send it to Linus. Or
don't you consider it that urgent?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge/ptn3460: add include for gpiod*

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 2600 bytes --]

On Wed, Jun 10, 2015 at 09:15:25AM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> Cc += dri-devel@lists.freedesktop.org + kernel@pengutronix.de, forgot
> that for the original submission. Also added (hopefully the right)
> Geert.
> 
> On Mon, Jun 08, 2015 at 11:45:17AM +0200, Uwe Kleine-König wrote:
> > Hello,
> > 
> > On Fri, Jun 05, 2015 at 04:46:25PM +0200, Thierry Reding wrote:
> > > On Mon, Jun 01, 2015 at 04:43:32PM +0200, Uwe Kleine-König wrote:
> > > > This fixes:
> > > > 
> > > > 	  CC      drivers/gpu/drm/bridge/ptn3460.o
> > > > 	drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_pre_enable’:
> > > > 	drivers/gpu/drm/bridge/ptn3460.c:135:2: error: implicit declaration of function ‘gpiod_set_value’ [-Werror=implicit-function-declaration]
> > > > 	  gpiod_set_value(ptn_bridge->gpio_pd_n, 1);
> > > > 	  ^
> > > > 	drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_probe’:
> > > > 	drivers/gpu/drm/bridge/ptn3460.c:333:2: error: implicit declaration of function ‘devm_gpiod_get’ [-Werror=implicit-function-declaration]
> > > > 	  ptn_bridge->gpio_pd_n = devm_gpiod_get(&client->dev, "powerdown");
> > > > 	  ^
> > > > 	drivers/gpu/drm/bridge/ptn3460.c:333:24: warning: assignment makes pointer from integer without a cast
> > > > 	  ptn_bridge->gpio_pd_n = devm_gpiod_get(&client->dev, "powerdown");
> > > > 				^
> > > > 	drivers/gpu/drm/bridge/ptn3460.c:340:2: error: implicit declaration of function ‘gpiod_direction_output’ [-Werror=implicit-function-declaration]
> > > > 	  ret = gpiod_direction_output(ptn_bridge->gpio_pd_n, 1);
> > > > 	  ^
> > > > 	drivers/gpu/drm/bridge/ptn3460.c:346:25: warning: assignment makes pointer from integer without a cast
> > > > 	  ptn_bridge->gpio_rst_n = devm_gpiod_get(&client->dev, "reset");
> > > > 				 ^
> > > > 
> > > > Fixes: af478d8823a7 ("drm/bridge: ptn3460: use gpiod interface")
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > ---
> > > >  drivers/gpu/drm/bridge/ptn3460.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > 
> > > Geert had sent similar patches a while ago, so I applied his instead.
> > I didn't find where you applied it. Did you send this patch to Linus for
> > 4.1?
> If you want to get this into 4.1 it's about time to send it to Linus. Or
> don't you consider it that urgent?

This build error is triggered by somewhat artificial configuration
options and it's been present since v4.0, so I don't think it qualifies
as that urgent. It's in linux-next and should make it into v4.2.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge/ptn3460: add include for gpiod*

[Uwe Kleine-König]

Hello,

On Thu, Jun 11, 2015 at 09:13:10AM +0200, Thierry Reding wrote:
> On Wed, Jun 10, 2015 at 09:15:25AM +0200, Uwe Kleine-König wrote:
> > Hello,
> > 
> > Cc += dri-devel@lists.freedesktop.org + kernel@pengutronix.de, forgot
> > that for the original submission. Also added (hopefully the right)
> > Geert.
> > 
> > On Mon, Jun 08, 2015 at 11:45:17AM +0200, Uwe Kleine-König wrote:
> > > Hello,
> > > 
> > > On Fri, Jun 05, 2015 at 04:46:25PM +0200, Thierry Reding wrote:
> > > > On Mon, Jun 01, 2015 at 04:43:32PM +0200, Uwe Kleine-König wrote:
> > > > > This fixes:
> > > > > 
> > > > > 	  CC      drivers/gpu/drm/bridge/ptn3460.o
> > > > > 	drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_pre_enable’:
> > > > > 	drivers/gpu/drm/bridge/ptn3460.c:135:2: error: implicit declaration of function ‘gpiod_set_value’ [-Werror=implicit-function-declaration]
> > > > > 	  gpiod_set_value(ptn_bridge->gpio_pd_n, 1);
> > > > > 	  ^
> > > > > 	drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_probe’:
> > > > > 	drivers/gpu/drm/bridge/ptn3460.c:333:2: error: implicit declaration of function ‘devm_gpiod_get’ [-Werror=implicit-function-declaration]
> > > > > 	  ptn_bridge->gpio_pd_n = devm_gpiod_get(&client->dev, "powerdown");
> > > > > 	  ^
> > > > > 	drivers/gpu/drm/bridge/ptn3460.c:333:24: warning: assignment makes pointer from integer without a cast
> > > > > 	  ptn_bridge->gpio_pd_n = devm_gpiod_get(&client->dev, "powerdown");
> > > > > 				^
> > > > > 	drivers/gpu/drm/bridge/ptn3460.c:340:2: error: implicit declaration of function ‘gpiod_direction_output’ [-Werror=implicit-function-declaration]
> > > > > 	  ret = gpiod_direction_output(ptn_bridge->gpio_pd_n, 1);
> > > > > 	  ^
> > > > > 	drivers/gpu/drm/bridge/ptn3460.c:346:25: warning: assignment makes pointer from integer without a cast
> > > > > 	  ptn_bridge->gpio_rst_n = devm_gpiod_get(&client->dev, "reset");
> > > > > 				 ^
> > > > > 
> > > > > Fixes: af478d8823a7 ("drm/bridge: ptn3460: use gpiod interface")
> > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > > ---
> > > > >  drivers/gpu/drm/bridge/ptn3460.c | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > Geert had sent similar patches a while ago, so I applied his instead.
> > > I didn't find where you applied it. Did you send this patch to Linus for
> > > 4.1?
> > If you want to get this into 4.1 it's about time to send it to Linus. Or
> > don't you consider it that urgent?
> 
> This build error is triggered by somewhat artificial configuration
> options and it's been present since v4.0, so I don't think it qualifies
> as that urgent. It's in linux-next and should make it into v4.2.
Ok, up to you. IIRC the build bot found a config.

If you want you can add my Ack for the two fixes (currently
dcd43d6483a89210dba8726b3b49a4b3d9efdde7 and
dad3c3503462f59c6bec7edfa19dbde1857962c0 in next).

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel