From: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org
Cc: Christian Ruppert
<christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org>,
Fabio Mello <fabio.mello-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Jarkko Nikula
<jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Lucas De Marchi
<lucas.demarchi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Lucas De Marchi
<lucas.de.marchi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Subject: Re: [PATCH] i2c: designware: use enable on resume instead initialization
Date: Thu, 11 Jun 2015 12:38:08 +0300 [thread overview]
Message-ID: <20150611093808.GS1478@lahna.fi.intel.com> (raw)
In-Reply-To: <OF847FFF39.1FF5F96A-ONC1257E60.00506AFD-C1257E60.0052A8CE-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org>
On Wed, Jun 10, 2015 at 05:05:16PM +0200, christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org wrote:
> We should understand why the controller was disabled after successful
> transfers in the first place, however. Maybe some quirk with older
> versions of the hardware? Mika, do you have any memories about this?
I think it was in the original driver even before I did Intel specific
changes to that. I have no idea why it is done. Probably, like you said,
because some older version of the hardware needed it.
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: christian.ruppert@alitech.com
Cc: Christian Ruppert <christian.ruppert@abilis.com>,
Fabio Mello <fabio.mello@intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Lucas De Marchi <lucas.de.marchi@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: designware: use enable on resume instead initialization
Date: Thu, 11 Jun 2015 12:38:08 +0300 [thread overview]
Message-ID: <20150611093808.GS1478@lahna.fi.intel.com> (raw)
In-Reply-To: <OF847FFF39.1FF5F96A-ONC1257E60.00506AFD-C1257E60.0052A8CE@alitech.com>
On Wed, Jun 10, 2015 at 05:05:16PM +0200, christian.ruppert@alitech.com wrote:
> We should understand why the controller was disabled after successful
> transfers in the first place, however. Maybe some quirk with older
> versions of the hardware? Mika, do you have any memories about this?
I think it was in the original driver even before I did Intel specific
changes to that. I have no idea why it is done. Probably, like you said,
because some older version of the hardware needed it.
next prev parent reply other threads:[~2015-06-11 9:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 17:50 [PATCH] i2c: designware: use enable on resume instead initialization lucas.de.marchi-Re5JQEeQqe8AvxtiuMwx3w
2015-06-08 17:50 ` lucas.de.marchi
[not found] ` <1433785828-4100-1-git-send-email-lucas.de.marchi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-06-09 8:51 ` Mika Westerberg
2015-06-09 8:51 ` Mika Westerberg
[not found] ` <20150609085146.GD1478-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-06-09 18:29 ` Lucas De Marchi
2015-06-09 18:29 ` Lucas De Marchi
[not found] ` <CAKi4VAJwD45VbWuCHegfkB-tbgvgza52-cgVNF4AxF8NCuYyRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-10 7:07 ` Mika Westerberg
2015-06-10 7:07 ` Mika Westerberg
[not found] ` <OF847FFF39.1FF5F96A-ONC1257E60.00506AFD-C1257E60.0052A8CE@alitech.com>
[not found] ` <OF847FFF39.1FF5F96A-ONC1257E60.00506AFD-C1257E60.0052A8CE-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org>
2015-06-11 9:38 ` Mika Westerberg [this message]
2015-06-11 9:38 ` Mika Westerberg
2015-06-11 14:48 ` Lucas De Marchi
2015-06-11 14:48 ` Lucas De Marchi
[not found] ` <OF847FFF39.1FF5F96A-ONC1257E60.00506AFD-C1257E60.0052A8CE@LocalDomain>
2015-06-23 16:45 ` christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ
2015-06-23 16:45 ` christian.ruppert
[not found] ` <OFB47A681B.5488F019-ONC1257E6D.005A6CD2-C1257E6D.005BD52F-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org>
2015-06-23 17:02 ` Lucas De Marchi
2015-06-23 17:02 ` Lucas De Marchi
[not found] ` <CAKi4VA+t3d-XoqDiL9ez+9qDR_ndgGnAOhkpZsJyJ2tMjfCYLA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-24 7:36 ` christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ
2015-06-24 7:36 ` christian.ruppert
[not found] ` <OFB918064C.F72245F4-ONC1257E6E.00287EC7-C1257E6E.00299EF2-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org>
2015-06-24 11:27 ` Mika Westerberg
2015-06-24 11:27 ` Mika Westerberg
[not found] ` <20150624112723.GE827-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-06-24 12:56 ` De Marchi, Lucas
2015-06-24 12:56 ` De Marchi, Lucas
[not found] ` <1435150578.1075.5.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-24 13:18 ` mika.westerberg-VuQAYsv1563Yd54FQh9/CA
2015-06-24 13:18 ` mika.westerberg
2015-06-24 14:06 ` christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ
2015-06-24 14:06 ` christian.ruppert
2015-06-10 7:55 ` Mika Westerberg
2015-06-10 7:55 ` Mika Westerberg
[not found] ` <20150610075555.GO1478-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-06-12 22:45 ` Lucas De Marchi
2015-06-12 22:45 ` Lucas De Marchi
2015-06-15 9:29 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611093808.GS1478@lahna.fi.intel.com \
--to=mika.westerberg-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org \
--cc=christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org \
--cc=fabio.mello-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lucas.de.marchi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=lucas.demarchi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.