From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] dlm: remove unnecessary error check
Date: Thu, 11 Jun 2015 11:18:43 -0500 [thread overview]
Message-ID: <20150611161843.GA20918@redhat.com> (raw)
In-Reply-To: <55795930.1030608@suse.com>
On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote:
> Do you consider take the following clean up? If yes, I will send a
> formal patch, otherwise pls ignore it.
On first glance, the old and new code do not appear to do the same thing,
so let's leave it as it is.
> - to_nodeid = dlm_dir_nodeid(r);
WARNING: multiple messages have this Message-ID (diff)
From: David Teigland <teigland@redhat.com>
To: Guoqing Jiang <gqJiang@suse.com>
Cc: Bob Peterson <rpeterso@redhat.com>,
ccaulfie@redhat.com, cluster-devel@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check
Date: Thu, 11 Jun 2015 11:18:43 -0500 [thread overview]
Message-ID: <20150611161843.GA20918@redhat.com> (raw)
In-Reply-To: <55795930.1030608@suse.com>
On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote:
> Do you consider take the following clean up? If yes, I will send a
> formal patch, otherwise pls ignore it.
On first glance, the old and new code do not appear to do the same thing,
so let's leave it as it is.
> - to_nodeid = dlm_dir_nodeid(r);
next prev parent reply other threads:[~2015-06-11 16:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 9:46 [Cluster-devel] [PATCH] dlm: remove unnecessary error check Guoqing Jiang
2015-06-09 9:46 ` Guoqing Jiang
2015-06-09 12:09 ` [Cluster-devel] " Bob Peterson
2015-06-09 12:09 ` Bob Peterson
2015-06-10 2:39 ` Guoqing Jiang
2015-06-10 2:39 ` Guoqing Jiang
2015-06-10 2:50 ` Bob Peterson
2015-06-10 2:50 ` Bob Peterson
2015-06-10 3:10 ` Guoqing Jiang
2015-06-10 3:10 ` Guoqing Jiang
2015-06-10 12:26 ` Bob Peterson
2015-06-10 12:26 ` Bob Peterson
2015-06-11 2:39 ` Guoqing Jiang
2015-06-11 2:39 ` Guoqing Jiang
2015-06-10 15:24 ` David Teigland
2015-06-10 15:24 ` David Teigland
2015-06-11 9:47 ` Guoqing Jiang
2015-06-11 9:47 ` Guoqing Jiang
2015-06-11 16:18 ` David Teigland [this message]
2015-06-11 16:18 ` David Teigland
2015-06-17 2:14 ` Guoqing Jiang
2015-06-17 2:14 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611161843.GA20918@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.