From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Arun Siluvery <arun.siluvery@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 1/6] drm/i915/gen8: Add infrastructure to initialize WA batch buffers
Date: Mon, 15 Jun 2015 17:22:54 +0200 [thread overview]
Message-ID: <20150615152254.GC8341@phenom.ffwll.local> (raw)
In-Reply-To: <20150605110054.GL27056@nuc-i3427.alporthouse.com>
On Fri, Jun 05, 2015 at 12:00:54PM +0100, Chris Wilson wrote:
> On Fri, Jun 05, 2015 at 11:34:01AM +0100, Arun Siluvery wrote:
> > + /* FIXME: fill unused locations with NOOPs.
> > + * Replace these instructions with WA
> > + */
> > + while (index < end)
> > + reg_state[index++] = MI_NOOP;
>
> I found calling it reg_state was very confusing. Maybe batch, bb, data or cmd?
Concurred, reg_state sounds like an mmio dump not a batchbuffer. wa_batch
would be my naming bikeshed, but I'd go with either. If this is all that
needs changing I can do that while applying patches.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-15 15:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 10:34 [PATCH v3 0/6] Add Per-context WA using WA batch buffers Arun Siluvery
2015-06-05 10:34 ` [PATCH v3 1/6] drm/i915/gen8: Add infrastructure to initialize " Arun Siluvery
2015-06-05 10:56 ` Chris Wilson
2015-06-05 11:24 ` Siluvery, Arun
2015-06-05 11:36 ` Chris Wilson
2015-06-05 11:56 ` Siluvery, Arun
2015-06-05 11:00 ` Chris Wilson
2015-06-15 15:22 ` Daniel Vetter [this message]
2015-06-15 15:23 ` Siluvery, Arun
2015-06-05 13:54 ` Arun Siluvery
2015-06-05 10:34 ` [PATCH v3 2/6] drm/i915/gen8: Re-order init pipe_control in lrc mode Arun Siluvery
2015-06-05 13:55 ` Arun Siluvery
2015-06-09 15:27 ` Dave Gordon
2015-06-09 15:34 ` Siluvery, Arun
2015-06-05 10:34 ` [PATCH v3 3/6] drm/i915/gen8: Add WaDisableCtxRestoreArbitration workaround Arun Siluvery
2015-06-05 13:56 ` Arun Siluvery
2015-06-05 10:34 ` [PATCH v3 4/6] drm/i915/gen8: Add WaFlushCoherentL3CacheLinesAtContextSwitch workaround Arun Siluvery
2015-06-05 13:56 ` Arun Siluvery
2015-06-05 14:48 ` Ville Syrjälä
2015-06-12 11:51 ` Siluvery, Arun
2015-06-09 17:06 ` Dave Gordon
2015-06-05 10:34 ` [PATCH v3 5/6] drm/i915/gen8: Add WaClearSlmSpaceAtContextSwitch workaround Arun Siluvery
2015-06-05 13:57 ` Arun Siluvery
2015-06-05 10:34 ` [PATCH v3 6/6] drm/i915/gen8: Add WaRsRestoreWithPerCtxtBb workaround Arun Siluvery
2015-06-05 13:57 ` Arun Siluvery
2015-06-09 18:43 ` Dave Gordon
2015-06-12 11:58 ` Siluvery, Arun
2015-06-12 17:03 ` Dave Gordon
2015-06-15 14:10 ` Siluvery, Arun
2015-06-15 17:29 ` Dave Gordon
2015-06-15 18:09 ` Siluvery, Arun
2015-06-15 15:27 ` Daniel Vetter
2015-06-06 8:20 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615152254.GC8341@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arun.siluvery@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.