Re: [PATCH v3 1/6] drm/i915/gen8: Add infrastructure to initialize WA batch buffers

From: "Siluvery, Arun" <arun.siluvery@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 1/6] drm/i915/gen8: Add infrastructure to initialize WA batch buffers
Date: Mon, 15 Jun 2015 16:23:53 +0100	[thread overview]
Message-ID: <557EEE09.3060007@linux.intel.com> (raw)
In-Reply-To: <20150615152254.GC8341@phenom.ffwll.local>

On 15/06/2015 16:22, Daniel Vetter wrote:
> On Fri, Jun 05, 2015 at 12:00:54PM +0100, Chris Wilson wrote:
>> On Fri, Jun 05, 2015 at 11:34:01AM +0100, Arun Siluvery wrote:
>>> +	/* FIXME: fill unused locations with NOOPs.
>>> +	 * Replace these instructions with WA
>>> +	 */
>>> +        while (index < end)
>>> +		reg_state[index++] = MI_NOOP;
>>
>> I found calling it reg_state was very confusing. Maybe batch, bb, data or cmd?
>
> Concurred, reg_state sounds like an mmio dump not a batchbuffer. wa_batch
> would be my naming bikeshed, but I'd go with either. If this is all that
> needs changing I can do that while applying patches.
> -Daniel
>
I have already changed this to cmd.
There are some more comments from Dave which I am addressing now, I will 
send them soon.

regards
Arun

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx