[PATCH] ASoC: Intel Kconfig: add SND_SOC_INTEL_BOARDS option

[PATCH] ASoC: Intel Kconfig: add SND_SOC_INTEL_BOARDS option

[Michele Curti]

Machine drivers under boards folder must be available for both
SND_SST_MFLD_PLATFORM and SND_SOC_INTEL_SST.  This patch adds a
new kernel option SND_SOC_INTEL_BOARD to permit this.

Signed-off-by: Michele Curti <michele.curti@gmail.com>
---
 sound/soc/intel/Kconfig  | 5 +++++
 sound/soc/intel/Makefile | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index f3060a4..c442cd7 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -10,7 +10,11 @@ config SND_MFLD_MACHINE
           Say Y if you have such a device
           If unsure select "N".
 
+config SND_SOC_INTEL_BOARDS
+	tristate
+
 config SND_SST_MFLD_PLATFORM
+	select SND_SOC_INTEL_BOARDS
 	tristate
 
 config SND_SST_IPC
@@ -28,6 +32,7 @@ config SND_SST_IPC_ACPI
 config SND_SOC_INTEL_SST
 	tristate "ASoC support for Intel(R) Smart Sound Technology"
 	select SND_SOC_INTEL_SST_ACPI if ACPI
+	select SND_SOC_INTEL_BOARDS
 	depends on (X86 || COMPILE_TEST)
 	depends on DW_DMAC_CORE
 	help
diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile
index 3853ec2..4c4bf74 100644
--- a/sound/soc/intel/Makefile
+++ b/sound/soc/intel/Makefile
@@ -7,4 +7,4 @@ obj-$(CONFIG_SND_SOC_INTEL_BAYTRAIL) += baytrail/
 obj-$(CONFIG_SND_SST_MFLD_PLATFORM) += atom/
 
 # Machine support
-obj-$(CONFIG_SND_SOC_INTEL_SST) += boards/
+obj-$(CONFIG_SND_SOC_INTEL_BOARDS) += boards/
-- 
2.4.3

Re: [PATCH] ASoC: Intel Kconfig: add SND_SOC_INTEL_BOARDS option

[Vinod Koul]

On Thu, Jun 18, 2015 at 09:59:39PM +0200, Michele Curti wrote:
> Machine drivers under boards folder must be available for both
> SND_SST_MFLD_PLATFORM and SND_SOC_INTEL_SST.  This patch adds a
> new kernel option SND_SOC_INTEL_BOARD to permit this.

I dont think we need another config option, we should rather use SND_SOC :)

Also Liam, do we need a prompt for SND_SOC_INTEL_SST, i am thinking of
removing that one and have it selected by respective machine drivers?

-- 
~Vinod


> 
> Signed-off-by: Michele Curti <michele.curti@gmail.com>
> ---
>  sound/soc/intel/Kconfig  | 5 +++++
>  sound/soc/intel/Makefile | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index f3060a4..c442cd7 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -10,7 +10,11 @@ config SND_MFLD_MACHINE
>            Say Y if you have such a device
>            If unsure select "N".
>  
> +config SND_SOC_INTEL_BOARDS
> +	tristate
> +
>  config SND_SST_MFLD_PLATFORM
> +	select SND_SOC_INTEL_BOARDS
>  	tristate
>  
>  config SND_SST_IPC
> @@ -28,6 +32,7 @@ config SND_SST_IPC_ACPI
>  config SND_SOC_INTEL_SST
>  	tristate "ASoC support for Intel(R) Smart Sound Technology"
>  	select SND_SOC_INTEL_SST_ACPI if ACPI
> +	select SND_SOC_INTEL_BOARDS
>  	depends on (X86 || COMPILE_TEST)
>  	depends on DW_DMAC_CORE
>  	help
> diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile
> index 3853ec2..4c4bf74 100644
> --- a/sound/soc/intel/Makefile
> +++ b/sound/soc/intel/Makefile
> @@ -7,4 +7,4 @@ obj-$(CONFIG_SND_SOC_INTEL_BAYTRAIL) += baytrail/
>  obj-$(CONFIG_SND_SST_MFLD_PLATFORM) += atom/
>  
>  # Machine support
> -obj-$(CONFIG_SND_SOC_INTEL_SST) += boards/
> +obj-$(CONFIG_SND_SOC_INTEL_BOARDS) += boards/
> -- 
> 2.4.3
> 

-- 

Re: [PATCH] ASoC: Intel Kconfig: add SND_SOC_INTEL_BOARDS option

[Liam Girdwood]

On Fri, 2015-06-19 at 13:38 +0530, Vinod Koul wrote:
> On Thu, Jun 18, 2015 at 09:59:39PM +0200, Michele Curti wrote:
> > Machine drivers under boards folder must be available for both
> > SND_SST_MFLD_PLATFORM and SND_SOC_INTEL_SST.  This patch adds a
> > new kernel option SND_SOC_INTEL_BOARD to permit this.
> 
> I dont think we need another config option, we should rather use SND_SOC :)
> 
> Also Liam, do we need a prompt for SND_SOC_INTEL_SST, i am thinking of
> removing that one and have it selected by respective machine drivers?

Yeah, lets simplify our Kconfig now that we have cleaned up the intel
directory.

Liam