* Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines [not found] ` <1434743301-14774-7-git-send-email-isaac.a.travers@gmail.com> @ 2015-06-20 7:36 ` Sudip Mukherjee 0 siblings, 0 replies; 6+ messages in thread From: Sudip Mukherjee @ 2015-06-20 7:24 UTC (permalink / raw) To: Isaac Assegai; +Cc: linux-kernel, devel, linux-fbdev, gregkh, teddy.wang On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote: > Place braces on previous lines in ddk750_sii164.c to > rectify the following checkpatch errors: > ERROR: that open brace { should be on the previous line > > Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com> > --- > drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > index 7f58fbe..64d4291 100644 > --- a/drivers/staging/sm750fb/ddk750_sii164.c > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > @@ -136,8 +136,7 @@ long sii164InitChip( > #endif > > /* Check if SII164 Chip exists */ > - if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID)) > - { > + if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID) { ^^^^ you have not build tested it :( In function ‘sii164InitChip’: error: expected ‘)’ before ‘{’ token regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines @ 2015-06-20 7:36 ` Sudip Mukherjee 0 siblings, 0 replies; 6+ messages in thread From: Sudip Mukherjee @ 2015-06-20 7:36 UTC (permalink / raw) To: Isaac Assegai; +Cc: linux-kernel, devel, linux-fbdev, gregkh, teddy.wang On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote: > Place braces on previous lines in ddk750_sii164.c to > rectify the following checkpatch errors: > ERROR: that open brace { should be on the previous line > > Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com> > --- > drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > index 7f58fbe..64d4291 100644 > --- a/drivers/staging/sm750fb/ddk750_sii164.c > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > @@ -136,8 +136,7 @@ long sii164InitChip( > #endif > > /* Check if SII164 Chip exists */ > - if ((sii164GetVendorID() = SII164_VENDOR_ID) && (sii164GetDeviceID() = SII164_DEVICE_ID)) > - { > + if ((sii164GetVendorID() = SII164_VENDOR_ID) && (sii164GetDeviceID() = SII164_DEVICE_ID) { ^^^^ you have not build tested it :( In function ‘sii164InitChip’: error: expected ‘)’ before ‘{’ token regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines 2015-06-20 7:36 ` Sudip Mukherjee @ 2015-06-23 8:55 ` Dan Carpenter -1 siblings, 0 replies; 6+ messages in thread From: Dan Carpenter @ 2015-06-23 8:55 UTC (permalink / raw) To: Sudip Mukherjee Cc: Isaac Assegai, devel, gregkh, linux-fbdev, linux-kernel, teddy.wang On Sat, Jun 20, 2015 at 12:54:02PM +0530, Sudip Mukherjee wrote: > On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote: > > Place braces on previous lines in ddk750_sii164.c to > > rectify the following checkpatch errors: > > ERROR: that open brace { should be on the previous line > > > > Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com> > > --- > > drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++----------- > > 1 file changed, 5 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > > index 7f58fbe..64d4291 100644 > > --- a/drivers/staging/sm750fb/ddk750_sii164.c > > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > > @@ -136,8 +136,7 @@ long sii164InitChip( > > #endif > > > > /* Check if SII164 Chip exists */ > > - if ((sii164GetVendorID() = SII164_VENDOR_ID) && (sii164GetDeviceID() = SII164_DEVICE_ID)) > > - { > > + if ((sii164GetVendorID() = SII164_VENDOR_ID) && (sii164GetDeviceID() = SII164_DEVICE_ID) { > ^^^^ > you have not build tested it :( > In function ‘sii164InitChip’: > error: expected ‘)’ before ‘{’ token > I never get Isaac's emails. I think gmail is still sending them to the Spam folder? I searched my spam folder and don't see them though... regards, dan carpenter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines @ 2015-06-23 8:55 ` Dan Carpenter 0 siblings, 0 replies; 6+ messages in thread From: Dan Carpenter @ 2015-06-23 8:55 UTC (permalink / raw) To: Sudip Mukherjee Cc: Isaac Assegai, devel, gregkh, linux-fbdev, linux-kernel, teddy.wang On Sat, Jun 20, 2015 at 12:54:02PM +0530, Sudip Mukherjee wrote: > On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote: > > Place braces on previous lines in ddk750_sii164.c to > > rectify the following checkpatch errors: > > ERROR: that open brace { should be on the previous line > > > > Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com> > > --- > > drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++----------- > > 1 file changed, 5 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > > index 7f58fbe..64d4291 100644 > > --- a/drivers/staging/sm750fb/ddk750_sii164.c > > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > > @@ -136,8 +136,7 @@ long sii164InitChip( > > #endif > > > > /* Check if SII164 Chip exists */ > > - if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID)) > > - { > > + if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID) { > ^^^^ > you have not build tested it :( > In function ‘sii164InitChip’: > error: expected ‘)’ before ‘{’ token > I never get Isaac's emails. I think gmail is still sending them to the Spam folder? I searched my spam folder and don't see them though... regards, dan carpenter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines 2015-06-23 8:55 ` Dan Carpenter @ 2015-06-23 9:53 ` Sudip Mukherjee -1 siblings, 0 replies; 6+ messages in thread From: Sudip Mukherjee @ 2015-06-23 9:53 UTC (permalink / raw) To: Dan Carpenter Cc: Isaac Assegai, devel, gregkh, linux-fbdev, linux-kernel, teddy.wang On Tue, Jun 23, 2015 at 11:55:48AM +0300, Dan Carpenter wrote: > On Sat, Jun 20, 2015 at 12:54:02PM +0530, Sudip Mukherjee wrote: > > On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote: > > I never get Isaac's emails. I think gmail is still sending them to the > Spam folder? I searched my spam folder and don't see them though... maybe you need to create filters. I have filters and sometimes for some mails I will get "this was not sent to spam because of a filter you created" regards sudip ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines @ 2015-06-23 9:53 ` Sudip Mukherjee 0 siblings, 0 replies; 6+ messages in thread From: Sudip Mukherjee @ 2015-06-23 9:53 UTC (permalink / raw) To: Dan Carpenter Cc: Isaac Assegai, devel, gregkh, linux-fbdev, linux-kernel, teddy.wang On Tue, Jun 23, 2015 at 11:55:48AM +0300, Dan Carpenter wrote: > On Sat, Jun 20, 2015 at 12:54:02PM +0530, Sudip Mukherjee wrote: > > On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote: > > I never get Isaac's emails. I think gmail is still sending them to the > Spam folder? I searched my spam folder and don't see them though... maybe you need to create filters. I have filters and sometimes for some mails I will get "this was not sent to spam because of a filter you created" regards sudip ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-23 9:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1434743301-14774-1-git-send-email-isaac.a.travers@gmail.com>
[not found] ` <1434743301-14774-7-git-send-email-isaac.a.travers@gmail.com>
2015-06-20 7:24 ` [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines Sudip Mukherjee
2015-06-20 7:36 ` Sudip Mukherjee
2015-06-23 8:55 ` Dan Carpenter
2015-06-23 8:55 ` Dan Carpenter
2015-06-23 9:53 ` Sudip Mukherjee
2015-06-23 9:53 ` Sudip Mukherjee
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.