From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
nicolas.ferre@atmel.com, gregkh@linuxfoundation.org,
wenyou.yang@atmel.com, ludovic.desroches@atmel.com,
leilei.zhao@atmel.com, josh.wu@atmel.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
galak@codeaurora.org, ijc+devicetree@hellion.org.uk,
mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org
Subject: Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style
Date: Tue, 30 Jun 2015 23:53:19 +0200 [thread overview]
Message-ID: <20150630215319.GM485@piout.net> (raw)
In-Reply-To: <11308515.NsBzDiA1lH@wuerfel>
On 30/06/2015 at 22:28:42 +0200, Arnd Bergmann wrote :
> On Tuesday 30 June 2015 16:05:15 Cyrille Pitchen wrote:
> > +#define UART_PUT_CR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_CR)
> > +#define UART_GET_MR(port) __raw_readl((port)->membase + ATMEL_US_MR)
> > +#define UART_PUT_MR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_MR)
> > +#define UART_PUT_IER(port, v) __raw_writel(v, (port)->membase + ATMEL_US_IER)
> >
>
> How about removing these macros entirely? I'm not aware of other drivers
> doing it like this, and it does not seem to add any value?
>
> At the same time, you could use readl_relaxed() to make the driver
> endian-safe.
>
I think using readl_relaxed() would break avr32.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style
Date: Tue, 30 Jun 2015 23:53:19 +0200 [thread overview]
Message-ID: <20150630215319.GM485@piout.net> (raw)
In-Reply-To: <11308515.NsBzDiA1lH@wuerfel>
On 30/06/2015 at 22:28:42 +0200, Arnd Bergmann wrote :
> On Tuesday 30 June 2015 16:05:15 Cyrille Pitchen wrote:
> > +#define UART_PUT_CR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_CR)
> > +#define UART_GET_MR(port) __raw_readl((port)->membase + ATMEL_US_MR)
> > +#define UART_PUT_MR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_MR)
> > +#define UART_PUT_IER(port, v) __raw_writel(v, (port)->membase + ATMEL_US_IER)
> >
>
> How about removing these macros entirely? I'm not aware of other drivers
> doing it like this, and it does not seem to add any value?
>
> At the same time, you could use readl_relaxed() to make the driver
> endian-safe.
>
I think using readl_relaxed() would break avr32.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-06-30 21:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 14:05 [PATCH v3 0/4] tty/serial: at91: add support to FIFOs Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
[not found] ` <cover.1435672649.git.cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-06-30 14:05 ` [PATCH v3 1/4] ARM: at91/dt: add a new DT property to support FIFOs on Atmel USARTs Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
[not found] ` <9f0f19d2fe05ea95572b467ec49ecd11389e3be9.1435672649.git.cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-06-30 20:28 ` Arnd Bergmann
2015-06-30 20:28 ` Arnd Bergmann
2015-06-30 20:28 ` Arnd Bergmann
2015-06-30 21:53 ` Alexandre Belloni [this message]
2015-06-30 21:53 ` Alexandre Belloni
2015-07-02 13:36 ` Cyrille Pitchen
2015-07-02 13:36 ` Cyrille Pitchen
2015-07-02 13:36 ` Cyrille Pitchen
2015-06-30 14:05 ` [PATCH v3 4/4] tty/serial: at91: use 32bit writes into TX FIFO when DMA is enabled Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` [PATCH v3 3/4] tty/serial: at91: add support to FIFOs Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630215319.GM485@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=josh.wu@atmel.com \
--cc=leilei.zhao@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.