From: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
leilei.zhao-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
julia.lawall-L2FTfq7BK8M@public.gmane.org
Subject: Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style
Date: Thu, 2 Jul 2015 15:36:49 +0200 [thread overview]
Message-ID: <55953E71.4070109@atmel.com> (raw)
In-Reply-To: <11308515.NsBzDiA1lH@wuerfel>
Hi Arnd,
I've just sent a new series of patches to remove all those macros.
By the way, the patch dedicated to this update was created using coccinelle.
Based on Alexandre comment, I leave __raw_writel() and __raw_readl() for now.
Best Regards,
Cyrille
Le 30/06/2015 22:28, Arnd Bergmann a écrit :
> On Tuesday 30 June 2015 16:05:15 Cyrille Pitchen wrote:
>> +#define UART_PUT_CR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_CR)
>> +#define UART_GET_MR(port) __raw_readl((port)->membase + ATMEL_US_MR)
>> +#define UART_PUT_MR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_MR)
>> +#define UART_PUT_IER(port, v) __raw_writel(v, (port)->membase + ATMEL_US_IER)
>>
>
> How about removing these macros entirely? I'm not aware of other drivers
> doing it like this, and it does not seem to add any value?
>
> At the same time, you could use readl_relaxed() to make the driver
> endian-safe.
>
> Arnd
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: cyrille.pitchen@atmel.com (Cyrille Pitchen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style
Date: Thu, 2 Jul 2015 15:36:49 +0200 [thread overview]
Message-ID: <55953E71.4070109@atmel.com> (raw)
In-Reply-To: <11308515.NsBzDiA1lH@wuerfel>
Hi Arnd,
I've just sent a new series of patches to remove all those macros.
By the way, the patch dedicated to this update was created using coccinelle.
Based on Alexandre comment, I leave __raw_writel() and __raw_readl() for now.
Best Regards,
Cyrille
Le 30/06/2015 22:28, Arnd Bergmann a ?crit :
> On Tuesday 30 June 2015 16:05:15 Cyrille Pitchen wrote:
>> +#define UART_PUT_CR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_CR)
>> +#define UART_GET_MR(port) __raw_readl((port)->membase + ATMEL_US_MR)
>> +#define UART_PUT_MR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_MR)
>> +#define UART_PUT_IER(port, v) __raw_writel(v, (port)->membase + ATMEL_US_IER)
>>
>
> How about removing these macros entirely? I'm not aware of other drivers
> doing it like this, and it does not seem to add any value?
>
> At the same time, you could use readl_relaxed() to make the driver
> endian-safe.
>
> Arnd
>
WARNING: multiple messages have this Message-ID (diff)
From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <nicolas.ferre@atmel.com>, <gregkh@linuxfoundation.org>,
<wenyou.yang@atmel.com>, <ludovic.desroches@atmel.com>,
<leilei.zhao@atmel.com>, <josh.wu@atmel.com>,
<alexandre.belloni@free-electrons.com>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <galak@codeaurora.org>,
<ijc+devicetree@hellion.org.uk>, <mark.rutland@arm.com>,
<pawel.moll@arm.com>, <robh+dt@kernel.org>,
<julia.lawall@lip6.fr>
Subject: Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style
Date: Thu, 2 Jul 2015 15:36:49 +0200 [thread overview]
Message-ID: <55953E71.4070109@atmel.com> (raw)
In-Reply-To: <11308515.NsBzDiA1lH@wuerfel>
Hi Arnd,
I've just sent a new series of patches to remove all those macros.
By the way, the patch dedicated to this update was created using coccinelle.
Based on Alexandre comment, I leave __raw_writel() and __raw_readl() for now.
Best Regards,
Cyrille
Le 30/06/2015 22:28, Arnd Bergmann a écrit :
> On Tuesday 30 June 2015 16:05:15 Cyrille Pitchen wrote:
>> +#define UART_PUT_CR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_CR)
>> +#define UART_GET_MR(port) __raw_readl((port)->membase + ATMEL_US_MR)
>> +#define UART_PUT_MR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_MR)
>> +#define UART_PUT_IER(port, v) __raw_writel(v, (port)->membase + ATMEL_US_IER)
>>
>
> How about removing these macros entirely? I'm not aware of other drivers
> doing it like this, and it does not seem to add any value?
>
> At the same time, you could use readl_relaxed() to make the driver
> endian-safe.
>
> Arnd
>
next prev parent reply other threads:[~2015-07-02 13:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 14:05 [PATCH v3 0/4] tty/serial: at91: add support to FIFOs Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
[not found] ` <cover.1435672649.git.cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-06-30 14:05 ` [PATCH v3 1/4] ARM: at91/dt: add a new DT property to support FIFOs on Atmel USARTs Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
[not found] ` <9f0f19d2fe05ea95572b467ec49ecd11389e3be9.1435672649.git.cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-06-30 20:28 ` Arnd Bergmann
2015-06-30 20:28 ` Arnd Bergmann
2015-06-30 20:28 ` Arnd Bergmann
2015-06-30 21:53 ` Alexandre Belloni
2015-06-30 21:53 ` Alexandre Belloni
2015-07-02 13:36 ` Cyrille Pitchen [this message]
2015-07-02 13:36 ` Cyrille Pitchen
2015-07-02 13:36 ` Cyrille Pitchen
2015-06-30 14:05 ` [PATCH v3 4/4] tty/serial: at91: use 32bit writes into TX FIFO when DMA is enabled Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` [PATCH v3 3/4] tty/serial: at91: add support to FIFOs Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
2015-06-30 14:05 ` Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55953E71.4070109@atmel.com \
--to=cyrille.pitchen-aife0yeh4naavxtiumwx3w@public.gmane.org \
--cc=alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=julia.lawall-L2FTfq7BK8M@public.gmane.org \
--cc=leilei.zhao-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.