All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: "Michał Kępień" <kernel@kempniu.pl>
Cc: Matthew Garrett <mjg@redhat.com>,
	Rezwanul Kabir <Rezwanul_Kabir@dell.com>,
	Alex Hung <alex.hung@canonical.com>,
	Darren Hart <dvhart@infradead.org>,
	platform-driver-x86@vger.kernel.org
Subject: Re: Dell Vostro V131 hotkeys revisited
Date: Fri, 3 Jul 2015 13:43:56 +0200	[thread overview]
Message-ID: <20150703114356.GL1841@pali> (raw)
In-Reply-To: <20150703112611.GA3030@eudyptula.hq.kempniu.pl>

On Friday 03 July 2015 13:26:11 Michał Kępień wrote:
> > It looks like above buffer has format of *new* event (0002 - length of
> > event, 0000 - type of event, e025 - data). But when using legacy keymap
> > then dell-wmi.c parse events with old format (which means type=0000 is
> > dropped and data=e025 is translated to some key).
> > 
> > This is even harder as I thought. Looks like big mess and now I would
> > say, without documentation for Dell WMI events we are not able to fix
> > this correctly without breaking other laptops...
> 
> As far as I understand, the specific case that we're dealing with here
> is that on one laptop model a certain WMI event is generated along with
> a keycode while another mothel generates the same WMI event without an
> accompanying keycode. Currently the Dell WMI driver ignores the WMI
> event in question, but it is processed by i8042.
> 
> Could we perhaps do the opposite for this specific event, i.e. filter it
> out using the i8042 filter in dell-laptop.c and translate the WMI event
> into a keycode in dell-wmi.c? This shouldn't conflict with the dell-rbtn
> driver as there are no ACPI devices on an XPS L502X that could be
> handled by that driver [1] and thus the i8042 filter should be
> installed. However, that i8042 keycode could potentially be generated on
> other, WMI-less models and such a change would break them, rendering it
> unacceptable. I also assumed pressing the hotkey in question on an XPS
> L502X produces the same i8042 keycode as the WMI event code indicates...
> 
> [1] this statement is based on the DSDT dump from a Dell XPS L502X that
>     I found here: https://launchpadlibrarian.net/68880655/DSDT.dsl
> 

I would like to wait for documentation and not to invent/mess something
again and more. Creating big list with DMI names and associate hooks for
them based on "our" observation is good way to hell!

We even do not know:

1) how to activate code for receiving events
2) what is format of which event
3) which keypress should be reported by i8042 bus and which via ACPI/WMI

-- 
Pali Rohár
pali.rohar@gmail.com

  reply	other threads:[~2015-07-03 11:43 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 11:26 Dell Vostro V131 hotkeys revisited Michał Kępień
2015-06-23 11:46 ` Pali Rohár
2015-06-23 19:40   ` Michał Kępień
2015-06-23 19:47     ` Pali Rohár
2015-06-24 11:18       ` Michał Kępień
2015-06-24 13:23         ` Pali Rohár
2015-06-25  9:02           ` Michał Kępień
2015-06-27 18:50             ` Pali Rohár
2015-06-30  7:38               ` Michał Kępień
2015-06-30  8:00                 ` Pali Rohár
2015-07-01  8:32                   ` Michał Kępień
2015-07-01  8:40                     ` Pali Rohár
2015-07-01 10:11                       ` Michał Kępień
2015-07-01 10:55                         ` Pali Rohár
2015-07-02 20:41                           ` Michał Kępień
2015-07-02 20:58                             ` Pali Rohár
2015-07-03  6:52                               ` Michał Kępień
2015-07-03  7:48                                 ` Pali Rohár
2015-07-03 11:26                                   ` Michał Kępień
2015-07-03 11:43                                     ` Pali Rohár [this message]
2015-07-03 13:23                                       ` Michał Kępień
2015-07-03 13:32                                         ` Pali Rohár
2015-07-03 13:50                                           ` Michał Kępień
2015-07-03 14:09                                             ` Pali Rohár
2015-07-03 14:14                                               ` Pali Rohár
2015-07-03 18:22                                                 ` Gabriele Mazzotta
2015-07-03 20:07                                                   ` Michał Kępień
2015-07-03 20:30                                                     ` Gabriele Mazzotta
2015-07-04 19:41                                                   ` Pali Rohár
2015-07-04 20:34                                                     ` Gabriele Mazzotta
2015-07-03 20:55                                               ` Michał Kępień
2015-07-04 19:13                                               ` Pali Rohár
2015-07-04 19:47                                                 ` Pali Rohár
2015-07-27 19:27                                               ` Michał Kępień
2015-07-07 18:36                                   ` Mario Limonciello
2015-07-07 21:01                                     ` Pali Rohár
2015-07-08  3:21                                       ` Michał Kępień
2015-07-08  3:53                                     ` Michał Kępień
2015-07-22  7:35                                       ` Michał Kępień
2015-08-31  9:51                                         ` Michał Kępień
2015-09-10  4:38                                           ` Darren Hart
2015-11-13 10:17                                             ` Michał Kępień
2015-12-07 11:43                                               ` Pali Rohár
2015-12-16  9:05                                                 ` Michał Kępień
2015-12-16  9:30                                                   ` Pali Rohár
2015-12-16 10:29                                                     ` Hans de Goede
2015-12-17  8:05                                                       ` Michał Kępień
2015-12-17  9:48                                                         ` Hans de Goede
2015-12-17 18:47                                                           ` Pali Rohár
2015-12-17 18:54                                                             ` Hans de Goede
2015-12-19  0:02                                                               ` Darren Hart
2015-12-19  9:59                                                                 ` Pali Rohár
2015-12-18  7:10                                                           ` Michał Kępień
2015-12-18 10:44                                                             ` Hans de Goede
2015-12-19 12:31                                                               ` Michał Kępień
2015-07-04 21:24                                 ` Pali Rohár
2015-07-05  4:51                                   ` Michał Kępień
2015-06-23 12:18 ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150703114356.GL1841@pali \
    --to=pali.rohar@gmail.com \
    --cc=Rezwanul_Kabir@dell.com \
    --cc=alex.hung@canonical.com \
    --cc=dvhart@infradead.org \
    --cc=kernel@kempniu.pl \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.