All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: "Michał Kępień" <kernel@kempniu.pl>,
	"Alex Hung" <alex.hung@canonical.com>,
	"Matthew Garrett" <mjg@redhat.com>,
	"Rezwanul Kabir" <Rezwanul_Kabir@dell.com>,
	"Darren Hart" <dvhart@infradead.org>,
	platform-driver-x86@vger.kernel.org
Subject: Re: Dell Vostro V131 hotkeys revisited
Date: Sat, 4 Jul 2015 21:41:51 +0200	[thread overview]
Message-ID: <20150704194151.GA13641@pali> (raw)
In-Reply-To: <2310738.zonLnARZZM@xps13>

On Friday 03 July 2015 20:22:22 Gabriele Mazzotta wrote:
> On Friday 03 July 2015 16:14:54 Pali Rohár wrote:
> > On Friday 03 July 2015 16:09:01 Pali Rohár wrote:
> > > Yes, "vendor does not say anything" is also what could happen...
> > > 
> > > Then in your case, I would need to know format of *all* events which can
> > > your laptop via WMI receive. If we collect as more as possible events
> > > from different laptops we can try to abstract format/interface.
> > > 
> > 
> > CCing Gabriele, can you please provide buffers of all possible WMI
> > events which can be received on your dell machine via dell-wmi.ko?
> > (just enable pr_debug() in dell-wmi.c)
> 
> Hi,
> 
> here below there's what I could get from my XPS13 9333.
> 
> [ 6115.412615] wifi - disable/enable
> [ 6115.710966] dell_wmi: Received WMI event (06 00 00 00 08 e0 1d 03 0a 00 00 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)
> [ 6115.710972] dell_wmi: Key e008 pressed
> [ 6116.766483] dell_wmi: Received WMI event (06 00 00 00 08 e0 1d 03 09 00 00 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)
> [ 6116.766483] dell_wmi: Key e008 pressed
> [ 6121.555618] battery health
> [ 6122.093304] dell_wmi: Received WMI event (02 00 00 00 07 e0 1d 03 08 00 00 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)
> [ 6122.093313] dell_wmi: Key e007 pressed
> [ 6128.550329] brightness down
> [ 6129.739787] dell_wmi: Received WMI event (03 00 00 00 05 e0 0e 00 08 00 00 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)
> [ 6129.739799] dell_wmi: Key e005 pressed
> [ 6134.469814] brightness up
> [ 6134.853151] dell_wmi: Received WMI event (03 00 00 00 06 e0 0f 00 08 00 00 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)
> [ 6134.853157] dell_wmi: Key e006 pressed
> [ 6143.153178] keyboard illumination - level 2 1 0
> [ 6143.056422] dell_wmi: Received WMI event (03 00 00 00 0c e0 02 00 09 00 00 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)
> [ 6143.056427] dell_wmi: Key e00c pressed
> [ 6143.768556] dell_wmi: Received WMI event (03 00 00 00 0c e0 01 00 09 00 00 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)
> [ 6143.768566] dell_wmi: Key e00c pressed
> [ 6144.340347] dell_wmi: Received WMI event (03 00 00 00 0c e0 00 00 09 00 00 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)
> [ 6144.340357] dell_wmi: Key e00c pressed
> [ 6176.922331] volume down
> [ 6177.325737] dell_wmi: Received WMI event (02 00 00 00 2e e0 01 00 08 00 00 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)
> [ 6177.325746] dell_wmi: Key e02e pressed
> [ 6182.892971] volume up
> [ 6183.240709] dell_wmi: Received WMI event (02 00 00 00 30 e0 01 00 08 00 00 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)
> [ 6183.240715] dell_wmi: Key e030 pressed
> [ 6188.932940] mute
> [ 6190.453967] dell_wmi: Received WMI event (02 00 00 00 f7 e0 01 00 08 00 00 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)
> [ 6190.453975] dell_wmi: Key e0f7 pressed

Hi!

I have looked at your DSDT table which you sent me months ago and I see
that your ACPI code does not clear WMI buffer before sending it to OS
driver (buffer named INFO, and u16* values in INF0, INF1, ... INF7).

And I see that your ACPI code always send one "message" in WMI buffer,
not like on my E6440 when I receive one "message" for keypress event and
appended "message" that keyboard backlight was changed.

Because your ACPI code does not clear buffer before filling it, it is
impossible to parse correctly on both machines (my and your)... :-(

But I see that on your machine ACPI set "WMI Interface Version" to 0x0.
On my machine and Michał's too it is set to 0x1. (See ACPI-WMI%20.pdf)
So maybe this information is important?

Anyway your ACPI DSDT code contains all possible WMI events (for your
machine) as they are generated by ACPI and not by EC/firmware...

-- 
Pali Rohár
pali.rohar@gmail.com

  parent reply	other threads:[~2015-07-05  8:51 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 11:26 Dell Vostro V131 hotkeys revisited Michał Kępień
2015-06-23 11:46 ` Pali Rohár
2015-06-23 19:40   ` Michał Kępień
2015-06-23 19:47     ` Pali Rohár
2015-06-24 11:18       ` Michał Kępień
2015-06-24 13:23         ` Pali Rohár
2015-06-25  9:02           ` Michał Kępień
2015-06-27 18:50             ` Pali Rohár
2015-06-30  7:38               ` Michał Kępień
2015-06-30  8:00                 ` Pali Rohár
2015-07-01  8:32                   ` Michał Kępień
2015-07-01  8:40                     ` Pali Rohár
2015-07-01 10:11                       ` Michał Kępień
2015-07-01 10:55                         ` Pali Rohár
2015-07-02 20:41                           ` Michał Kępień
2015-07-02 20:58                             ` Pali Rohár
2015-07-03  6:52                               ` Michał Kępień
2015-07-03  7:48                                 ` Pali Rohár
2015-07-03 11:26                                   ` Michał Kępień
2015-07-03 11:43                                     ` Pali Rohár
2015-07-03 13:23                                       ` Michał Kępień
2015-07-03 13:32                                         ` Pali Rohár
2015-07-03 13:50                                           ` Michał Kępień
2015-07-03 14:09                                             ` Pali Rohár
2015-07-03 14:14                                               ` Pali Rohár
2015-07-03 18:22                                                 ` Gabriele Mazzotta
2015-07-03 20:07                                                   ` Michał Kępień
2015-07-03 20:30                                                     ` Gabriele Mazzotta
2015-07-04 19:41                                                   ` Pali Rohár [this message]
2015-07-04 20:34                                                     ` Gabriele Mazzotta
2015-07-03 20:55                                               ` Michał Kępień
2015-07-04 19:13                                               ` Pali Rohár
2015-07-04 19:47                                                 ` Pali Rohár
2015-07-27 19:27                                               ` Michał Kępień
2015-07-07 18:36                                   ` Mario Limonciello
2015-07-07 21:01                                     ` Pali Rohár
2015-07-08  3:21                                       ` Michał Kępień
2015-07-08  3:53                                     ` Michał Kępień
2015-07-22  7:35                                       ` Michał Kępień
2015-08-31  9:51                                         ` Michał Kępień
2015-09-10  4:38                                           ` Darren Hart
2015-11-13 10:17                                             ` Michał Kępień
2015-12-07 11:43                                               ` Pali Rohár
2015-12-16  9:05                                                 ` Michał Kępień
2015-12-16  9:30                                                   ` Pali Rohár
2015-12-16 10:29                                                     ` Hans de Goede
2015-12-17  8:05                                                       ` Michał Kępień
2015-12-17  9:48                                                         ` Hans de Goede
2015-12-17 18:47                                                           ` Pali Rohár
2015-12-17 18:54                                                             ` Hans de Goede
2015-12-19  0:02                                                               ` Darren Hart
2015-12-19  9:59                                                                 ` Pali Rohár
2015-12-18  7:10                                                           ` Michał Kępień
2015-12-18 10:44                                                             ` Hans de Goede
2015-12-19 12:31                                                               ` Michał Kępień
2015-07-04 21:24                                 ` Pali Rohár
2015-07-05  4:51                                   ` Michał Kępień
2015-06-23 12:18 ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150704194151.GA13641@pali \
    --to=pali.rohar@gmail.com \
    --cc=Rezwanul_Kabir@dell.com \
    --cc=alex.hung@canonical.com \
    --cc=dvhart@infradead.org \
    --cc=gabriele.mzt@gmail.com \
    --cc=kernel@kempniu.pl \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.